Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the commit fixing a memory leak in AWS SDK #8823

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jepett0
Copy link
Collaborator

@jepett0 jepett0 commented Sep 5, 2024

During the 610th import of YDB GitHub code to arcadia/contrib, it was discovered that RTMR tests use a static (!) wrapper of TKikimrRunner. It breaks the proper order of destruction of objects and:

  1. static std::shared_ptr<HttpClientFactory> s_HttpClientFactory(nullptr);

    is destroyed before

  2. is called. It causes operator-> of the s_HttpClientFactory in the CleanupHttp() function to read a deleted vtable leading to a segfault.

It will take too long to fix RTMR tests, so the proposed solution is to introduce a service mask to control AWS SDK initialization and disable it for RTMR tests.

Note: by default EnableAwsService flag will be enabled.
Another note: if you ask yourself "Does the new flag need to be added to EnableYQ() setup function?", the answer I got from YQ team is "no".

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 17:02:23 UTC Pre-commit check linux-x86_64-release-clang14 for 5308a93 has started.
2024-09-05 17:05:46 UTC ya make is running...
🟢 2024-09-05 17:31:03 UTC Build successful.

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 17:09:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5308a93 has started.
2024-09-05 17:12:08 UTC ya make is running...
🟡 2024-09-05 18:29:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15948 14529 0 27 1370 22

2024-09-05 18:31:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-05 18:41:22 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 34 0 13 0 18

2024-09-05 18:41:30 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-05 18:48:17 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
35 (only retried tests) 17 0 0 0 18

🟢 2024-09-05 18:48:24 UTC Build successful.
🟢 2024-09-05 18:49:04 UTC ydbd size 8.4 GiB changed* by -10.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0923723 merge: 5308a93 diff diff %
ydbd size 8 999 711 248 Bytes 8 999 700 256 Bytes -10.7 KiB -0.000%
ydbd stripped size 486 651 784 Bytes 486 651 304 Bytes -480 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 5, 2024

2024-09-05 17:25:58 UTC Pre-commit check linux-x86_64-release-asan for 5308a93 has started.
2024-09-05 17:29:49 UTC ya make is running...
🔴 2024-09-05 19:31:59 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11327 11223 0 33 34 37

🟢 2024-09-05 19:32:58 UTC Build successful.
🟢 2024-09-05 19:33:31 UTC ydbd size 5.6 GiB changed* by +3.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0923723 merge: 5308a93 diff diff %
ydbd size 6 017 850 224 Bytes 6 017 853 520 Bytes +3.2 KiB +0.000%
ydbd stripped size 1 507 095 888 Bytes 1 507 097 200 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@jepett0 jepett0 marked this pull request as ready for review September 6, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants