Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset __async_replica attr after changing REPLICATION_MODE to NONE #8610

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Sep 2, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@CyberROFL CyberROFL requested a review from ijon September 2, 2024 13:02
@CyberROFL CyberROFL requested a review from Enjection September 2, 2024 13:02
@CyberROFL CyberROFL self-assigned this Sep 2, 2024
@CyberROFL CyberROFL marked this pull request as ready for review September 2, 2024 13:02
Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 13:03:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 668dfae has started.
2024-09-02 13:06:05 UTC ya make is running...
🟡 2024-09-02 14:12:25 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39189 33758 0 12 5401 18

2024-09-02 14:15:54 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-02 14:25:52 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
30 (only retried tests) 17 0 0 0 13

🟢 2024-09-02 14:25:59 UTC Build successful.
🟢 2024-09-02 14:26:31 UTC ydbd size 8.3 GiB changed* by +784 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 599a1f3 merge: 668dfae diff diff %
ydbd size 8 917 688 184 Bytes 8 917 688 968 Bytes +784 Bytes +0.000%
ydbd stripped size 481 765 640 Bytes 481 765 704 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 13:03:20 UTC Pre-commit check linux-x86_64-release-asan for 668dfae has started.
2024-09-02 13:06:15 UTC ya make is running...
🔴 2024-09-02 14:39:56 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10173 10108 0 22 24 19

🟢 2024-09-02 14:40:49 UTC Build successful.
🟢 2024-09-02 14:41:20 UTC ydbd size 5.5 GiB changed* by +1.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 599a1f3 merge: 668dfae diff diff %
ydbd size 5 953 757 064 Bytes 5 953 758 344 Bytes +1.2 KiB +0.000%
ydbd stripped size 1 489 328 976 Bytes 1 489 329 168 Bytes +192 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 2, 2024

2024-09-02 13:03:29 UTC Pre-commit check linux-x86_64-release-clang14 for 668dfae has started.
2024-09-02 13:06:19 UTC ya make is running...
🟢 2024-09-02 13:16:48 UTC Build successful.

@CyberROFL CyberROFL enabled auto-merge (squash) September 2, 2024 14:34
@CyberROFL CyberROFL merged commit 946c37e into ydb-platform:main Sep 2, 2024
12 of 14 checks passed
@CyberROFL CyberROFL deleted the reset-async-replica-attr branch September 2, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants