Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage healthceck fixes (#8460) #8527

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

fix for false-postives in storage healthcheck

Changelog category

  • Bugfix

Additional information

  • ensure that initial statuses are not treated as errors
  • do not treat no status as error
  • only look at vslots with correct generation

Co-authored-by: Alexander Rutkovsky <alexvru@ydb.tech>
@vporyadke vporyadke requested a review from a team as a code owner August 30, 2024 11:00
Copy link

github-actions bot commented Aug 30, 2024

2024-08-30 11:03:29 UTC Pre-commit check for 46035b2 has started.
2024-08-30 11:06:28 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-30 11:28:49 UTC Build successful.
2024-08-30 11:29:05 UTC Tests are running...
🔴 2024-08-30 13:40:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10027 9966 0 19 27 15

🟢 2024-08-30 13:41:15 UTC ydbd size 5.6 GiB changed* by +7.1 KiB, which is < 100.0 KiB vs stable-24-3-7-hotfix: OK

ydbd size dash stable-24-3-7-hotfix: 3c07380 merge: 46035b2 diff diff %
ydbd size 6 008 033 712 Bytes 6 008 040 976 Bytes +7.1 KiB +0.000%
ydbd stripped size 1 493 630 624 Bytes 1 493 632 160 Bytes +1.5 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 30, 2024

2024-08-30 11:17:51 UTC Pre-commit check for 46035b2 has started.
2024-08-30 11:20:21 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-30 11:26:14 UTC Build successful.

Copy link

github-actions bot commented Aug 30, 2024

2024-08-30 11:21:57 UTC Pre-commit check for 46035b2 has started.
2024-08-30 11:25:04 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-30 12:04:10 UTC Build successful.
2024-08-30 12:04:26 UTC Tests are running...
🔴 2024-08-30 13:31:44 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14320 12990 0 2 1314 14

🟢 2024-08-30 13:32:22 UTC ydbd size 8.3 GiB changed* by +16.2 KiB, which is < 100.0 KiB vs stable-24-3-7-hotfix: OK

ydbd size dash stable-24-3-7-hotfix: 3c07380 merge: 46035b2 diff diff %
ydbd size 8 876 605 648 Bytes 8 876 622 224 Bytes +16.2 KiB +0.000%
ydbd stripped size 481 162 088 Bytes 481 162 792 Bytes +704 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke merged commit 9ffc09d into ydb-platform:stable-24-3-7-hotfix Aug 30, 2024
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants