Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TBlockJoinState #8368

Conversation

igormunkin
Copy link
Collaborator

This changeset contains refactoring of the TState class for BlockMapJoinCore computation node. The refactoring is required for further patches, implementing joins with cartesian products.

Follows up #7947
Follows up #8030

Changelog category

  • Not for changelog (changelog entry is not required)

@igormunkin igormunkin added the area/yql YQL query language issues label Aug 28, 2024
@igormunkin igormunkin requested a review from vitstn August 28, 2024 07:26
@igormunkin igormunkin self-assigned this Aug 28, 2024
@igormunkin igormunkin requested a review from a team as a code owner August 28, 2024 07:26
Copy link

github-actions bot commented Aug 28, 2024

2024-08-28 07:28:09 UTC Pre-commit check for 04441e6 has started.
2024-08-28 07:30:56 UTC Check linux-x86_64-release-clang14 is running...
2024-08-28 07:36:17 UTC Check cancelled

Copy link

github-actions bot commented Aug 28, 2024

2024-08-28 07:29:27 UTC Pre-commit check for 04441e6 has started.
2024-08-28 07:32:16 UTC Check linux-x86_64-release-asan is running...
2024-08-28 07:36:18 UTC Check cancelled

Copy link

github-actions bot commented Aug 28, 2024

2024-08-28 07:30:38 UTC Pre-commit check for 04441e6 has started.
2024-08-28 07:33:23 UTC Check linux-x86_64-relwithdebinfo is running...
2024-08-28 07:36:13 UTC Check cancelled

@igormunkin igormunkin force-pushed the YQL-18498-block-map-join-comp-node-refactor-state branch from a9abfcd to 7dd2969 Compare August 28, 2024 07:35
Copy link

github-actions bot commented Aug 28, 2024

2024-08-28 07:37:52 UTC Pre-commit check for 5eccc01 has started.
2024-08-28 07:38:38 UTC Check cancelled

@igormunkin igormunkin force-pushed the YQL-18498-block-map-join-comp-node-refactor-state branch from 7dd2969 to a863229 Compare August 28, 2024 07:38
Copy link

github-actions bot commented Aug 28, 2024

2024-08-28 07:39:59 UTC Pre-commit check for 038c363 has started.
2024-08-28 07:42:45 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-28 09:13:13 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13227 13152 0 13 36 26

🟢 2024-08-28 09:14:19 UTC Build successful.
🟢 2024-08-28 09:14:49 UTC ydbd size 5.5 GiB changed* by -256.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d9565af merge: 038c363 diff diff %
ydbd size 5 928 957 760 Bytes 5 928 694 696 Bytes -256.9 KiB -0.004%
ydbd stripped size 1 489 135 312 Bytes 1 489 040 304 Bytes -92.8 KiB -0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 28, 2024

2024-08-28 07:40:11 UTC Pre-commit check for 038c363 has started.
2024-08-28 07:42:57 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-28 07:48:42 UTC Build successful.

Copy link

github-actions bot commented Aug 28, 2024

2024-08-28 07:42:22 UTC Pre-commit check for 038c363 has started.
2024-08-28 07:45:09 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-28 09:00:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75315 61601 0 5 13686 23

2024-08-28 09:07:11 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-28 09:17:34 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32 (only retried tests) 21 0 0 0 11

🟢 2024-08-28 09:17:41 UTC Build successful.
🟢 2024-08-28 09:18:25 UTC ydbd size 8.2 GiB changed* by -389.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d9565af merge: 038c363 diff diff %
ydbd size 8 800 127 584 Bytes 8 799 728 296 Bytes -389.9 KiB -0.005%
ydbd stripped size 479 865 064 Bytes 479 831 720 Bytes -32.6 KiB -0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@igormunkin igormunkin merged commit 47066e9 into ydb-platform:main Aug 29, 2024
10 of 12 checks passed
@igormunkin igormunkin deleted the YQL-18498-block-map-join-comp-node-refactor-state branch August 29, 2024 10:09
stanislav-shchetinin pushed a commit to stanislav-shchetinin/ydb that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yql YQL query language issues not-for-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants