Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpc ds: manually optimize join order to workaround #7565 #8163

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented Aug 22, 2024

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

This just hides issues with unrewritten cross joins and should be eventually reverted. Verified with CBO on scale 1 and 10

@yumkam yumkam requested a review from resetius August 22, 2024 14:11
@yumkam yumkam marked this pull request as ready for review August 22, 2024 14:11
Copy link

github-actions bot commented Aug 22, 2024

2024-08-22 14:12:38 UTC Pre-commit check for 3465708 has started.
2024-08-22 14:14:59 UTC Check linux-x86_64-release-asan is running...
🟢 2024-08-22 14:21:38 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
612 610 0 0 2 0

🟢 2024-08-22 14:21:46 UTC Build successful.
🟡 2024-08-22 14:22:01 UTC ydbd size 5.5 GiB changed* by +516.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ba138ae merge: 3465708 diff diff %
ydbd size 5 890 308 040 Bytes 5 890 837 000 Bytes +516.6 KiB +0.009%
ydbd stripped size 1 479 110 672 Bytes 1 479 175 216 Bytes +63.0 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@aakulaga-ydb aakulaga-ydb self-requested a review August 22, 2024 14:19
@aakulaga-ydb aakulaga-ydb enabled auto-merge (squash) August 22, 2024 14:20
Copy link

github-actions bot commented Aug 22, 2024

2024-08-22 14:26:36 UTC Pre-commit check for 3465708 has started.
2024-08-22 14:30:12 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-22 14:32:33 UTC Build successful.

Copy link

github-actions bot commented Aug 22, 2024

2024-08-22 14:30:57 UTC Pre-commit check for 3465708 has started.
2024-08-22 14:33:37 UTC Check linux-x86_64-relwithdebinfo is running...
🟢 2024-08-22 14:39:54 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
628 626 0 0 2 0

🟢 2024-08-22 14:40:03 UTC Build successful.
🟡 2024-08-22 14:40:19 UTC ydbd size 8.2 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ba138ae merge: 3465708 diff diff %
ydbd size 8 752 126 272 Bytes 8 753 289 120 Bytes +1.1 MiB +0.013%
ydbd stripped size 476 005 128 Bytes 476 019 848 Bytes +14.4 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants