count-min-sketch as index #7978
Conversation
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
| sketchesByColumns.emplace(id, TCountMinSketch::Create()); | ||
| } | ||
|
|
||
| for (const auto& [indexKey, keyPortions] : spg->GetPortionsIndex().GetPoints()) { |
There was a problem hiding this comment.
вот тут нужно spg->GetPortions() взять и сканировать только те что Visible
There was a problem hiding this comment.
давай ты это сделаешь в отдельном акторе, передав туда spg->GetPortions() Visible отфильтрованные
There was a problem hiding this comment.
spg->GetPortions() взять и сканировать только те что Visible
Это сделал.
Рефакторинг с выносом сканирования в отдельный актор я хочу сделать в следующем PR
| @@ -267,7 +281,7 @@ std::vector<TTableInfo> CreateDatabaseColumnTables(TTestEnv& env, ui8 tableCount | |||
| auto& runtime = *env.GetServer().GetRuntime(); | |||
| auto sender = runtime.AllocateEdgeActor(); | |||
|
|
|||
| runtime.SimulateSleep(TDuration::Seconds(10)); | |||
| runtime.SimulateSleep(TDuration::Seconds(30)); | |||
There was a problem hiding this comment.
Можно этот Sleep заменить на ожидание какого-то события? Иначе тесты могут мигать.
There was a problem hiding this comment.
Вопрос за рамками этого PR
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪ ⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
|
⚪
🟢
*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation |
Should be the same as #6581, but should run only relevant checks