Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDC] Do not lose presition during float/double to json serialization #7625

Merged

Conversation

dcherednik
Copy link
Member

No description provided.

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 15:07:52 UTC Pre-commit check for eac6778 has started.
2024-08-09 15:11:30 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-09 17:11:00 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9730 9687 0 8 22 13

🟢 2024-08-09 17:12:05 UTC Build successful.
🟢 2024-08-09 17:12:33 UTC ydbd size 5.4 GiB changed* by -1.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 633ff57 merge: eac6778 diff diff %
ydbd size 5 843 780 776 Bytes 5 843 779 752 Bytes -1.0 KiB -0.000%
ydbd stripped size 1 468 104 912 Bytes 1 468 104 336 Bytes -576 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 15:10:20 UTC Pre-commit check for eac6778 has started.
2024-08-09 15:13:00 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-09 15:17:49 UTC Build successful.

Copy link

github-actions bot commented Aug 9, 2024

2024-08-09 15:12:53 UTC Pre-commit check for eac6778 has started.
2024-08-09 15:15:40 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 16:51:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14059 12703 0 3 1339 14

2024-08-09 16:53:24 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-09 17:05:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20 (only retried tests) 6 0 2 4 8

2024-08-09 17:05:11 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-09 17:12:47 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 6 0 0 0 8

🟢 2024-08-09 17:12:54 UTC Build successful.
🟢 2024-08-09 17:13:25 UTC ydbd size 8.1 GiB changed* by -232 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 633ff57 merge: eac6778 diff diff %
ydbd size 8 688 682 368 Bytes 8 688 682 136 Bytes -232 Bytes -0.000%
ydbd stripped size 472 752 392 Bytes 472 752 328 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik merged commit 80fec6c into ydb-platform:main Aug 12, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants