Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logging AST with free arguments. #7573

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

Tony-Romanov
Copy link
Collaborator

No description provided.

@Tony-Romanov Tony-Romanov added area/yql YQL query language issues bugfix labels Aug 8, 2024
@github-actions github-actions bot removed the bugfix label Aug 8, 2024
@Tony-Romanov Tony-Romanov changed the title Allow free args Allow logging AST with free arguments. Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 13:13:55 UTC Pre-commit check for a2a09d5 has started.
2024-08-08 13:17:09 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 15:35:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71984 58376 0 2 13594 12

2024-08-08 15:45:47 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-08 15:57:03 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19 (only retried tests) 5 0 2 4 8

2024-08-08 16:04:04 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-08 16:11:54 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 6 0 0 0 8

🟢 2024-08-08 16:19:05 UTC Build successful.
🟢 2024-08-08 16:19:42 UTC ydbd size 8.1 GiB changed* by +2.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 423d2b7 merge: a2a09d5 diff diff %
ydbd size 8 676 083 536 Bytes 8 676 086 520 Bytes +2.9 KiB +0.000%
ydbd stripped size 472 184 008 Bytes 472 184 136 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 13:16:20 UTC Pre-commit check for a2a09d5 has started.
2024-08-08 13:19:35 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-08 13:25:25 UTC Build successful.

Copy link

github-actions bot commented Aug 8, 2024

2024-08-08 13:30:20 UTC Pre-commit check for a2a09d5 has started.
2024-08-08 13:34:35 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-08 16:00:28 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10488 10415 0 19 36 18

🟢 2024-08-08 16:01:48 UTC Build successful.
🟢 2024-08-08 16:02:21 UTC ydbd size 5.4 GiB changed* by +1.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 423d2b7 merge: a2a09d5 diff diff %
ydbd size 5 834 601 800 Bytes 5 834 603 656 Bytes +1.8 KiB +0.000%
ydbd stripped size 1 465 571 600 Bytes 1 465 572 240 Bytes +640 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@Tony-Romanov Tony-Romanov marked this pull request as ready for review August 8, 2024 17:48
@Tony-Romanov Tony-Romanov requested a review from a team as a code owner August 8, 2024 17:48
@Tony-Romanov Tony-Romanov enabled auto-merge (squash) August 8, 2024 17:48
@Tony-Romanov
Copy link
Collaborator Author

@Tony-Romanov Tony-Romanov merged commit 3a7b275 into ydb-platform:main Aug 9, 2024
12 of 18 checks passed
@Tony-Romanov Tony-Romanov deleted the allow_free_args branch August 9, 2024 08:42
spuchin pushed a commit to spuchin/ydb that referenced this pull request Aug 12, 2024
spuchin added a commit that referenced this pull request Aug 13, 2024
Co-authored-by: Tony-Romanov <150126326+Tony-Romanov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yql YQL query language issues bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants