Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitional flag FIX_UNUSED_PARAMETR_PLS=1 (devtools request) #7330

Merged

Conversation

maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Jul 31, 2024

Changelog entry

Current protobuf broke "unused variable" warning. FIX_UNUSED_PARAMETR_PLS=1 fixes it.

Next steps:

  • enable flag
  • remove after rightlib sync with FIX_UNUSED_PARAMETR_PLS=1 behaviour as default

79da630 -- related commit

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 16:41:59 UTC Pre-commit check for d78cf17 has started.
2024-07-31 16:46:39 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-31 16:54:18 UTC Build failed. see the logs.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 16:43:34 UTC Pre-commit check for d78cf17 has started.
2024-07-31 16:48:12 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-07-31 16:56:06 UTC Build failed. see the logs.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 16:43:37 UTC Pre-commit check for d78cf17 has started.
2024-07-31 16:48:12 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-31 16:57:41 UTC Build failed. see the logs.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 21:13:57 UTC Pre-commit check for 8d86cc1 has started.
2024-07-31 21:18:38 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-07-31 22:17:49 UTC Build failed. see the logs.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 21:14:11 UTC Pre-commit check for 8d86cc1 has started.
2024-07-31 21:18:52 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-31 22:08:14 UTC Build failed. see the logs.

Copy link

github-actions bot commented Jul 31, 2024

2024-07-31 21:16:38 UTC Pre-commit check for 8d86cc1 has started.
2024-07-31 21:21:34 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-31 22:08:44 UTC Build failed. see the logs.

@maximyurchuk maximyurchuk requested a review from a team as a code owner August 1, 2024 07:45
Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 07:46:32 UTC Pre-commit check for d48263b has started.
2024-08-01 07:51:14 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-01 08:30:23 UTC Build failed. see the logs.

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 07:46:47 UTC Pre-commit check for d48263b has started.
2024-08-01 07:51:35 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-01 08:36:16 UTC Build failed. see the logs.

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 07:48:44 UTC Pre-commit check for d48263b has started.
2024-08-01 07:53:43 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-08-01 08:42:34 UTC Build failed. see the logs.

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 10:12:57 UTC Pre-commit check for 15b2937 has started.
2024-08-01 10:17:50 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-01 10:36:09 UTC Build failed. see the logs.

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 10:15:32 UTC Pre-commit check for 15b2937 has started.
2024-08-01 10:21:01 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-08-01 10:31:56 UTC Build failed. see the logs.

@maximyurchuk maximyurchuk requested a review from a team as a code owner August 1, 2024 10:53
Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 10:57:59 UTC Pre-commit check for a4368ef has started.
2024-08-01 11:02:42 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-01 11:09:20 UTC Build successful.

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 10:58:10 UTC Pre-commit check for a4368ef has started.
2024-08-01 11:02:51 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-01 13:33:49 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15829 15747 0 12 53 17

🟢 2024-08-01 13:35:39 UTC Build successful.
🟢 2024-08-01 13:36:09 UTC ydbd size 5.4 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3ec1778 merge: a4368ef diff diff %
ydbd size 5 841 768 136 Bytes 5 841 768 040 Bytes -96 Bytes -0.000%
ydbd stripped size 1 463 994 448 Bytes 1 463 994 384 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 10:58:14 UTC Pre-commit check for a4368ef has started.
2024-08-01 11:03:03 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-01 13:21:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77397 63793 0 2 13588 14

2024-08-01 13:31:49 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-01 13:40:26 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19 (only retried tests) 10 0 0 0 9

🟢 2024-08-01 13:44:34 UTC ydbd size 8.1 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 3ec1778 merge: a4368ef diff diff %
ydbd size 8 672 679 072 Bytes 8 672 678 992 Bytes -80 Bytes -0.000%
ydbd stripped size 472 081 000 Bytes 472 081 000 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-08-01 13:44:35 UTC Check cancelled

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 13:48:21 UTC Pre-commit check for 66e8b7e has started.
2024-08-01 13:51:41 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-01 16:29:15 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14468 14400 0 9 45 14

🟢 2024-08-01 16:31:22 UTC Build successful.
🟢 2024-08-01 16:31:49 UTC ydbd size 5.4 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 774401f merge: 66e8b7e diff diff %
ydbd size 5 842 324 016 Bytes 5 842 323 920 Bytes -96 Bytes -0.000%
ydbd stripped size 1 464 110 480 Bytes 1 464 110 416 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 13:50:33 UTC Pre-commit check for 66e8b7e has started.
2024-08-01 13:54:00 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-01 17:14:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75959 62351 0 7 13587 14

2024-08-01 17:23:23 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟡 2024-08-01 17:31:24 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22 (only retried tests) 9 0 5 0 8

2024-08-01 17:38:35 UTC Failed tests rerun (try 3) linux-x86_64-relwithdebinfo is running...
🔴 2024-08-01 17:46:47 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14 (only retried tests) 1 0 5 0 8

🟢 2024-08-01 17:53:49 UTC Build successful.
🟢 2024-08-01 17:54:23 UTC ydbd size 8.1 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 774401f merge: 66e8b7e diff diff %
ydbd size 8 673 384 768 Bytes 8 673 384 672 Bytes -96 Bytes -0.000%
ydbd stripped size 472 106 984 Bytes 472 106 984 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Aug 1, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Aug 1, 2024
Copy link

github-actions bot commented Aug 1, 2024

2024-08-01 23:09:37 UTC Pre-commit check for fdb0a3f has started.
2024-08-01 23:13:19 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-01 23:58:50 UTC Build successful.

Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 00:55:09 UTC Pre-commit check for fdb0a3f has started.
2024-08-02 00:58:53 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-02 03:04:03 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14468 14413 0 4 37 14

🟢 2024-08-02 03:05:37 UTC Build successful.
🟢 2024-08-02 03:06:06 UTC ydbd size 5.4 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c0c6ab2 merge: fdb0a3f diff diff %
ydbd size 5 842 854 176 Bytes 5 842 854 080 Bytes -96 Bytes -0.000%
ydbd stripped size 1 464 161 104 Bytes 1 464 161 040 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Aug 2, 2024

2024-08-02 00:55:48 UTC Pre-commit check for fdb0a3f has started.
2024-08-02 00:59:29 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 03:14:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75958 62350 0 4 13588 16

2024-08-02 03:23:25 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-02 03:31:49 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24 (only retried tests) 11 0 0 1 12

🟢 2024-08-02 03:39:06 UTC Build successful.
🟢 2024-08-02 03:39:40 UTC ydbd size 8.1 GiB changed* by -80 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: c0c6ab2 merge: fdb0a3f diff diff %
ydbd size 8 674 766 744 Bytes 8 674 766 664 Bytes -80 Bytes -0.000%
ydbd stripped size 472 123 112 Bytes 472 123 112 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants