Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up tables manager in schemeshard #7229

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

use hash instead of set to prevent TPathId slow comparision

  • Performance improvement

use hash instead of set to prevent TPathId slow comparision
Copy link

github-actions bot commented Jul 30, 2024

2024-07-30 06:10:05 UTC Pre-commit check for 390cdc3 has started.
2024-07-30 06:12:58 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-30 08:25:23 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9691 9109 0 83 324 175

🟢 2024-07-30 08:26:21 UTC Build successful.
🟢 2024-07-30 08:27:15 UTC ydbd size 5.2 GiB changed* by +32.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 75ab2b2 merge: 390cdc3 diff diff %
ydbd size 5 570 361 072 Bytes 5 570 394 272 Bytes +32.4 KiB +0.001%
ydbd stripped size 1 199 093 424 Bytes 1 199 099 760 Bytes +6.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 30, 2024

2024-07-30 06:10:18 UTC Pre-commit check for 390cdc3 has started.
2024-07-30 06:13:20 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-30 07:50:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13987 12638 0 1 1326 22

2024-07-30 07:51:43 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-30 07:59:23 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19 (only retried tests) 11 0 0 0 8

🟢 2024-07-30 08:00:31 UTC Build successful.
🟢 2024-07-30 08:01:16 UTC ydbd size 8.1 GiB changed* by +60.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 75ab2b2 merge: 390cdc3 diff diff %
ydbd size 8 677 212 552 Bytes 8 677 274 496 Bytes +60.5 KiB +0.001%
ydbd stripped size 471 842 208 Bytes 471 844 704 Bytes +2.4 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 30, 2024

2024-07-30 06:10:22 UTC Pre-commit check for 390cdc3 has started.
2024-07-30 06:13:21 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-30 06:23:12 UTC Build successful.

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review July 30, 2024 10:58
@ivanmorozov333 ivanmorozov333 merged commit a87900c into ydb-platform:main Jul 30, 2024
11 of 13 checks passed
@ivanmorozov333 ivanmorozov333 deleted the speed_up_tables_manager_in_SS branch July 30, 2024 10:58
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 9, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 10, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 11, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 12, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 13, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants