Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support of CREATE TYPE in DDL for extensions #7157

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

vitstn
Copy link
Collaborator

@vitstn vitstn commented Jul 26, 2024

Changelog entry

...

Changelog category

  • New feature

Additional information

...

@vitstn vitstn requested a review from a team as a code owner July 26, 2024 19:12
@vitstn vitstn added area/yql YQL query language issues area/pg labels Jul 26, 2024
@vitstn vitstn requested review from igormunkin and nepal July 26, 2024 19:13
Copy link

github-actions bot commented Jul 26, 2024

2024-07-26 19:14:38 UTC Pre-commit check for 9a80d4c has started.
2024-07-26 19:16:48 UTC Check cancelled

Copy link

github-actions bot commented Jul 26, 2024

2024-07-26 19:15:33 UTC Pre-commit check for 9a80d4c has started.
2024-07-26 19:16:40 UTC Check cancelled

Copy link

github-actions bot commented Jul 26, 2024

2024-07-26 19:18:40 UTC Pre-commit check for b5eec8e has started.
2024-07-26 19:22:14 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 21:56:51 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15239 14640 0 88 338 173

🟢 2024-07-26 21:58:17 UTC Build successful.
🟡 2024-07-26 21:59:06 UTC ydbd size 5.2 GiB changed* by +151.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ce348a9 merge: b5eec8e diff diff %
ydbd size 5 565 455 808 Bytes 5 565 611 368 Bytes +151.9 KiB +0.003%
ydbd stripped size 1 198 388 176 Bytes 1 198 402 160 Bytes +13.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 26, 2024

2024-07-26 19:19:51 UTC Pre-commit check for b5eec8e has started.
2024-07-26 19:23:14 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 20:08:36 UTC Build successful.

Copy link

github-actions bot commented Jul 26, 2024

2024-07-26 19:22:17 UTC Pre-commit check for b5eec8e has started.
2024-07-26 19:25:36 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-26 21:57:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76621 63057 0 1 13547 16

2024-07-26 22:05:57 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-26 22:14:23 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15 (only retried tests) 7 0 0 0 8

🟢 2024-07-26 22:21:28 UTC Build successful.
🟡 2024-07-26 22:22:03 UTC ydbd size 8.1 GiB changed* by +109.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ce348a9 merge: b5eec8e diff diff %
ydbd size 8 668 688 856 Bytes 8 668 801 296 Bytes +109.8 KiB +0.001%
ydbd stripped size 471 546 816 Bytes 471 554 944 Bytes +7.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 28, 2024

2024-07-28 08:54:07 UTC Pre-commit check for cd97123 has started.
2024-07-28 08:57:26 UTC Check linux-x86_64-relwithdebinfo is running...
🟢 2024-07-28 11:19:53 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76606 63047 0 0 13547 12

🟢 2024-07-28 11:27:58 UTC Build successful.
🟡 2024-07-28 11:28:38 UTC ydbd size 8.1 GiB changed* by +105.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ae7146c merge: cd97123 diff diff %
ydbd size 8 674 427 424 Bytes 8 674 535 760 Bytes +105.8 KiB +0.001%
ydbd stripped size 471 778 752 Bytes 471 782 784 Bytes +3.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 28, 2024

2024-07-28 08:54:08 UTC Pre-commit check for cd97123 has started.
2024-07-28 08:57:25 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-28 09:23:52 UTC Build successful.

Copy link

github-actions bot commented Jul 28, 2024

2024-07-28 08:54:11 UTC Pre-commit check for cd97123 has started.
2024-07-28 08:57:39 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-28 11:38:04 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15223 14620 0 89 337 177

🟢 2024-07-28 11:39:28 UTC Build successful.
🟡 2024-07-28 11:40:34 UTC ydbd size 5.2 GiB changed* by +156.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: ae7146c merge: cd97123 diff diff %
ydbd size 5 568 957 240 Bytes 5 569 116 952 Bytes +156.0 KiB +0.003%
ydbd stripped size 1 198 908 880 Bytes 1 198 927 024 Bytes +17.7 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vitstn vitstn enabled auto-merge (squash) July 28, 2024 21:33
Copy link
Collaborator

@igormunkin igormunkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitstn, thanks for the patch! LGTM.

@vitstn vitstn merged commit a169e9b into ydb-platform:main Jul 29, 2024
10 of 12 checks passed
@vitstn vitstn deleted the pg_ext_type branch July 29, 2024 10:00
MrLolthe1st pushed a commit to MrLolthe1st/ydb that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pg area/yql YQL query language issues new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants