Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix viewer redirects #7103

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

adameat
Copy link
Member

@adameat adameat commented Jul 25, 2024

Changelog entry

fix viewer redirects when we make a call to newer node via older one

Changelog category

  • Bugfix

Copy link

github-actions bot commented Jul 25, 2024

2024-07-25 12:04:11 UTC Pre-commit check for 5f61327 has started.
2024-07-25 12:07:02 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-25 14:36:30 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10354 9765 0 90 326 173

🟢 2024-07-25 14:37:34 UTC Build successful.
🟡 2024-07-25 14:38:21 UTC ydbd size 5.2 GiB changed* by +135.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0567dd5 merge: 5f61327 diff diff %
ydbd size 5 563 214 000 Bytes 5 563 352 264 Bytes +135.0 KiB +0.002%
ydbd stripped size 1 198 026 032 Bytes 1 198 054 768 Bytes +28.1 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jul 25, 2024

2024-07-25 12:06:09 UTC Pre-commit check for 5f61327 has started.
2024-07-25 12:09:02 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-25 12:45:57 UTC Build successful.

Copy link

github-actions bot commented Jul 25, 2024

2024-07-25 12:06:39 UTC Pre-commit check for 5f61327 has started.
2024-07-25 12:09:32 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-07-25 14:22:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39029 33742 0 1 5274 12

2024-07-25 14:26:41 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-07-25 14:34:06 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13 (only retried tests) 3 0 0 1 9

🟢 2024-07-25 14:37:20 UTC Build successful.
🟡 2024-07-25 14:37:59 UTC ydbd size 8.1 GiB changed* by +240.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 0567dd5 merge: 5f61327 diff diff %
ydbd size 8 665 305 392 Bytes 8 665 551 832 Bytes +240.7 KiB +0.003%
ydbd stripped size 471 462 368 Bytes 471 476 352 Bytes +13.7 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Member

@the-ancient-1 the-ancient-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adameat adameat enabled auto-merge (squash) July 25, 2024 12:07
@adameat adameat merged commit e5a42a2 into ydb-platform:main Jul 25, 2024
11 of 13 checks passed
adameat added a commit to adameat/ydb that referenced this pull request Jul 26, 2024
adameat added a commit that referenced this pull request Jul 29, 2024
adameat added a commit to adameat/ydb that referenced this pull request Oct 1, 2024
@adameat adameat deleted the handle-redirects-viewer-proxy branch November 14, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants