Enhanced monitoring for serverless tenants in Hive KIKIMR-19289 #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberROFL
reviewed
Dec 25, 2023
ydb/core/mind/hive/monitoring.cpp
Outdated
| THashMap<TSubDomainKey, size_t> tabletsRunningInOtherDomains; | ||
| THashMap<TSubDomainKey, size_t> tabletsTotal; | ||
|
|
||
| for (const auto& [_, tablet] : Self->Tablets) { |
There was a problem hiding this comment.
А вот тут, по соседству, тоже по всем таблеткам пробегают
https://github.com/ydb-platform/ydb/blob/main/ydb/core/mind/hive/monitoring.cpp#L238
|
Note This is an automated comment that will be appended during run. 🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 9a77c62.
🔴 linux-x86_64-release-asan: some tests FAILED for commit 9a77c62.
|
|
Yeah, going through all tablets for a monitoring page is not the end of the world. Still, have you considered keeping those stats in memory and updating them whenever a tablet changes its volatile state? |
CyberROFL
previously approved these changes
Dec 28, 2023
vporyadke
previously approved these changes
Dec 28, 2023
38c4c9c to
1d77d19
Compare
vporyadke
approved these changes
Dec 29, 2023
Closed
adameat
pushed a commit
to adameat/ydb
that referenced
this pull request
Dec 29, 2023
…latform#710) * Enhance monitoring for serverless tenants in Hive KIKIMR-19289
This was referenced Jan 15, 2024
Merged
This was referenced Jan 31, 2024
This was referenced Feb 1, 2024
This was referenced Feb 1, 2024
Merged
Merged
This was referenced Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
This was referenced Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.