Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor viewer backend #7071

Merged
merged 1 commit into from
Aug 2, 2024
Merged

refactor viewer backend #7071

merged 1 commit into from
Aug 2, 2024

Conversation

adameat
Copy link
Member

@adameat adameat commented Jul 25, 2024 •
edited
Loading

Changelog entry

refactor viewer backend
closes #6668

Changelog category

  • Improvement
  • Not for changelog (changelog entry is not required)

@adameat adameat force-pushed the refactor-viewer-back branch from 41c257d to b8ff2fd Compare July 25, 2024 06:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 06:44:26 UTC Pre-commit check for b7b2ebd has started.
⚪ 2024-07-25 06:47:18 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-07-25 06:52:16 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 06:44:34 UTC Pre-commit check for b7b2ebd has started.
⚪ 2024-07-25 06:47:23 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-25 07:03:04 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited
Loading

⚪ 2024-07-25 06:46:26 UTC Pre-commit check for b7b2ebd has started.
⚪ 2024-07-25 06:49:11 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-25 07:04:46 UTC Build failed. see the logs.

@adameat adameat force-pushed the refactor-viewer-back branch from b8ff2fd to 81145b2 Compare July 26, 2024 06:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 06:59:46 UTC Pre-commit check for 5df88e1 has started.
⚪ 2024-07-26 07:02:37 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-26 09:54:02 UTC Too many tests failed, NOT going to retry
🔴 2024-07-26 09:54:03 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10727 8721 0 1446 335 225

🟢 2024-07-26 09:55:18 UTC Build successful.
🔴 2024-07-26 09:56:35 UTC ydbd size 5.2 GiB changed* by +17.2 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 34b6297 merge: 5df88e1 diff diff %
ydbd size 5 564 663 224 Bytes 5 582 676 056 Bytes +17.2 MiB +0.324%
ydbd stripped size 1 198 266 832 Bytes 1 198 970 736 Bytes +687.4 KiB +0.059%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 07:02:56 UTC Pre-commit check for 5df88e1 has started.
⚪ 2024-07-26 07:11:01 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-26 07:18:13 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

⚪ 2024-07-26 07:13:28 UTC Pre-commit check for 5df88e1 has started.
⚪ 2024-07-26 07:16:32 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-26 09:05:04 UTC Too many tests failed, NOT going to retry
🔴 2024-07-26 09:05:05 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14110 11037 0 1509 1376 188

🟢 2024-07-26 09:06:29 UTC Build successful.
🔴 2024-07-26 09:10:15 UTC ydbd size 8.1 GiB changed* by +35.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 34b6297 merge: 5df88e1 diff diff %
ydbd size 8 667 429 864 Bytes 8 704 588 608 Bytes +35.4 MiB +0.429%
ydbd stripped size 471 525 696 Bytes 471 584 768 Bytes +57.7 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat force-pushed the refactor-viewer-back branch from 81145b2 to 8c7ed2f Compare July 29, 2024 10:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 10:41:36 UTC Pre-commit check for 107945a has started.
⚪ 2024-07-29 10:44:12 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-29 12:41:24 UTC Too many tests failed, NOT going to retry
🔴 2024-07-29 12:41:25 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14308 10940 0 1534 1605 229

🔴 2024-07-29 12:45:18 UTC ydbd size 8.1 GiB changed* by +35.4 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: bd147a9 merge: 107945a diff diff %
ydbd size 8 676 405 096 Bytes 8 713 481 648 Bytes +35.4 MiB +0.427%
ydbd stripped size 471 815 968 Bytes 471 875 104 Bytes +57.8 KiB +0.013%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 10:43:53 UTC Pre-commit check for 107945a has started.
⚪ 2024-07-29 10:46:42 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-29 10:54:39 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 10:44:03 UTC Pre-commit check for 107945a has started.
⚪ 2024-07-29 10:47:04 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-07-29 13:20:18 UTC Check cancelled

@adameat adameat force-pushed the refactor-viewer-back branch from 8c7ed2f to 7d3bce4 Compare July 29, 2024 13:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 13:24:13 UTC Pre-commit check for 0d96ab0 has started.
⚪ 2024-07-29 13:27:25 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-29 15:35:36 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10890 10307 0 86 324 173

🟢 2024-07-29 15:36:40 UTC Build successful.
🔴 2024-07-29 15:37:31 UTC ydbd size 5.2 GiB changed* by +16.8 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 3ab5a95 merge: 0d96ab0 diff diff %
ydbd size 5 569 924 192 Bytes 5 587 545 888 Bytes +16.8 MiB +0.316%
ydbd stripped size 1 199 042 192 Bytes 1 199 786 832 Bytes +727.2 KiB +0.062%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 13:29:18 UTC Pre-commit check for 0d96ab0 has started.
⚪ 2024-07-29 13:32:09 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-07-29 13:38:09 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚪ 2024-07-29 13:35:32 UTC Pre-commit check for 0d96ab0 has started.
⚪ 2024-07-29 13:38:30 UTC Check linux-x86_64-relwithdebinfo is running...
🟢 2024-07-29 15:09:37 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15193 13853 0 0 1325 15

🟢 2024-07-29 15:11:04 UTC Build successful.
🔴 2024-07-29 15:11:46 UTC ydbd size 8.1 GiB changed* by +34.8 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 3ab5a95 merge: 0d96ab0 diff diff %
ydbd size 8 676 398 408 Bytes 8 712 873 376 Bytes +34.8 MiB +0.420%
ydbd stripped size 471 817 376 Bytes 471 876 064 Bytes +57.3 KiB +0.012%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat force-pushed the refactor-viewer-back branch from 7d3bce4 to acab27d Compare July 30, 2024 05:44
@github-actions GitHub Actions
Copy link

⚪ 2024-07-30 05:45:29 UTC Pre-commit check for ef9f93f has started.

@github-actions GitHub Actions
Copy link

⚪ 2024-07-30 05:46:50 UTC Pre-commit check for ef9f93f has started.

@github-actions GitHub Actions
Copy link

⚪ 2024-07-30 05:48:05 UTC Pre-commit check for ef9f93f has started.

@adameat adameat added the rebase-and-check Rebase PR with the current base branch and check label Jul 30, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jul 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 09:25:55 UTC Pre-commit check for 8ffc0c6 has started.
⚪ 2024-07-30 09:28:42 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-07-30 09:28:55 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 09:26:54 UTC Pre-commit check for 8ffc0c6 has started.
⚪ 2024-07-30 09:29:46 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-30 09:29:58 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 09:26:56 UTC Pre-commit check for 8ffc0c6 has started.
⚪ 2024-07-30 09:29:46 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-30 09:29:58 UTC Build failed. see the logs.

@adameat adameat force-pushed the refactor-viewer-back branch from acab27d to 8ff5d61 Compare July 30, 2024 10:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 10:18:16 UTC Pre-commit check for 6862d7d has started.
⚪ 2024-07-30 10:21:13 UTC Check linux-x86_64-release-clang14 is running...
🔴 2024-07-30 10:25:47 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 10:18:34 UTC Pre-commit check for 6862d7d has started.
⚪ 2024-07-30 10:21:23 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-30 10:27:43 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

⚪ 2024-07-30 10:20:27 UTC Pre-commit check for 6862d7d has started.
⚪ 2024-07-30 10:23:04 UTC Check linux-x86_64-relwithdebinfo is running...
🔴 2024-07-30 10:30:28 UTC Build failed. see the logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

⚪ 2024-07-31 03:14:57 UTC Pre-commit check for 85562bf has started.
⚪ 2024-07-31 03:17:54 UTC Check linux-x86_64-release-asan is running...
🔴 2024-07-31 03:18:07 UTC Build failed. see the logs.

@adameat adameat force-pushed the refactor-viewer-back branch 2 times, most recently from f9ed764 to 8f5c070 Compare August 1, 2024 03:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

⚪ 2024-08-01 03:35:17 UTC Pre-commit check for 92c5ab6 has started.
⚪ 2024-08-01 03:38:16 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-01 03:45:21 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

⚪ 2024-08-01 03:35:20 UTC Pre-commit check for 92c5ab6 has started.
⚪ 2024-08-01 03:38:17 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-01 05:30:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39678 34356 0 4 5306 12

🔴 2024-08-01 05:34:06 UTC ydbd size 8.1 GiB changed* by +2.8 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: 6316570 merge: 92c5ab6 diff diff %
ydbd size 8 672 038 392 Bytes 8 674 971 424 Bytes +2.8 MiB +0.034%
ydbd stripped size 472 048 680 Bytes 472 039 400 Bytes -9.1 KiB -0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

⚪ 2024-08-01 03:35:29 UTC Pre-commit check for 92c5ab6 has started.
⚪ 2024-08-01 03:38:29 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-01 05:51:49 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10947 10885 0 18 28 16

🟡 2024-08-01 05:52:40 UTC ydbd size 5.4 GiB changed* by +1.6 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 6316570 merge: 92c5ab6 diff diff %
ydbd size 5 841 313 560 Bytes 5 843 003 944 Bytes +1.6 MiB +0.029%
ydbd stripped size 1 463 911 024 Bytes 1 463 989 264 Bytes +76.4 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@adameat adameat force-pushed the refactor-viewer-back branch 2 times, most recently from d2bbd06 to cb0dce9 Compare August 2, 2024 03:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

⚪ 2024-08-02 03:21:17 UTC Pre-commit check for 6b2afcc has started.
⚪ 2024-08-02 03:24:24 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-02 03:31:59 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

⚪ 2024-08-02 03:21:48 UTC Pre-commit check for 6b2afcc has started.
⚪ 2024-08-02 03:24:42 UTC Check linux-x86_64-release-asan is running...
⚫ 2024-08-02 04:23:18 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

⚪ 2024-08-02 03:22:07 UTC Pre-commit check for 6b2afcc has started.
⚪ 2024-08-02 03:25:17 UTC Check linux-x86_64-relwithdebinfo is running...
⚫ 2024-08-02 04:23:20 UTC Check cancelled

@adameat adameat force-pushed the refactor-viewer-back branch from cb0dce9 to 4cba98a Compare August 2, 2024 04:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

⚪ 2024-08-02 04:25:34 UTC Pre-commit check for 3d91589 has started.
⚪ 2024-08-02 04:28:53 UTC Check linux-x86_64-release-asan is running...
🔴 2024-08-02 06:34:33 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10939 10887 0 16 22 14

🟢 2024-08-02 06:35:46 UTC Build successful.
🟢 2024-08-02 06:36:14 UTC ydbd size 5.4 GiB changed* by -18.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4a90cf0 merge: 3d91589 diff diff %
ydbd size 5 842 864 776 Bytes 5 823 854 648 Bytes -18.1 MiB -0.325%
ydbd stripped size 1 464 165 712 Bytes 1 462 797 680 Bytes -1.3 MiB -0.093%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

⚪ 2024-08-02 04:26:37 UTC Pre-commit check for 3d91589 has started.
⚪ 2024-08-02 04:29:40 UTC Check linux-x86_64-relwithdebinfo is running...
🟡 2024-08-02 06:28:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39680 34355 0 3 5306 16

⚪ 2024-08-02 06:33:17 UTC Failed tests rerun (try 2) linux-x86_64-relwithdebinfo is running...
🟢 2024-08-02 06:41:23 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22 (only retried tests) 8 0 0 2 12

🟢 2024-08-02 06:44:42 UTC Build successful.
🟢 2024-08-02 06:45:17 UTC ydbd size 8.1 GiB changed* by -11.1 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4a90cf0 merge: 3d91589 diff diff %
ydbd size 8 674 777 432 Bytes 8 663 137 440 Bytes -11.1 MiB -0.134%
ydbd stripped size 472 125 032 Bytes 471 340 872 Bytes -765.8 KiB -0.166%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

⚪ 2024-08-02 04:26:40 UTC Pre-commit check for 3d91589 has started.
⚪ 2024-08-02 04:29:45 UTC Check linux-x86_64-release-clang14 is running...
🟢 2024-08-02 04:36:47 UTC Build successful.

@adameat adameat marked this pull request as ready for review August 2, 2024 07:22
@adameat adameat requested a review from a team as a code owner August 2, 2024 07:22
@adameat adameat enabled auto-merge (squash) August 2, 2024 07:22
@adameat adameat merged commit 32f9fe7 into ydb-platform:main Aug 2, 2024
11 of 13 checks passed
@adameat adameat deleted the refactor-viewer-back branch August 2, 2024 07:59
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 8, 2024
Merged
This was referenced Aug 8, 2024
Merged
Merged
adameat added a commit to adameat/ydb that referenced this pull request Oct 1, 2024
@adameat
refactor viewer backend (ydb-platform#7071)
e1ce7d0
adameat added a commit to adameat/ydb that referenced this pull request Oct 4, 2024
@adameat
refactor viewer backend (ydb-platform#7071)
abb0092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonkovalenko antonkovalenko antonkovalenko approved these changes

@alexvru alexvru alexvru approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor viewer backend
3 participants
@adameat @antonkovalenko @alexvru