Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-2: Fix bugs in: change exchange split, removing schema snapshots & emitting of resolved timestamps #6615

Merged
merged 6 commits into from
Jul 14, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Jul 12, 2024

Changelog entry

  • Fill change exchange split & activation lists just before commit.
  • Add records to change queue at Execute() stage.
  • Fix bug with broadcasting records.
  • Continue to emit resolved timestamp after table merge.

Changelog category

  • Bugfix

Additional information

...

@CyberROFL CyberROFL self-assigned this Jul 12, 2024
@CyberROFL CyberROFL added bugfix and removed bugfix labels Jul 12, 2024
Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 10:56:49 UTC Pre-commit check for 1831a91 has started.
2024-07-12 10:56:51 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-07-12 11:49:51 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 10:56:53 UTC Pre-commit check for 1831a91 has started.
2024-07-12 10:56:55 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-07-12 11:56:24 UTC Build failed. see the build logs.
🔴 2024-07-12 11:58:02 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 11:04:39 UTC Pre-commit check for 1831a91 has started.
2024-07-12 11:04:41 UTC Build linux-x86_64-release-asan is running...
🔴 2024-07-12 12:07:57 UTC Build failed. see the build logs.
🔴 2024-07-12 12:09:34 UTC Tests run skipped.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 13:59:55 UTC Pre-commit check for 1531272 has started.
2024-07-12 13:59:58 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-12 15:00:29 UTC Build successful.
2024-07-12 15:02:10 UTC Tests are running...
🔴 2024-07-12 16:56:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10288 10168 0 18 58 44

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 14:00:25 UTC Pre-commit check for 1531272 has started.
2024-07-12 14:00:27 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-12 14:57:05 UTC Build successful.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 14:00:58 UTC Pre-commit check for 1531272 has started.
2024-07-12 14:01:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-12 14:58:23 UTC Build successful.
2024-07-12 15:00:16 UTC Tests are running...
🔴 2024-07-12 16:50:53 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24515 22739 0 5 1741 30

@CyberROFL CyberROFL marked this pull request as ready for review July 12, 2024 16:11
@CyberROFL CyberROFL requested a review from a team as a code owner July 12, 2024 16:11
@CyberROFL CyberROFL enabled auto-merge (squash) July 12, 2024 16:11
Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 19:39:29 UTC Pre-commit check for c9200f8 has started.
2024-07-12 19:39:31 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-07-12 20:33:15 UTC Build successful.

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 19:45:18 UTC Pre-commit check for c9200f8 has started.
2024-07-12 19:45:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-07-12 20:38:05 UTC Build successful.
2024-07-12 20:39:51 UTC Tests are running...
🔴 2024-07-12 22:31:00 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
24522 22749 0 3 1743 27

Copy link

github-actions bot commented Jul 12, 2024

2024-07-12 19:47:15 UTC Pre-commit check for c9200f8 has started.
2024-07-12 19:47:17 UTC Build linux-x86_64-release-asan is running...
🟢 2024-07-12 20:41:36 UTC Build successful.
2024-07-12 20:43:19 UTC Tests are running...
🔴 2024-07-12 22:37:59 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10286 10187 0 17 54 28

@CyberROFL CyberROFL merged commit 090c0ad into ydb-platform:stable-24-2 Jul 14, 2024
3 of 5 checks passed
@CyberROFL CyberROFL deleted the cdc-fixes-24-2 branch July 24, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants