Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added runtime nodes for gracejoin with spilling #5972

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Added runtime nodes for gracejoin with spilling #5972

merged 7 commits into from
Jun 27, 2024

Conversation

lll-phill-lll
Copy link
Member

Changelog entry

Added runtime nodes with spilling for GraceJoin and GraceSelfJoin
...

Changelog category

  • New feature

Additional information

...

@lll-phill-lll lll-phill-lll requested a review from a team as a code owner June 26, 2024 12:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 12:31:48 UTC Pre-commit check for 3cf0fcb has started.
⚪ 2024-06-26 12:34:28 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-26 12:47:47 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 12:36:07 UTC Pre-commit check for 3cf0fcb has started.
⚪ 2024-06-26 12:38:55 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-26 12:55:22 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 12:39:36 UTC Pre-commit check for 3cf0fcb has started.
⚪ 2024-06-26 12:42:17 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-26 12:55:47 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 13:24:34 UTC Pre-commit check for e31d874 has started.
⚪ 2024-06-26 13:27:19 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-26 13:30:36 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 13:41:34 UTC Pre-commit check for e31d874 has started.
⚪ 2024-06-26 13:44:20 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-26 13:47:46 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 13:54:10 UTC Pre-commit check for e31d874 has started.
⚪ 2024-06-26 13:56:43 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-26 13:59:25 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 14:35:06 UTC Pre-commit check for 4ba8071 has started.
⚪ 2024-06-26 14:37:51 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-26 14:41:28 UTC Build successful.
⚪ 2024-06-26 14:41:41 UTC Tests are running...
🔴 2024-06-26 16:10:41 UTC Test run completed, no test results found for commit a5685dd. Please check test log.
⚫ 2024-06-26 16:10:48 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 14:35:15 UTC Pre-commit check for 4ba8071 has started.
⚪ 2024-06-26 14:37:53 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-26 14:41:42 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 14:42:47 UTC Pre-commit check for 4ba8071 has started.
⚪ 2024-06-26 14:45:29 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-26 14:48:26 UTC Build successful.
⚪ 2024-06-26 14:48:37 UTC Tests are running...
🔴 2024-06-26 16:10:41 UTC Test run completed, no test results found for commit a5685dd. Please check test log.
⚫ 2024-06-26 16:10:47 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 16:13:37 UTC Pre-commit check for 13cadd0 has started.
⚪ 2024-06-26 16:16:31 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-26 16:44:22 UTC Build successful.
⚪ 2024-06-26 16:44:39 UTC Tests are running...
🔴 2024-06-26 17:33:55 UTC Test run completed, no test results found for commit 026e99e. Please check test log.
🟢 2024-06-26 17:34:27 UTC ydbd size 5.5 GiB changed* by -18.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ac37933 merge: 13cadd0 diff diff %
ydbd size 5 914 005 184 Bytes 5 913 985 784 Bytes -18.9 KiB -0.000%
ydbd stripped size 1 270 500 712 Bytes 1 270 508 840 Bytes +7.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-06-26 17:34:28 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 16:14:00 UTC Pre-commit check for 13cadd0 has started.
⚪ 2024-06-26 16:16:43 UTC Build linux-x86_64-release-clang14 is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 16:18:01 UTC Pre-commit check for 13cadd0 has started.
⚪ 2024-06-26 16:20:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-26 17:01:44 UTC Build successful.
⚪ 2024-06-26 17:01:58 UTC Tests are running...
🔴 2024-06-26 17:34:04 UTC Test run completed, no test results found for commit 026e99e. Please check test log.
🟢 2024-06-26 17:38:24 UTC ydbd size 8.4 GiB changed* by -32.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ac37933 merge: 13cadd0 diff diff %
ydbd size 9 019 224 800 Bytes 9 019 191 232 Bytes -32.8 KiB -0.000%
ydbd stripped size 492 613 288 Bytes 492 615 016 Bytes +1.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2024-06-26 17:38:25 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 17:42:09 UTC Pre-commit check for 320a390 has started.
⚪ 2024-06-26 17:45:02 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-26 18:24:04 UTC Build successful.
⚪ 2024-06-26 18:24:23 UTC Tests are running...
🔴 2024-06-26 20:51:44 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75177 61807 0 1 13348 21

🟢 2024-06-26 20:52:35 UTC ydbd size 8.4 GiB changed* by -32.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 2fc2f71 merge: 320a390 diff diff %
ydbd size 9 019 325 608 Bytes 9 019 292 088 Bytes -32.7 KiB -0.000%
ydbd stripped size 492 617 000 Bytes 492 618 792 Bytes +1.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 17:42:10 UTC Pre-commit check for 320a390 has started.
⚪ 2024-06-26 17:44:53 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-26 18:20:15 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 17:42:22 UTC Pre-commit check for 320a390 has started.
⚪ 2024-06-26 17:45:12 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-26 18:11:20 UTC Build successful.
⚪ 2024-06-26 18:11:53 UTC Tests are running...
🔴 2024-06-26 20:17:57 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15044 14432 0 91 342 179

🟢 2024-06-26 20:18:49 UTC ydbd size 5.5 GiB changed* by -22.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: d5dd2aa merge: 320a390 diff diff %
ydbd size 5 914 057 384 Bytes 5 914 033 888 Bytes -22.9 KiB -0.000%
ydbd stripped size 1 270 513 128 Bytes 1 270 517 160 Bytes +3.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@lll-phill-lll lll-phill-lll requested a review from Darych June 26, 2024 19:42
@lll-phill-lll
Copy link
Member Author

Arcadia pr:
https://nda.ya.ru/t/xTobOXOc76dQCa

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 21:26:45 UTC Pre-commit check for 8dc5d50 has started.
⚪ 2024-06-26 21:29:34 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-26 22:12:08 UTC Build successful.
⚪ 2024-06-26 22:12:23 UTC Tests are running...
🔴 2024-06-27 00:33:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75182 61807 0 5 13348 22

🟢 2024-06-27 00:33:54 UTC ydbd size 8.4 GiB changed* by -28.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 84a22eb merge: 8dc5d50 diff diff %
ydbd size 9 021 351 320 Bytes 9 021 321 840 Bytes -28.8 KiB -0.000%
ydbd stripped size 492 774 760 Bytes 492 780 584 Bytes +5.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 21:26:48 UTC Pre-commit check for 8dc5d50 has started.
⚪ 2024-06-26 21:29:40 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-26 21:58:42 UTC Build successful.
⚪ 2024-06-26 21:58:56 UTC Tests are running...
🔴 2024-06-27 00:17:25 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15052 14420 0 105 349 178

🟢 2024-06-27 00:18:18 UTC ydbd size 5.5 GiB changed* by -19.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 84a22eb merge: 8dc5d50 diff diff %
ydbd size 5 916 212 976 Bytes 5 916 193 560 Bytes -19.0 KiB -0.000%
ydbd stripped size 1 271 047 144 Bytes 1 271 055 272 Bytes +7.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 21:26:49 UTC Pre-commit check for 8dc5d50 has started.
⚪ 2024-06-26 21:29:35 UTC Build linux-x86_64-release-clang14 is running...

@lll-phill-lll lll-phill-lll force-pushed the add-runtime-node-for-grace-join-spilling branch from f2cab9c to b3e56e8 Compare June 27, 2024 08:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

⚪ 2024-06-27 08:17:10 UTC Pre-commit check for fbd7398 has started.
⚪ 2024-06-27 08:19:41 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-27 08:45:52 UTC Build successful.
⚪ 2024-06-27 08:46:07 UTC Tests are running...
🔴 2024-06-27 10:56:56 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15061 14427 0 102 348 184

🟢 2024-06-27 10:57:41 UTC ydbd size 5.5 GiB changed* by -19.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 84a22eb merge: fbd7398 diff diff %
ydbd size 5 916 212 976 Bytes 5 916 193 560 Bytes -19.0 KiB -0.000%
ydbd stripped size 1 271 047 144 Bytes 1 271 055 272 Bytes +7.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

⚪ 2024-06-27 08:18:44 UTC Pre-commit check for fbd7398 has started.
⚪ 2024-06-27 08:21:28 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-27 09:04:08 UTC Build successful.
⚪ 2024-06-27 09:04:31 UTC Tests are running...
🔴 2024-06-27 11:38:44 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75183 61801 0 7 13348 27

🟢 2024-06-27 11:39:28 UTC ydbd size 8.4 GiB changed* by -28.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 84a22eb merge: fbd7398 diff diff %
ydbd size 9 021 351 320 Bytes 9 021 321 840 Bytes -28.8 KiB -0.000%
ydbd stripped size 492 774 760 Bytes 492 780 584 Bytes +5.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

⚪ 2024-06-27 08:18:58 UTC Pre-commit check for fbd7398 has started.
⚪ 2024-06-27 08:21:39 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-27 09:01:18 UTC Build successful.

@lll-phill-lll lll-phill-lll merged commit e868cd9 into ydb-platform:main Jun 27, 2024
8 of 12 checks passed
@niksaveliev niksaveliev mentioned this pull request Jul 1, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darych Darych Darych approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lll-phill-lll @Darych