Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move YT plugin to ydb/library/yql #573

Merged
merged 1 commit into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ydb/library/yql/ya.make
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ RECURSE(
tools
udfs
utils
yt
)
15 changes: 15 additions & 0 deletions ydb/library/yql/yt/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
### What is this?

This directory contains targets related to YTsaurus YQL plugin. [YTsaurus](https://github.com/ytsaurus/ytsaurus)
is an open-source big data storage system which employs YQL engine as one of its primary computation engines.
YT relies on a so-called YQL plugin shared library, which is built from target located in dynamic/ directory.

Changes of interfaces in this directory must be done very carefuly. In general, bridge/interface.h must be a
superset of
[ytsaurus:yt/yql/plugin/bridge/interface.h](https://github.com/ytsaurus/ytsaurus/blob/main/yt/yql/plugin/bridge/interface.h).
If a backwards incompatible change in interface is required, do not forget to promote the YQL plugin version
in this repository, and change the min/max supported YQL plugin
[versions](https://github.com/ytsaurus/ytsaurus/blob/main/yt/yql/plugin/bridge/plugin.cpp#L32-L41) in YTsaurus repository.

If you are not 100% sure about what you are doing, contact vvvv@ydb.tech and mpereskokova@ytsaurus.tech for help.

Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include <yt/yql/plugin/bridge/interface.h>
#include <yt/yql/plugin/native/plugin.h>
#include <ydb/library/yql/yt/bridge/interface.h>
#include <ydb/library/yql/yt/native/plugin.h>

#include <type_traits>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ SRCS(
)

PEERDIR(
yt/yql/plugin/native
ydb/library/yql/yt/native
)

END()
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#pragma once

#include <yt/yql/plugin/plugin.h>
#include <ydb/library/yql/yt/plugin.h>

namespace NYT::NYqlPlugin {

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#include "progress_merger.h"


namespace NYT::NYqlPlugin {

//////////////////////////////////////////////////////////////////////////////
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ PEERDIR(
ydb/library/yql/providers/yt/lib/yt_download
ydb/library/yql/providers/yt/provider

yt/yql/plugin
ydb/library/yql/yt
)

YQL_LAST_ABI_VERSION()
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion yt/yql/plugin/plugin.h → ydb/library/yql/yt/plugin.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#pragma once

#include <yt/yql/plugin/bridge/interface.h>
#include <ydb/library/yql/yt/bridge/interface.h>

#include <library/cpp/logger/log.h>

Expand Down
13 changes: 13 additions & 0 deletions ydb/library/yql/yt/ya.make
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
LIBRARY()

SRCS(
plugin.cpp
)

END()

RECURSE(
dynamic
native
)

19 changes: 0 additions & 19 deletions yt/yql/plugin/CMakeLists.darwin-arm64.txt

This file was deleted.

19 changes: 0 additions & 19 deletions yt/yql/plugin/CMakeLists.darwin-x86_64.txt

This file was deleted.

20 changes: 0 additions & 20 deletions yt/yql/plugin/CMakeLists.linux-aarch64.txt

This file was deleted.

20 changes: 0 additions & 20 deletions yt/yql/plugin/CMakeLists.linux-x86_64.txt

This file was deleted.

19 changes: 0 additions & 19 deletions yt/yql/plugin/CMakeLists.windows-x86_64.txt

This file was deleted.

Loading