Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build binaries in build stage #5411

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Build binaries in build stage #5411

merged 2 commits into from
Jun 26, 2024

Conversation

maximyurchuk
Copy link
Collaborator

@maximyurchuk maximyurchuk commented Jun 10, 2024 •
edited
Loading

Changelog entry

Do link in build stage (finally)

New rule for cache uploading is used: instead of non-linkage in build stage we limit artifacts' size for cache upload

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

New mechanic works, see #5412
Also another check: #5978

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

⚪ 2024-06-10 15:26:19 UTC Pre-commit check for e638ae8 has started.
⚪ 2024-06-10 15:28:12 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-10 15:29:21 UTC Build failed. see the build logs.
🔴 2024-06-10 15:29:23 UTC Tests run skipped.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

⚪ 2024-06-10 15:45:26 UTC Pre-commit check for e638ae8 has started.
⚪ 2024-06-10 15:47:20 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-06-10 15:50:20 UTC Build failed. see the build logs.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 10, 2024 •
edited
Loading

⚪ 2024-06-10 15:46:05 UTC Pre-commit check for e638ae8 has started.
⚪ 2024-06-10 15:48:00 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-10 15:51:00 UTC Build failed. see the build logs.
🔴 2024-06-10 15:51:01 UTC Tests run skipped.

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Jun 18, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 18, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

⚪ 2024-06-18 14:49:31 UTC Pre-commit check for e4edee5 has started.
⚪ 2024-06-18 14:51:35 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-18 15:38:43 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

⚪ 2024-06-18 14:52:05 UTC Pre-commit check for e4edee5 has started.
⚪ 2024-06-18 14:54:45 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-18 15:23:17 UTC Build successful.
⚪ 2024-06-18 15:23:29 UTC Tests are running...
🔴 2024-06-18 15:23:36 UTC Test run completed, no test results found for commit 6c39f68. Please check test log.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 18, 2024 •
edited
Loading

⚪ 2024-06-18 14:54:39 UTC Pre-commit check for e4edee5 has started.
⚪ 2024-06-18 14:56:33 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-18 15:41:57 UTC Build successful.
⚪ 2024-06-18 15:42:11 UTC Tests are running...
🔴 2024-06-18 15:42:19 UTC Test run completed, no test results found for commit 6c39f68. Please check test log.

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Jun 19, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

⚪ 2024-06-19 14:37:21 UTC Pre-commit check for 35776e1 has started.
⚪ 2024-06-19 14:39:14 UTC Build linux-x86_64-release-clang14 is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

⚪ 2024-06-19 14:37:25 UTC Pre-commit check for 35776e1 has started.
⚪ 2024-06-19 14:39:27 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-19 15:20:40 UTC Build successful.
⚪ 2024-06-19 15:20:54 UTC Tests are running...
🔴 2024-06-19 15:21:01 UTC Test run completed, no test results found for commit 6c39f68. Please check test log.
🟢 2024-06-19 15:21:32 UTC merge: 35776e1 ydbd size 8.6 GiB -112 Bytes -0.000% vs build main: 2dd3d22

Build size details

main: 2dd3d22 ydbd build size:

  • binary size 9 212 645 184 Bytes
  • stripped binary size 711 238 064 Bytes

merge: 35776e1 ydbd build size:

  • binary size 9 212 645 072 Bytes
  • stripped binary size 711 238 128 Bytes

ydbd size dashboard

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

⚪ 2024-06-19 15:13:44 UTC Pre-commit check for 35776e1 has started.
⚪ 2024-06-19 15:15:46 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-19 15:44:45 UTC Build successful.
⚪ 2024-06-19 15:45:05 UTC Tests are running...
🔴 2024-06-19 15:45:12 UTC Test run completed, no test results found for commit 6c39f68. Please check test log.
🟢 2024-06-19 15:45:46 UTC merge: 35776e1 ydbd size 5.7 GiB +240 Bytes +0.000% vs build main: 2dd3d22

Build size details

main: 2dd3d22 ydbd build size:

  • binary size 6 148 763 296 Bytes
  • stripped binary size 1 527 412 928 Bytes

merge: 35776e1 ydbd build size:

  • binary size 6 148 763 536 Bytes
  • stripped binary size 1 527 413 056 Bytes

ydbd size dashboard

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 13:10:22 UTC Pre-commit check for f00207d has started.
⚪ 2024-06-26 13:12:26 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-06-26 13:49:44 UTC Build failed. see the build logs.
🔴 2024-06-26 13:50:25 UTC ydbd size 8.4 GiB changed* by +2.3 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: fb5d17f merge: f00207d diff diff %
ydbd size 9 010 342 136 Bytes 9 012 799 248 Bytes +2.3 MiB +0.027%
ydbd stripped size 491 917 160 Bytes 491 997 672 Bytes +78.6 KiB +0.016%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 13:10:34 UTC Pre-commit check for f00207d has started.
⚪ 2024-06-26 13:12:29 UTC Build linux-x86_64-release-clang14 is running...

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 13:17:18 UTC Pre-commit check for f00207d has started.
⚪ 2024-06-26 13:19:29 UTC Build linux-x86_64-release-asan is running...
🔴 2024-06-26 13:45:25 UTC Build failed. see the build logs.
🟡 2024-06-26 13:45:55 UTC ydbd size 5.5 GiB changed* by +1.4 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: fb5d17f merge: f00207d diff diff %
ydbd size 5 905 090 728 Bytes 5 906 588 720 Bytes +1.4 MiB +0.025%
ydbd stripped size 1 268 138 376 Bytes 1 268 388 232 Bytes +244.0 KiB +0.020%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@maximyurchuk maximyurchuk added the rebase-and-check Rebase PR with the current base branch and check label Jun 26, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Jun 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 14:56:13 UTC Pre-commit check for 29e460a has started.
⚪ 2024-06-26 14:58:06 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-06-26 14:58:09 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 14:59:15 UTC Pre-commit check for 29e460a has started.
⚪ 2024-06-26 15:01:24 UTC Build linux-x86_64-release-asan is running...
🟢 2024-06-26 15:01:28 UTC Build successful.
⚪ 2024-06-26 15:01:39 UTC Tests are running...
🔴 2024-06-26 15:01:46 UTC Test run completed, no test results found for commit 68cce88. Please check test log.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

⚪ 2024-06-26 14:59:19 UTC Pre-commit check for 29e460a has started.
⚪ 2024-06-26 15:01:20 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-06-26 15:01:23 UTC Build successful.
⚪ 2024-06-26 15:01:36 UTC Tests are running...
🔴 2024-06-26 15:01:43 UTC Test run completed, no test results found for commit 68cce88. Please check test log.

@maximyurchuk maximyurchuk merged commit 953068c into ydb-platform:main Jun 26, 2024
13 of 18 checks passed
@niksaveliev niksaveliev mentioned this pull request Jul 1, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexv-smirnov alexv-smirnov alexv-smirnov approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximyurchuk @alexv-smirnov