Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic tests have been fixed #4093

Merged
merged 1 commit into from
Apr 25, 2024
Merged

generic tests have been fixed #4093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ydb/tests/fq/generic/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@
def settings() -> Settings:
return Settings.from_env()


@pytest.fixture
def mvp_external_ydb_endpoint(request) -> str:
return request.param["endpoint"] if request is not None else None
return request.param["endpoint"] if request is not None and hasattr(request, "param") else None


@pytest.fixture
Expand Down
1 change: 1 addition & 0 deletions ydb/tests/fq/generic/test_ydb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
class TestYdb:
@yq_v2
@pytest.mark.parametrize("fq_client", [{"folder_id": "my_folder"}], indirect=True)
@pytest.mark.parametrize("mvp_external_ydb_endpoint", [{"endpoint": "tests-fq-generic-ydb:2136"}], indirect=True)
def test_simple(self, fq_client: FederatedQueryClient, settings: Settings):
table_name = 'simple_table'
conn_name = f'conn_{table_name}'
Expand Down
Loading