Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(refactoring) Pass replication object to Progress() instead of a bunch of arguments #2766

Merged
merged 1 commit into from
Mar 14, 2024
Merged

(refactoring) Pass replication object to Progress() instead of a bunch of arguments #2766

merged 1 commit into from
Mar 14, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Mar 14, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@CyberROFL CyberROFL self-assigned this Mar 14, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

⚪ 2024-03-14 13:38:40 UTC Pre-commit check for 3a09c33 has started.
⚪ 2024-03-14 13:38:43 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-14 13:40:52 UTC Build successful.
⚪ 2024-03-14 13:41:07 UTC Tests are running...
🔴 2024-03-14 15:38:56 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15055 14469 0 72 485 29

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

⚪ 2024-03-14 14:24:30 UTC Pre-commit check for 3a09c33 has started.
⚪ 2024-03-14 14:24:31 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-14 14:26:21 UTC Build successful.
⚪ 2024-03-14 14:26:35 UTC Tests are running...
🔴 2024-03-14 15:44:16 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68362 57404 0 1 10930 27

@CyberROFL CyberROFL marked this pull request as ready for review March 14, 2024 14:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

⚪ 2024-03-14 14:44:02 UTC Pre-commit check for 3a09c33 has started.
⚪ 2024-03-14 14:44:04 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-14 14:46:01 UTC Build successful.

@CyberROFL CyberROFL merged commit 3d1ee2a into ydb-platform:main Mar 14, 2024
5 of 7 checks passed
@CyberROFL CyberROFL deleted the refactoring branch March 14, 2024 16:10
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 19, 2024
Merged
This was referenced Mar 20, 2024
Merged
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
This was referenced Mar 29, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
This was referenced Apr 6, 2024
Merged
Merged
@shnikd shnikd mentioned this pull request Apr 11, 2024
Merged
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jun 10, 2024
@CyberROFL
(refactoring) Pass replication object to Progress() instead of a bunc…
4b4acb6 
…h of arguments (ydb-platform#2766)
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Jun 10, 2024
@CyberROFL
(refactoring) Pass replication object to Progress() instead of a bunc…
175a050 
…h of arguments (ydb-platform#2766)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enjection Enjection Enjection approved these changes

Assignees

@CyberROFL CyberROFL

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CyberROFL @Enjection