Set & check replication config #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
65f6ecf to
c69458e
Compare
|
⚫ |
|
⚪
|
|
⚪
|
Enjection
approved these changes
Mar 12, 2024
Comment on lines
+25
to
+39
| enum EMode { | ||
| MODE_NONE = 0, | ||
| MODE_READ_ONLY = 1, | ||
| }; | ||
|
|
||
| enum EConsistency { | ||
| CONSISTENCY_STRONG = 1, | ||
| CONSISTENCY_WEAK = 2, | ||
| }; | ||
|
|
||
| EMode Mode; | ||
| EConsistency Consistency; | ||
|
|
||
| void SerializeTo(NKikimrSchemeOp::TTableReplicationConfig& proto) const; | ||
| static TReplicationConfig Default(); |
There was a problem hiding this comment.
Maybe it is better to use strongly typed enums?
This was referenced Mar 20, 2024
Merged
Merged
This was referenced Mar 29, 2024
Merged
This was referenced Apr 6, 2024
CyberROFL
added a commit
to CyberROFL/ydb
that referenced
this pull request
Jun 10, 2024
CyberROFL
added a commit
to CyberROFL/ydb
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
...
Changelog category
Additional information
...