Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQ-2840 Move pq_async_actor tests to github #2414

Merged
merged 2 commits into from
Mar 4, 2024
Merged

YQ-2840 Move pq_async_actor tests to github #2414

merged 2 commits into from
Mar 4, 2024

Conversation

kardymonds
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 10:37:53 UTC Pre-commit check for 39316dc has started.
⚪ 2024-03-04 10:37:56 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-04 11:03:12 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 10:39:39 UTC Pre-commit check for 39316dc has started.
⚪ 2024-03-04 10:39:41 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-04 10:51:27 UTC Build successful.
⚪ 2024-03-04 10:51:38 UTC Tests are running...
🔴 2024-03-04 12:09:37 UTC Test run completed, no test results found for commit 52f6129. Please check build logs.
⚫ 2024-03-04 12:09:41 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 10:53:07 UTC Pre-commit check for 39316dc has started.
⚪ 2024-03-04 10:53:09 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-04 10:54:42 UTC Build successful.
⚪ 2024-03-04 10:54:52 UTC Tests are running...
🔴 2024-03-04 12:09:37 UTC Test run completed, no test results found for commit 52f6129. Please check build logs.
⚫ 2024-03-04 12:09:40 UTC Check cancelled

uzhastik
uzhastik reviewed Mar 4, 2024
View reviewed changes
ydb/tests/fq/pq_async_io/ya.make Outdated
@@ -0,0 +1,32 @@
UNITTEST_FOR(ydb/library/yql/providers/pq/async_io)

OWNER(
Copy link
Collaborator

@uzhastik uzhastik Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

эту секцию надо удалять. она не актуальна для гитхаба

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

ydb/tests/fq/pq_async_io/dq_pq_read_actor_ut.cpp Outdated
void AssertDataWithWatermarks(
const std::vector<std::variant<T, TInstant>>& actual,
const std::vector<T>& expected,
const std::vector<ui32> watermarkBeforePositions)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

сделать амперсанд забыли

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 12:39:50 UTC Pre-commit check for 84cc6b1 has started.
⚪ 2024-03-04 12:39:52 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-03-04 12:41:18 UTC Build successful.
⚪ 2024-03-04 12:41:27 UTC Tests are running...
🔴 2024-03-04 13:46:52 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67962 57020 0 14 10904 24

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 12:39:52 UTC Pre-commit check for 84cc6b1 has started.
⚪ 2024-03-04 12:39:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-03-04 12:41:28 UTC Build successful.
⚪ 2024-03-04 12:41:36 UTC Tests are running...
🔴 2024-03-04 13:50:32 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14868 14715 0 36 97 20

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

⚪ 2024-03-04 12:50:42 UTC Pre-commit check for 84cc6b1 has started.
⚪ 2024-03-04 12:50:43 UTC Build linux-x86_64-release-cmake14 is running...
🟢 2024-03-04 12:52:06 UTC Build successful.

@kardymonds kardymonds enabled auto-merge (squash) March 4, 2024 13:48
@kardymonds kardymonds merged commit 6632509 into ydb-platform:main Mar 4, 2024
3 of 5 checks passed
@niksaveliev niksaveliev mentioned this pull request Mar 5, 2024
Merged
This was referenced Mar 6, 2024
Merged
Open
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 7, 2024
Merged
@StekPerepolnen StekPerepolnen mentioned this pull request Mar 8, 2024
Merged
This was referenced Mar 11, 2024
Merged
Merged
This was referenced Mar 13, 2024
Merged
Merged
This was referenced Mar 20, 2024
Merged
Closed
Merged
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Mar 26, 2024
Merged
@shnikd shnikd mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uzhastik uzhastik uzhastik approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kardymonds @uzhastik