Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YQL-17542 move sync CA related methods to TDqSyncComputeActorBase #2103

Merged
merged 2 commits into from
Feb 21, 2024
Merged

YQL-17542 move sync CA related methods to TDqSyncComputeActorBase #2103

merged 2 commits into from
Feb 21, 2024

Conversation

zverevgeny
Copy link
Collaborator

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

pr over contrib: https://a.yandex-team.ru/review/5382833/details

@zverevgeny zverevgeny requested a review from a team as a code owner February 20, 2024 12:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

⚪ 2024-02-20 12:31:22 UTC Pre-commit check for a38873b has started.
⚪ 2024-02-20 12:31:24 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-02-20 12:34:51 UTC Build failed. see the build logs.
⚪ 2024-02-20 12:35:03 UTC Tests are running...
🔴 2024-02-20 13:02:22 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
58864 47744 0 260 10848 12

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

⚪ 2024-02-20 12:33:33 UTC Pre-commit check for a38873b has started.
⚪ 2024-02-20 12:33:35 UTC Build linux-x86_64-release-asan is running...
🔴 2024-02-20 12:36:27 UTC Build failed. see the build logs.
⚪ 2024-02-20 12:36:39 UTC Tests are running...
🔴 2024-02-20 12:43:42 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6084 5813 0 255 4 12

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

⚪ 2024-02-20 13:14:49 UTC Pre-commit check for 71dfacd has started.
⚪ 2024-02-20 13:14:52 UTC Build linux-x86_64-release-asan is running...
🟢 2024-02-20 13:53:52 UTC Build successful.
⚪ 2024-02-20 13:54:05 UTC Tests are running...
🔴 2024-02-20 15:38:13 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14691 14472 0 31 147 41

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

⚪ 2024-02-20 13:15:50 UTC Pre-commit check for 71dfacd has started.
⚪ 2024-02-20 13:15:52 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-02-20 13:49:48 UTC Build successful.
⚪ 2024-02-20 13:49:58 UTC Tests are running...
🔴 2024-02-20 15:39:46 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67706 56709 0 16 10945 36

Darych
Darych reviewed Feb 21, 2024
View reviewed changes
ydb/library/yql/dq/actors/compute/dq_compute_actor_impl.h
CA_LOG_I("task: " << Task.GetId() << ", output channelId: " << channelId << " finished prematurely, "
<< "drop " << dropRows << " rows");
}
//void TakeInputChannelData(TChannelDataOOB&& channelData, bool ack) is pure and must be overridded in derived class
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where we declare TakeInputChannelData as pure virtual function. Should we do this here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's first declared in TDqComputeActorChannels::ICallbacks

@zverevgeny zverevgeny merged commit 750630f into ydb-platform:main Feb 21, 2024
2 of 4 checks passed
@StekPerepolnen StekPerepolnen mentioned this pull request Feb 22, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 26, 2024
Merged
This was referenced Mar 1, 2024
Merged
Merged
Open
Merged
This was referenced Mar 7, 2024
Merged
Merged
This was referenced Mar 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darych Darych Darych approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zverevgeny @Darych