-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract ydb init to separate classes #2064
Extract ydb init to separate classes #2064
Conversation
⚪
|
⚪ |
⚪
|
⚪
|
⚪
|
⚪
|
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪
|
⚪
|
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪ |
⚪
|
⚪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Каждый конфиг/опцию не валидировал, случайно просмотрел несколько — выглядит адекватно.
|
||
class IEnv { | ||
public: | ||
virtual ~IEnv() {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Если написать = default;
, то оно ещё и смотреться будет единообразно с = 0;
:)
std::unique_ptr<IDynConfigClient> MakeDefaultDynConfigClient(); | ||
|
||
std::unique_ptr<IInitialConfigurator> MakeDefaultInitialConfigurator( | ||
NConfig::IErrorCollector& errorCollector, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
При добавлении нового провайдера неприкольно будет добавлять новый аргумент функции. Может сразу структуру передавать?
⚪
|
⚪
|
⚪
|
⚪
|
3f8344e
to
06b8b32
Compare
⚪
|
⚪
|
Changelog entry
...
Changelog category
Additional information
...