Make coordination session ping period dependent on session timeout KIKIMR-20993 #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪
|
|
⚪
|
CyberROFL
approved these changes
Feb 5, 2024
Merged
This was referenced Feb 5, 2024
This was referenced Feb 6, 2024
Merged
This was referenced Feb 7, 2024
Merged
Merged
Merged
Merged
Closed
snaury
added a commit
to snaury/ydb
that referenced
this pull request
Feb 12, 2024
Merged
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Coordination session ping period is now dependent on session timeout.
Changelog category
Additional information
Previously server pinged client session every 5 seconds, which translated to worst case dead client detection of 10 seconds. Some clients needed a faster leader change however, so ping period now depends on the session timeout.