Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDbResolver: store & resend original event #14883

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Feb 21, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@CyberROFL CyberROFL linked an issue Feb 21, 2025 that may be closed by this pull request
@CyberROFL CyberROFL marked this pull request as ready for review February 21, 2025 08:48
@CyberROFL CyberROFL requested a review from a team as a code owner February 21, 2025 08:48
Copy link

github-actions bot commented Feb 21, 2025

🟢 2025-02-21 08:49:24 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 08:49:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 538b6fb has started.
2025-02-21 08:49:29 UTC Artifacts will be uploaded here
2025-02-21 08:52:58 UTC ya make is running...
🟡 2025-02-21 09:40:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19394 18033 0 3 1220 138

2025-02-21 09:42:23 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-21 10:08:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
217 (only retried tests) 86 0 1 2 128

2025-02-21 10:08:46 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-21 10:29:08 UTC ydbd size 2.1 GiB changed* by -3.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 795aa32 merge: 538b6fb diff diff %
ydbd size 2 240 132 032 Bytes 2 240 128 848 Bytes -3.1 KiB -0.000%
ydbd stripped size 474 642 456 Bytes 474 641 432 Bytes -1.0 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-02-21 10:29:10 UTC Check cancelled

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 08:50:27 UTC Pre-commit check linux-x86_64-release-asan for 538b6fb has started.
2025-02-21 08:51:37 UTC Artifacts will be uploaded here
2025-02-21 08:55:07 UTC ya make is running...
🟡 2025-02-21 09:55:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12080 11965 0 59 18 38

2025-02-21 09:56:37 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-02-21 10:14:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 119 0 1 9 33

2025-02-21 10:14:47 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-02-21 10:28:48 UTC ydbd size 3.6 GiB changed* by -5.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 795aa32 merge: 538b6fb diff diff %
ydbd size 3 896 991 888 Bytes 3 896 986 536 Bytes -5.2 KiB -0.000%
ydbd stripped size 1 364 374 176 Bytes 1 364 372 000 Bytes -2.1 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2025-02-21 10:28:50 UTC Check cancelled

@CyberROFL CyberROFL requested a review from snaury February 21, 2025 08:50
ijon
ijon previously approved these changes Feb 21, 2025
Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 12:27:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for f42dff9 has started.
2025-02-21 12:29:28 UTC Artifacts will be uploaded here
2025-02-21 12:32:18 UTC ya make is running...
🟡 2025-02-21 13:25:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19409 18043 0 2 1220 144

2025-02-21 13:27:09 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 13:45:26 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 83 0 0 2 127

🟢 2025-02-21 13:45:34 UTC Build successful.
🟢 2025-02-21 13:45:55 UTC ydbd size 2.1 GiB changed* by +86.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2d9caae merge: f42dff9 diff diff %
ydbd size 2 240 270 264 Bytes 2 240 358 680 Bytes +86.3 KiB +0.004%
ydbd stripped size 474 660 312 Bytes 474 670 488 Bytes +9.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 21, 2025

2025-02-21 12:29:06 UTC Pre-commit check linux-x86_64-release-asan for f42dff9 has started.
2025-02-21 12:29:20 UTC Artifacts will be uploaded here
2025-02-21 12:32:17 UTC ya make is running...
🟡 2025-02-21 13:37:42 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12094 11969 0 74 14 37

2025-02-21 13:39:28 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-21 13:57:45 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
170 (only retried tests) 136 0 0 3 31

🟢 2025-02-21 13:57:52 UTC Build successful.
🟡 2025-02-21 13:58:18 UTC ydbd size 3.6 GiB changed* by +422.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 64fee69 merge: f42dff9 diff diff %
ydbd size 3 897 000 568 Bytes 3 897 433 096 Bytes +422.4 KiB +0.011%
ydbd stripped size 1 364 376 480 Bytes 1 364 480 064 Bytes +101.2 KiB +0.008%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL merged commit f330cca into ydb-platform:main Feb 21, 2025
12 checks passed
@CyberROFL CyberROFL deleted the fix-db-resolver branch February 21, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SchemeCache: TDbResolver loses the request cookie
3 participants