Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for vector index backup #14096

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

MBkkt
Copy link
Collaborator

@MBkkt MBkkt commented Jan 31, 2025

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

  • I recommend review this PR without space diff
  • Merge after this PR Fix bugs in global kmeans #13809
  • Add vector index in cli backup tests
  • Add vector index in s3 backup tests (change copy table to allow vector index in it)

This comment was marked as outdated.

This comment was marked as outdated.

@MBkkt MBkkt changed the title Add build index Add tests for vector index backup Jan 31, 2025
@MBkkt MBkkt force-pushed the mbkkt/vector-index-backup branch from cb88e31 to 0c5157a Compare February 1, 2025 17:58
@MBkkt MBkkt marked this pull request as ready for review February 1, 2025 17:58
@MBkkt MBkkt requested review from a team as code owners February 1, 2025 17:58

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@MBkkt MBkkt self-assigned this Feb 3, 2025
@MBkkt MBkkt force-pushed the mbkkt/vector-index-backup branch from 91433d9 to 6d77523 Compare February 3, 2025 09:39

This comment was marked as outdated.

This comment was marked as outdated.

@pixcc pixcc self-requested a review February 3, 2025 10:12
Gazizonoki
Gazizonoki previously approved these changes Feb 3, 2025
pixcc
pixcc previously approved these changes Feb 3, 2025
Copy link
Member

@pixcc pixcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backups: lgtm

CyberROFL
CyberROFL previously approved these changes Feb 3, 2025
@MBkkt MBkkt dismissed stale reviews from CyberROFL, pixcc, and Gazizonoki via 2872d9c February 4, 2025 11:19
@MBkkt MBkkt force-pushed the mbkkt/vector-index-backup branch from 6d77523 to 2872d9c Compare February 4, 2025 11:19
Copy link

github-actions bot commented Feb 4, 2025

2025-02-04 11:19:43 UTC Pre-commit check linux-x86_64-release-asan for 21a2bf0 has started.
2025-02-04 11:20:12 UTC Artifacts will be uploaded here
2025-02-04 11:23:45 UTC ya make is running...
🟡 2025-02-04 12:30:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13358 13300 0 19 10 29

2025-02-04 12:31:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-04 12:43:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
90 (only retried tests) 60 0 0 5 25

🟢 2025-02-04 12:43:48 UTC Build successful.
🟢 2025-02-04 12:44:16 UTC ydbd size 3.6 GiB changed* by -4.6 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4595b4e merge: 21a2bf0 diff diff %
ydbd size 3 867 475 720 Bytes 3 867 470 984 Bytes -4.6 KiB -0.000%
ydbd stripped size 1 355 264 272 Bytes 1 355 262 032 Bytes -2.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Feb 4, 2025

2025-02-04 11:22:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for 21a2bf0 has started.
2025-02-04 11:23:00 UTC Artifacts will be uploaded here
2025-02-04 11:26:04 UTC ya make is running...
🟢 2025-02-04 12:27:09 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27538 24987 0 0 2424 127

🟢 2025-02-04 12:29:41 UTC Build successful.
🟢 2025-02-04 12:29:58 UTC ydbd size 2.1 GiB changed* by -2.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 4595b4e merge: 21a2bf0 diff diff %
ydbd size 2 224 084 056 Bytes 2 224 081 472 Bytes -2.5 KiB -0.000%
ydbd stripped size 472 677 816 Bytes 472 676 984 Bytes -832 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@MBkkt MBkkt enabled auto-merge (squash) February 4, 2025 12:46
@MBkkt MBkkt disabled auto-merge February 4, 2025 12:49
@MBkkt MBkkt enabled auto-merge (squash) February 4, 2025 12:52
@MBkkt MBkkt merged commit 60a898f into ydb-platform:main Feb 4, 2025
12 checks passed
lberserq pushed a commit to lberserq/ydb that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants