Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YQL-17388: fix generate_series zero step #1358

Merged
merged 4 commits into from
Jan 29, 2024
Merged

YQL-17388: fix generate_series zero step #1358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43f4529
Exit early on zero step allocating nothing
marsaly79 Jan 26, 2024
2ce4c06
Creating separated memory context for keep error data
marsaly79 Jan 26, 2024
cb03395
Updated passing tests
marsaly79 Jan 26, 2024
952f98e
Revert "Exit early on zero step allocating nothing"
marsaly79 Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ydb/library/yql/parser/pg_wrapper/comp_factory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ static __thread bool NeedCanonizeFp = false;

struct TMainContext {
MemoryContextData Data;
MemoryContextData ErrorData;
MemoryContext PrevCurrentMemoryContext = nullptr;
MemoryContext PrevErrorContext = nullptr;
MemoryContext PrevCacheMemoryContext = nullptr;
Expand Down Expand Up @@ -3864,6 +3865,11 @@ void* PgInitializeMainContext() {
&MkqlMethods,
nullptr,
"mkql");
MemoryContextCreate((MemoryContext)&ctx->ErrorData,
T_AllocSetContext,
&MkqlMethods,
nullptr,
"mkql-err");
ctx->StartTimestamp = GetCurrentTimestamp();
return ctx;
}
Expand All @@ -3881,7 +3887,8 @@ void PgAcquireThreadContext(void* ctx) {
main->PrevCacheMemoryContext = CacheMemoryContext;
SaveRecordCacheState(&main->PrevRecordCacheState);
LoadRecordCacheState(&main->CurrentRecordCacheState);
CurrentMemoryContext = ErrorContext = CacheMemoryContext = (MemoryContext)&main->Data;
CurrentMemoryContext = CacheMemoryContext = (MemoryContext)&main->Data;
ErrorContext = (MemoryContext)&main->ErrorData;
SetParallelStartTimestamps(main->StartTimestamp, main->StartTimestamp);
main->PrevStackBase = set_stack_base();
yql_error_report_active = true;
Expand Down
183 changes: 180 additions & 3 deletions ydb/library/yql/tests/postgresql/cases/int8.err
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,183 @@ SELECT * FROM generate_series('+4567890123456789'::int8, '+4567890123456799'::in
<sql-statement>
SELECT * FROM generate_series('+4567890123456789'::int8, '+4567890123456799'::int8, 2);
</sql-statement>
pgrun: /-S/ydbwork/ydb/ydb/contrib/libs/llvm12/lib/IR/LegacyPassManager.cpp:588: void llvm::PMTopLevelManager::setLastUser(ArrayRef<Pass *>, Pass *): Assertion `AnalysisPass && "Expected analysis pass to exist."' failed.
pthread_kill at ./nptl/./nptl/pthread_kill.c:43:17
?? at ??:0:0
<sql-statement>
-- corner case
SELECT (-1::int8<<63)::text;
</sql-statement>
<sql-statement>
SELECT ((-1::int8<<63)+1)::text;
</sql-statement>
<sql-statement>
-- check sane handling of INT64_MIN overflow cases
SELECT (-9223372036854775808)::int8 * (-1)::int8;
</sql-statement>
-stdin-:<main>: Fatal: Execution

-stdin-:<main>:1:1: Fatal: Execution of node: Result
-- check sane handling of INT64_MIN overflow cases
^
-stdin-:<main>:1:1: Fatal: ERROR: bigint out of range

-- check sane handling of INT64_MIN overflow cases
^
<sql-statement>
SELECT (-9223372036854775808)::int8 / (-1)::int8;
</sql-statement>
-stdin-:<main>: Fatal: Execution

-stdin-:<main>:1:1: Fatal: Execution of node: Result
SELECT (-9223372036854775808)::int8 / (-1)::int8;
^
-stdin-:<main>:1:1: Fatal: ERROR: bigint out of range

SELECT (-9223372036854775808)::int8 / (-1)::int8;
^
<sql-statement>
SELECT (-9223372036854775808)::int8 % (-1)::int8;
</sql-statement>
<sql-statement>
SELECT (-9223372036854775808)::int8 * (-1)::int4;
</sql-statement>
-stdin-:<main>: Fatal: Execution

-stdin-:<main>:1:1: Fatal: Execution of node: Result
SELECT (-9223372036854775808)::int8 * (-1)::int4;
^
-stdin-:<main>:1:1: Fatal: ERROR: bigint out of range

SELECT (-9223372036854775808)::int8 * (-1)::int4;
^
<sql-statement>
SELECT (-9223372036854775808)::int8 / (-1)::int4;
</sql-statement>
-stdin-:<main>: Fatal: Execution

-stdin-:<main>:1:1: Fatal: Execution of node: Result
SELECT (-9223372036854775808)::int8 / (-1)::int4;
^
-stdin-:<main>:1:1: Fatal: ERROR: bigint out of range

SELECT (-9223372036854775808)::int8 / (-1)::int4;
^
<sql-statement>
SELECT (-9223372036854775808)::int8 % (-1)::int4;
</sql-statement>
<sql-statement>
SELECT (-9223372036854775808)::int8 * (-1)::int2;
</sql-statement>
-stdin-:<main>: Fatal: Execution

-stdin-:<main>:1:1: Fatal: Execution of node: Result
SELECT (-9223372036854775808)::int8 * (-1)::int2;
^
-stdin-:<main>:1:1: Fatal: ERROR: bigint out of range

SELECT (-9223372036854775808)::int8 * (-1)::int2;
^
<sql-statement>
SELECT (-9223372036854775808)::int8 / (-1)::int2;
</sql-statement>
-stdin-:<main>: Fatal: Execution

-stdin-:<main>:1:1: Fatal: Execution of node: Result
SELECT (-9223372036854775808)::int8 / (-1)::int2;
^
-stdin-:<main>:1:1: Fatal: ERROR: bigint out of range

SELECT (-9223372036854775808)::int8 / (-1)::int2;
^
<sql-statement>
SELECT (-9223372036854775808)::int8 % (-1)::int2;
</sql-statement>
<sql-statement>
-- check rounding when casting from float
SELECT x, x::int8 AS int8_value
FROM (VALUES (-2.5::float8),
(-1.5::float8),
(-0.5::float8),
(0.0::float8),
(0.5::float8),
(1.5::float8),
(2.5::float8)) t(x);
</sql-statement>
<sql-statement>
-- check rounding when casting from numeric
SELECT x, x::int8 AS int8_value
FROM (VALUES (-2.5::numeric),
(-1.5::numeric),
(-0.5::numeric),
(0.0::numeric),
(0.5::numeric),
(1.5::numeric),
(2.5::numeric)) t(x);
</sql-statement>
<sql-statement>
-- test gcd()
SELECT a, b, gcd(a, b), gcd(a, -b), gcd(b, a), gcd(-b, a)
FROM (VALUES (0::int8, 0::int8),
(0::int8, 29893644334::int8),
(288484263558::int8, 29893644334::int8),
(-288484263558::int8, 29893644334::int8),
((-9223372036854775808)::int8, 1::int8),
((-9223372036854775808)::int8, 9223372036854775807::int8),
((-9223372036854775808)::int8, 4611686018427387904::int8)) AS v(a, b);
</sql-statement>
<sql-statement>
SELECT gcd((-9223372036854775808)::int8, 0::int8); -- overflow
</sql-statement>
-stdin-:<main>: Fatal: Execution

-stdin-:<main>:1:1: Fatal: Execution of node: Result
SELECT gcd((-9223372036854775808)::int8, 0::int8); -- overflow
^
-stdin-:<main>:1:1: Fatal: ERROR: bigint out of range

SELECT gcd((-9223372036854775808)::int8, 0::int8); -- overflow
^
<sql-statement>
SELECT gcd((-9223372036854775808)::int8, (-9223372036854775808)::int8); -- overflow
</sql-statement>
-stdin-:<main>: Fatal: Execution

-stdin-:<main>:1:1: Fatal: Execution of node: Result
SELECT gcd((-9223372036854775808)::int8, (-9223372036854775808)::int8); -- overflow
^
-stdin-:<main>:1:1: Fatal: ERROR: bigint out of range

SELECT gcd((-9223372036854775808)::int8, (-9223372036854775808)::int8); -- overflow
^
<sql-statement>
-- test lcm()
SELECT a, b, lcm(a, b), lcm(a, -b), lcm(b, a), lcm(-b, a)
FROM (VALUES (0::int8, 0::int8),
(0::int8, 29893644334::int8),
(29893644334::int8, 29893644334::int8),
(288484263558::int8, 29893644334::int8),
(-288484263558::int8, 29893644334::int8),
((-9223372036854775808)::int8, 0::int8)) AS v(a, b);
</sql-statement>
<sql-statement>
SELECT lcm((-9223372036854775808)::int8, 1::int8); -- overflow
</sql-statement>
-stdin-:<main>: Fatal: Execution

-stdin-:<main>:1:1: Fatal: Execution of node: Result
SELECT lcm((-9223372036854775808)::int8, 1::int8); -- overflow
^
-stdin-:<main>:1:1: Fatal: ERROR: bigint out of range

SELECT lcm((-9223372036854775808)::int8, 1::int8); -- overflow
^
<sql-statement>
SELECT lcm(9223372036854775807::int8, 9223372036854775806::int8); -- overflow
</sql-statement>
-stdin-:<main>: Fatal: Execution

-stdin-:<main>:1:1: Fatal: Execution of node: Result
SELECT lcm(9223372036854775807::int8, 9223372036854775806::int8); -- overflow
^
-stdin-:<main>:1:1: Fatal: ERROR: bigint out of range

SELECT lcm(9223372036854775807::int8, 9223372036854775806::int8); -- overflow
^
143 changes: 143 additions & 0 deletions ydb/library/yql/tests/postgresql/cases/int8.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,3 +737,146 @@ SELECT * FROM generate_series('+4567890123456789'::int8, '+4567890123456799'::in
4567890123456799
(11 rows)

SELECT * FROM generate_series('+4567890123456789'::int8, '+4567890123456799'::int8, 0);
ERROR: step size cannot equal zero
SELECT * FROM generate_series('+4567890123456789'::int8, '+4567890123456799'::int8, 2);
generate_series
------------------
4567890123456789
4567890123456791
4567890123456793
4567890123456795
4567890123456797
4567890123456799
(6 rows)

-- corner case
SELECT (-1::int8<<63)::text;
text
----------------------
-9223372036854775808
(1 row)

SELECT ((-1::int8<<63)+1)::text;
text
----------------------
-9223372036854775807
(1 row)

-- check sane handling of INT64_MIN overflow cases
SELECT (-9223372036854775808)::int8 * (-1)::int8;
ERROR: bigint out of range
SELECT (-9223372036854775808)::int8 / (-1)::int8;
ERROR: bigint out of range
SELECT (-9223372036854775808)::int8 % (-1)::int8;
?column?
----------
0
(1 row)

SELECT (-9223372036854775808)::int8 * (-1)::int4;
ERROR: bigint out of range
SELECT (-9223372036854775808)::int8 / (-1)::int4;
ERROR: bigint out of range
SELECT (-9223372036854775808)::int8 % (-1)::int4;
?column?
----------
0
(1 row)

SELECT (-9223372036854775808)::int8 * (-1)::int2;
ERROR: bigint out of range
SELECT (-9223372036854775808)::int8 / (-1)::int2;
ERROR: bigint out of range
SELECT (-9223372036854775808)::int8 % (-1)::int2;
?column?
----------
0
(1 row)

-- check rounding when casting from float
SELECT x, x::int8 AS int8_value
FROM (VALUES (-2.5::float8),
(-1.5::float8),
(-0.5::float8),
(0.0::float8),
(0.5::float8),
(1.5::float8),
(2.5::float8)) t(x);
x | int8_value
------+------------
-2.5 | -2
-1.5 | -2
-0.5 | 0
0 | 0
0.5 | 0
1.5 | 2
2.5 | 2
(7 rows)

-- check rounding when casting from numeric
SELECT x, x::int8 AS int8_value
FROM (VALUES (-2.5::numeric),
(-1.5::numeric),
(-0.5::numeric),
(0.0::numeric),
(0.5::numeric),
(1.5::numeric),
(2.5::numeric)) t(x);
x | int8_value
------+------------
-2.5 | -3
-1.5 | -2
-0.5 | -1
0.0 | 0
0.5 | 1
1.5 | 2
2.5 | 3
(7 rows)

-- test gcd()
SELECT a, b, gcd(a, b), gcd(a, -b), gcd(b, a), gcd(-b, a)
FROM (VALUES (0::int8, 0::int8),
(0::int8, 29893644334::int8),
(288484263558::int8, 29893644334::int8),
(-288484263558::int8, 29893644334::int8),
((-9223372036854775808)::int8, 1::int8),
((-9223372036854775808)::int8, 9223372036854775807::int8),
((-9223372036854775808)::int8, 4611686018427387904::int8)) AS v(a, b);
a | b | gcd | gcd | gcd | gcd
----------------------+---------------------+---------------------+---------------------+---------------------+---------------------
0 | 0 | 0 | 0 | 0 | 0
0 | 29893644334 | 29893644334 | 29893644334 | 29893644334 | 29893644334
288484263558 | 29893644334 | 6835958 | 6835958 | 6835958 | 6835958
-288484263558 | 29893644334 | 6835958 | 6835958 | 6835958 | 6835958
-9223372036854775808 | 1 | 1 | 1 | 1 | 1
-9223372036854775808 | 9223372036854775807 | 1 | 1 | 1 | 1
-9223372036854775808 | 4611686018427387904 | 4611686018427387904 | 4611686018427387904 | 4611686018427387904 | 4611686018427387904
(7 rows)

SELECT gcd((-9223372036854775808)::int8, 0::int8); -- overflow
ERROR: bigint out of range
SELECT gcd((-9223372036854775808)::int8, (-9223372036854775808)::int8); -- overflow
ERROR: bigint out of range
-- test lcm()
SELECT a, b, lcm(a, b), lcm(a, -b), lcm(b, a), lcm(-b, a)
FROM (VALUES (0::int8, 0::int8),
(0::int8, 29893644334::int8),
(29893644334::int8, 29893644334::int8),
(288484263558::int8, 29893644334::int8),
(-288484263558::int8, 29893644334::int8),
((-9223372036854775808)::int8, 0::int8)) AS v(a, b);
a | b | lcm | lcm | lcm | lcm
----------------------+-------------+------------------+------------------+------------------+------------------
0 | 0 | 0 | 0 | 0 | 0
0 | 29893644334 | 0 | 0 | 0 | 0
29893644334 | 29893644334 | 29893644334 | 29893644334 | 29893644334 | 29893644334
288484263558 | 29893644334 | 1261541684539134 | 1261541684539134 | 1261541684539134 | 1261541684539134
-288484263558 | 29893644334 | 1261541684539134 | 1261541684539134 | 1261541684539134 | 1261541684539134
-9223372036854775808 | 0 | 0 | 0 | 0 | 0
(6 rows)

SELECT lcm((-9223372036854775808)::int8, 1::int8); -- overflow
ERROR: bigint out of range
SELECT lcm(9223372036854775807::int8, 9223372036854775806::int8); -- overflow
ERROR: bigint out of range
Loading
Loading