-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add notification about close reader #13368
Changes from 10 commits
d00f9ac
b1079a9
d6523d3
f764c8d
f76bc1b
5737d2b
c68e2f2
7563940
6946874
05c5fea
78b135b
34ce706
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1382,6 +1382,8 @@ If a commit fails with an error, the application should log it and continue; it | |
} | ||
``` | ||
|
||
The `Commit` call is fast by default, saving data into an internal buffer and returning control back to the caller. The real message to the server is sent in the background. To prevent losing the last commits, you should call the `Reader.Close()` method before exiting the program. | ||
rekby marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- Python | ||
|
||
```python | ||
|
@@ -1391,6 +1393,8 @@ If a commit fails with an error, the application should log it and continue; it | |
reader.commit(message) | ||
``` | ||
|
||
The `commit` call is fast, saving data into an internal buffer and returning control back to the caller. The real message to the server is sent in the background. To prevent losing the last commits, you should call the `Reader.Close()` method before exiting the program. | ||
|
||
- Java | ||
|
||
To commit a message just call `commit` method on it. | ||
|
@@ -1451,6 +1455,8 @@ If a commit fails with an error, the application should log it and continue; it | |
} | ||
``` | ||
|
||
The `Commit` call is fast by default, saving data into an internal buffer and returning control back to the caller. The real message to the server is sent in the background. To prevent losing the last commits, you should call the `Reader.Close()` method before exiting the program. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We'd better make it an There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It has two paragraph and two copy of each in one file. I need two additional files and four include options for deduplicate of them. The paragraph doesn't need in other files and replace the text to include option make read the text difficult when read it. I think about small copy-paste better, then a lot of small files and combine them by includes. |
||
|
||
- Python | ||
|
||
```python | ||
|
@@ -1460,6 +1466,8 @@ If a commit fails with an error, the application should log it and continue; it | |
reader.commit(batch) | ||
``` | ||
|
||
The `commit` call is fast, saving data into an internal buffer and returning control back to the caller. The real message to the server is sent in the background. To prevent losing the last commits, you should call the `Reader.Close()` method before exiting the program. | ||
|
||
- Java (sync) | ||
|
||
Not relevant due to sync reader only reading messages one by one. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also explain what people are supposed to do to guarantee that messages are not lost even if the client is abruptly terminated due to OOM, segfault, etc., and can't catch it to close the connection explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is reader description and messes stored on a server already. If a process will be killed before commit a message - the message will resend to other reader by server. The client does not have to do anything for this.