Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate kqp from main #13293

Merged
merged 10 commits into from
Jan 13, 2025
Merged

Integrate kqp from main #13293

merged 10 commits into from
Jan 13, 2025

Conversation

zverevgeny
Copy link
Collaborator

No description provided.

@nikvas0 @zverevgeny
EvWrite: Immediate & Prepare (ydb-platform#10913)
d4cc0ba 
Conflicts:
	ydb/core/kqp/executer_actor/kqp_data_executer.cpp
	ydb/core/kqp/executer_actor/kqp_executer_impl.cpp
	ydb/core/kqp/runtime/kqp_write_actor.cpp
	ydb/core/kqp/session_actor/kqp_session_actor.cpp
@nikvas0 @zverevgeny
Metrics for buffer actor (ydb-platform#11304)
7487a93
@nikvas0 @zverevgeny
Evwrite optimizations (ydb-platform#11428)
b630667 
Conflicts:
	ydb/core/kqp/executer_actor/kqp_data_executer.cpp
@nikvas0 @zverevgeny
Don't recreate snapshots in transaction (ydb-platform#11553)
de51b16 
Conflicts:
	ydb/core/kqp/executer_actor/kqp_data_executer.cpp
@nikvas0 @zverevgeny
Test for olap ACL (ydb-platform#12202)
608d667
@nikvas0 @zverevgeny
Allow data query for olap (ydb-platform#12404)
76af88a 
Conflicts:
	ydb/core/kqp/executer_actor/kqp_data_executer.cpp
	ydb/core/kqp/provider/yql_kikimr_settings.h
	ydb/core/protos/table_service_config.proto
@nikvas0 @zverevgeny
Fix olap reads in data query (ydb-platform#12463)
8677a09
@nikvas0 @zverevgeny
Collect Sink Stats (ydb-platform#12507)
46bf12b 
Conflicts:
	.github/config/muted_ya.txt
	ydb/core/kqp/runtime/kqp_write_actor.cpp
	ydb/core/kqp/ut/cost/kqp_cost_ut.cpp
@nikvas0 @zverevgeny
Test for Read Only Snapshots (ydb-platform#11574)
fa2e3d6
@zverevgeny zverevgeny requested a review from a team as a code owner January 11, 2025 18:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 11, 2025 •
edited
Loading

⚪ 2025-01-11 18:23:46 UTC Pre-commit check for c991ba0 has started.
⚪ 2025-01-11 18:26:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-11 19:39:25 UTC Build successful.
⚪ 2025-01-11 19:39:46 UTC Tests are running...
🔴 2025-01-11 21:35:53 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40513 35223 0 7 5217 66

🔴 2025-01-11 21:36:54 UTC ydbd size 8.3 GiB changed* by +3.8 MiB, which is >= 2.0 MiB vs stable-24-3-14-cs: Alert

ydbd size dash stable-24-3-14-cs: 4dd2915 merge: c991ba0 diff diff %
ydbd size 8 956 288 696 Bytes 8 960 252 992 Bytes +3.8 MiB +0.044%
ydbd stripped size 486 954 152 Bytes 487 160 808 Bytes +201.8 KiB +0.042%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 11, 2025 •
edited
Loading

⚪ 2025-01-11 18:25:31 UTC Pre-commit check for c991ba0 has started.
⚪ 2025-01-11 18:28:36 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-11 19:16:05 UTC Build successful.
⚪ 2025-01-11 19:16:25 UTC Tests are running...
🔴 2025-01-11 21:31:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11925 11814 0 21 29 61

🔴 2025-01-11 21:32:22 UTC ydbd size 5.6 GiB changed* by +3.0 MiB, which is >= 2.0 MiB vs stable-24-3-14-cs: Alert

ydbd size dash stable-24-3-14-cs: 4dd2915 merge: c991ba0 diff diff %
ydbd size 6 056 656 176 Bytes 6 059 834 376 Bytes +3.0 MiB +0.052%
ydbd stripped size 1 512 760 448 Bytes 1 513 442 144 Bytes +665.7 KiB +0.045%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny linked an issue Jan 12, 2025 that may be closed by this pull request
Integrate changes from main #13202
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2025 •
edited
Loading

⚪ 2025-01-12 07:55:43 UTC Pre-commit check for 93ae01f has started.
⚪ 2025-01-12 07:58:52 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-12 08:23:46 UTC Build successful.
⚪ 2025-01-12 08:24:03 UTC Tests are running...
🔴 2025-01-12 10:41:19 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11926 11821 0 20 24 61

🔴 2025-01-12 10:42:01 UTC ydbd size 5.6 GiB changed* by +3.1 MiB, which is >= 2.0 MiB vs stable-24-3-14-cs: Alert

ydbd size dash stable-24-3-14-cs: 4dd2915 merge: 93ae01f diff diff %
ydbd size 6 056 656 176 Bytes 6 059 883 992 Bytes +3.1 MiB +0.053%
ydbd stripped size 1 512 760 448 Bytes 1 513 452 128 Bytes +675.5 KiB +0.046%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2025 •
edited
Loading

⚪ 2025-01-12 07:56:16 UTC Pre-commit check for 93ae01f has started.
⚪ 2025-01-12 07:59:55 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-12 08:43:05 UTC Build successful.
⚪ 2025-01-12 08:43:23 UTC Tests are running...
🔴 2025-01-12 10:47:57 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40517 35231 0 5 5218 63

🔴 2025-01-12 10:48:54 UTC ydbd size 8.3 GiB changed* by +3.9 MiB, which is >= 2.0 MiB vs stable-24-3-14-cs: Alert

ydbd size dash stable-24-3-14-cs: 4dd2915 merge: 93ae01f diff diff %
ydbd size 8 956 288 696 Bytes 8 960 341 808 Bytes +3.9 MiB +0.045%
ydbd stripped size 486 954 152 Bytes 487 163 816 Bytes +204.8 KiB +0.043%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny
Copy link
Collaborator Author

@nikvas0 @gridnevvvit тут меняются протобафы не совместимым образом.
1 Это точно ничего не поломает?
2 Если я вмёрджу это в стейбл и выкачу на прод, это будет означать фиксацию текущих протобуфов, и их нельзя уже дальше будет менять. Вы ок?

@maximyurchuk fyi

@nikvas0
Copy link
Collaborator

nikvas0 commented Jan 13, 2025

@nikvas0 @gridnevvvit тут меняются протобафы не совместимым образом.

ok

@zverevgeny zverevgeny merged commit eef7814 into ydb-platform:stable-24-3-14-cs Jan 13, 2025
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate changes from main
4 participants
@zverevgeny @nikvas0 @maximyurchuk @ulya-sidorina