Recover lost locks as broken #13181

zverevgeny · 2025-01-05T20:50:56Z

Changelog category

Bugfix

github-actions · 2025-01-05T20:54:37Z

⚪ 2025-01-05 20:54:37 UTC Pre-commit check linux-x86_64-release-asan for 4a2338a has started.
⚪ 2025-01-05 20:55:16 UTC Artifacts will be uploaded here
⚪ 2025-01-05 20:58:08 UTC ya make is running...
🟡 2025-01-05 21:56:44 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11487	11419	0	38	3	27

⚪ 2025-01-05 21:58:22 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-05 22:10:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
112 (only retried tests)	82	0	5	0	25

⚪ 2025-01-05 22:10:34 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-05 22:21:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
57 (only retried tests)	27	0	4	1	25

🟢 2025-01-05 22:21:55 UTC Build successful.
🟢 2025-01-05 22:22:24 UTC ydbd size 3.6 GiB changed* by -4.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `baa0367`	merge: `4a2338a`	diff	diff %
ydbd size	3 872 742 784 Bytes	3 872 738 616 Bytes	-4.1 KiB	-0.000%
ydbd stripped size	1 350 442 672 Bytes	1 350 441 264 Bytes	-1.4 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-05T20:54:59Z

⚪ 2025-01-05 20:54:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4a2338a has started.
⚪ 2025-01-05 20:55:10 UTC Artifacts will be uploaded here
⚪ 2025-01-05 20:58:05 UTC ya make is running...
🟡 2025-01-05 22:08:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18401	16911	0	33	1397	60

⚪ 2025-01-05 22:11:06 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-05 22:22:40 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
386 (only retried tests)	259	0	0	7	120

🟢 2025-01-05 22:22:49 UTC Build successful.
🟠 2025-01-05 22:22:59 UTC Unmuted 1 tests
🟢 2025-01-05 22:23:18 UTC ydbd size 2.1 GiB changed* by -2.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `baa0367`	merge: `4a2338a`	diff	diff %
ydbd size	2 243 630 416 Bytes	2 243 627 696 Bytes	-2.7 KiB	-0.000%
ydbd stripped size	472 255 824 Bytes	472 255 248 Bytes	-576 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ivanmorozov333 · 2025-01-06T06:47:49Z

ydb/core/tx/columnshard/operations/manager.cpp

-            AFL_VERIFY(LockFeatures.contains(lockId))("lock_id", lockId);
+            auto it = LockFeatures.find(lockId);
+            if (it == LockFeatures.end()) { //No write operation found, recover the lock as a broken
+                it = LockFeatures.emplace(lockId, TLockFeatures(lockId, 0, true)).first;


лучше, явно, SetBroken указать... создавать объекты заведомо некорректные... не уверен, что нормально

если хочешь - можешь TLockFeature::BuildBroken(lockId, gen) сделать, но хочется, чтобы, явно, было написано что это broken - bool флажок не очень очевиден

поправил

ivanmorozov333

comments

github-actions · 2025-01-06T07:31:18Z

⚪ 2025-01-06 07:31:18 UTC Pre-commit check linux-x86_64-relwithdebinfo for c9c4dcb has started.
⚪ 2025-01-06 07:31:30 UTC Artifacts will be uploaded here
⚪ 2025-01-06 07:34:20 UTC ya make is running...
🟡 2025-01-06 08:18:32 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
18401	17107	0	2	1169	123

⚪ 2025-01-06 08:20:02 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-06 08:31:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
184 (only retried tests)	64	0	0	0	120

🟢 2025-01-06 08:31:55 UTC Build successful.
🟠 2025-01-06 08:32:05 UTC Unmuted 1 tests
🟢 2025-01-06 08:32:23 UTC ydbd size 2.1 GiB changed* by -2.8 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `baa0367`	merge: `c9c4dcb`	diff	diff %
ydbd size	2 243 630 416 Bytes	2 243 627 536 Bytes	-2.8 KiB	-0.000%
ydbd stripped size	472 255 824 Bytes	472 255 312 Bytes	-512 Bytes	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2025-01-06T07:33:33Z

⚪ 2025-01-06 07:33:33 UTC Pre-commit check linux-x86_64-release-asan for c9c4dcb has started.
⚪ 2025-01-06 07:33:45 UTC Artifacts will be uploaded here
⚪ 2025-01-06 07:36:44 UTC ya make is running...
🟡 2025-01-06 08:33:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
11487	11427	0	25	3	32

⚪ 2025-01-06 08:34:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-06 08:46:33 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
101 (only retried tests)	66	0	5	4	26

⚪ 2025-01-06 08:46:41 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-06 08:58:16 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
61 (only retried tests)	30	0	4	1	26

🟢 2025-01-06 08:58:23 UTC Build successful.
🟢 2025-01-06 08:58:51 UTC ydbd size 3.6 GiB changed* by -3.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash	main: `baa0367`	merge: `c9c4dcb`	diff	diff %
ydbd size	3 872 742 784 Bytes	3 872 739 232 Bytes	-3.5 KiB	-0.000%
ydbd stripped size	1 350 442 672 Bytes	1 350 441 456 Bytes	-1.2 KiB	-0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Conflicts: .github/config/muted_ya.txt

Recover lost locks as broken

7c88ee6

zverevgeny requested a review from a team as a code owner January 5, 2025 20:50

github-actions bot added the bugfix label Jan 5, 2025

ivanmorozov333 approved these changes Jan 6, 2025

View reviewed changes

ivanmorozov333 requested changes Jan 6, 2025

View reviewed changes

Use set broken

2e86349

ivanmorozov333 approved these changes Jan 6, 2025

View reviewed changes

zverevgeny linked an issue Jan 6, 2025 that may be closed by this pull request

VERIFY in TOperationsManager::Load #12871

Closed

zverevgeny merged commit dcb70d0 into ydb-platform:main Jan 6, 2025
12 checks passed

zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 21, 2025

Recover lost locks as broken (ydb-platform#13181)

625b7ec

Conflicts: .github/config/muted_ya.txt

zverevgeny mentioned this pull request Jan 21, 2025

Integrate changes from main #13202

Closed

azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025

Recover lost locks as broken (ydb-platform#13181)

fd3abe1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Recover lost locks as broken #13181

Recover lost locks as broken #13181

zverevgeny commented Jan 5, 2025

github-actions bot commented Jan 5, 2025 •

edited

Loading

github-actions bot commented Jan 5, 2025 •

edited

Loading

ivanmorozov333 Jan 6, 2025

ivanmorozov333 Jan 6, 2025

zverevgeny Jan 6, 2025

ivanmorozov333 left a comment

github-actions bot commented Jan 6, 2025 •

edited

Loading

github-actions bot commented Jan 6, 2025 •

edited

Loading

Recover lost locks as broken #13181

Recover lost locks as broken #13181

Conversation

zverevgeny commented Jan 5, 2025

Changelog category

github-actions bot commented Jan 5, 2025 • edited Loading

github-actions bot commented Jan 5, 2025 • edited Loading

ivanmorozov333 Jan 6, 2025

Choose a reason for hiding this comment

ivanmorozov333 Jan 6, 2025

Choose a reason for hiding this comment

zverevgeny Jan 6, 2025

Choose a reason for hiding this comment

ivanmorozov333 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2025 • edited Loading

github-actions bot commented Jan 6, 2025 • edited Loading

github-actions bot commented Jan 5, 2025 •

edited

Loading

github-actions bot commented Jan 5, 2025 •

edited

Loading

github-actions bot commented Jan 6, 2025 •

edited

Loading

github-actions bot commented Jan 6, 2025 •

edited

Loading