Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid to remove user with access #13144

Merged
merged 9 commits into from
Jan 20, 2025
Merged

Forbid to remove user with access #13144

merged 9 commits into from
Jan 20, 2025

Conversation

kunga
Copy link
Member

@kunga kunga commented Dec 31, 2024 •
edited
Loading

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

Reverts some changes from #12334

[STOPWATCH] Created 10000 paths with 2000000 acls in 4.717m
[STOPWATCH] Created single user userx in 0.032s
[STOPWATCH] Added single root acl userx in 1.783m
[STOPWATCH] Removed single root acl userx in 1.783m
[STOPWATCH] Removed single user userx in 2.804s
[STOPWATCH] Removed user200 in 2.822s
[STOPWATCH] Removed user201 in 2.812s
[STOPWATCH] Removed user202 in 2.831s
[STOPWATCH] Don't removed user0 in 0.016s
[STOPWATCH] Don't removed user1 in 0.014s
[STOPWATCH] Don't removed user2 in 0.014s

--------------------------------------------------------------------
Benchmark                          Time             CPU   Iterations
--------------------------------------------------------------------
TFixture/Deserialize/20         1.28 us         1.28 us       547689
TFixture/Deserialize/200        10.7 us         10.7 us        65695
TFixture/Deserialize/2000        105 us          105 us         6725
TFixture/HasAccess/20          0.026 us        0.026 us     26650258
TFixture/HasAccess/200         0.392 us        0.392 us      1634520
TFixture/HasAccess/2000         3.95 us         3.95 us       180391

@kunga kunga changed the title Revert Remove user removes their ACL #12334, but check no ACL for being removed user Forbid to remove user with access Dec 31, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited
Loading

⚪ 2024-12-31 11:59:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4d016bd has started.
⚪ 2024-12-31 12:00:05 UTC Artifacts will be uploaded here
⚪ 2024-12-31 12:03:19 UTC ya make is running...
⚫ 2024-12-31 12:25:36 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited
Loading

⚪ 2024-12-31 12:00:24 UTC Pre-commit check linux-x86_64-release-asan for 4d016bd has started.
⚪ 2024-12-31 12:00:36 UTC Artifacts will be uploaded here
⚪ 2024-12-31 12:03:43 UTC ya make is running...
⚫ 2024-12-31 12:25:37 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited
Loading

⚪ 2024-12-31 12:27:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for a2ff22d has started.
⚪ 2024-12-31 12:27:15 UTC Artifacts will be uploaded here
⚫ 2024-12-31 12:28:10 UTC Check cancelled

@kunga kunga force-pushed the revert-remove-user-rights branch from a08f2ff to 14454da Compare December 31, 2024 12:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited
Loading

⚪ 2024-12-31 12:29:51 UTC Pre-commit check linux-x86_64-release-asan for 8fdf845 has started.
⚪ 2024-12-31 12:30:03 UTC Artifacts will be uploaded here
⚪ 2024-12-31 12:33:17 UTC ya make is running...
🟡 2024-12-31 13:39:10 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13388 13324 0 33 2 29

⚪ 2024-12-31 13:40:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-31 13:52:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 77 0 9 1 26

⚪ 2024-12-31 13:52:19 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-31 14:03:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 33 0 5 0 27

🟢 2024-12-31 14:04:03 UTC Build successful.
🟢 2024-12-31 14:04:30 UTC ydbd size 3.6 GiB changed* by -12.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bafd581 merge: 8fdf845 diff diff %
ydbd size 3 872 296 176 Bytes 3 872 283 808 Bytes -12.1 KiB -0.000%
ydbd stripped size 1 350 327 728 Bytes 1 350 324 272 Bytes -3.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited
Loading

⚪ 2024-12-31 12:30:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8fdf845 has started.
⚪ 2024-12-31 12:31:40 UTC Artifacts will be uploaded here
⚪ 2024-12-31 12:35:06 UTC ya make is running...
🟡 2024-12-31 13:30:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22546 21948 0 9 461 128

⚪ 2024-12-31 13:32:30 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-31 13:44:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
204 (only retried tests) 81 0 2 0 121

⚪ 2024-12-31 13:44:17 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-31 13:55:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
180 (only retried tests) 62 0 0 0 118

🟢 2024-12-31 13:55:39 UTC Build successful.
🟢 2024-12-31 13:56:01 UTC ydbd size 2.1 GiB changed* by -16.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: bafd581 merge: 8fdf845 diff diff %
ydbd size 2 243 341 712 Bytes 2 243 325 360 Bytes -16.0 KiB -0.001%
ydbd stripped size 472 221 328 Bytes 472 217 936 Bytes -3.3 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga marked this pull request as ready for review December 31, 2024 15:31
@kunga kunga requested review from adameat, ijon and azevaykin December 31, 2024 15:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited
Loading

⚪ 2024-12-31 15:34:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3fda5a6 has started.
⚪ 2024-12-31 15:34:45 UTC Artifacts will be uploaded here
⚪ 2024-12-31 15:37:59 UTC ya make is running...
🟡 2024-12-31 16:28:46 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22546 21910 0 5 505 126

⚪ 2024-12-31 16:30:42 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-31 16:43:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
234 (only retried tests) 111 0 0 0 123

🟢 2024-12-31 16:43:20 UTC Build successful.
🟢 2024-12-31 16:43:39 UTC ydbd size 2.1 GiB changed* by -16.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: acaff68 merge: 3fda5a6 diff diff %
ydbd size 2 243 352 680 Bytes 2 243 336 320 Bytes -16.0 KiB -0.001%
ydbd stripped size 472 222 736 Bytes 472 219 344 Bytes -3.3 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 31, 2024 •
edited
Loading

⚪ 2024-12-31 15:34:39 UTC Pre-commit check linux-x86_64-release-asan for 3fda5a6 has started.
⚪ 2024-12-31 15:34:52 UTC Artifacts will be uploaded here
⚪ 2024-12-31 15:38:07 UTC ya make is running...
🟡 2024-12-31 16:39:06 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13388 13317 0 39 4 28

⚪ 2024-12-31 16:40:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-31 16:52:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
112 (only retried tests) 78 0 6 1 27

⚪ 2024-12-31 16:52:29 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-31 17:03:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
59 (only retried tests) 29 0 5 0 25

🟢 2024-12-31 17:04:00 UTC Build successful.
🟢 2024-12-31 17:04:29 UTC ydbd size 3.6 GiB changed* by -12.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: acaff68 merge: 3fda5a6 diff diff %
ydbd size 3 872 312 048 Bytes 3 872 299 608 Bytes -12.1 KiB -0.000%
ydbd stripped size 1 350 331 792 Bytes 1 350 328 272 Bytes -3.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga self-assigned this Jan 8, 2025
@kunga kunga force-pushed the revert-remove-user-rights branch from 1dda2be to 3adffbd Compare January 8, 2025 14:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

⚪ 2025-01-08 14:18:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for cc5e4b5 has started.
⚪ 2025-01-08 14:18:55 UTC Artifacts will be uploaded here
⚪ 2025-01-08 14:22:12 UTC ya make is running...
⚫ 2025-01-08 14:26:55 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

⚪ 2025-01-08 14:18:46 UTC Pre-commit check linux-x86_64-release-asan for cc5e4b5 has started.
⚪ 2025-01-08 14:18:58 UTC Artifacts will be uploaded here
⚪ 2025-01-08 14:22:13 UTC ya make is running...
⚫ 2025-01-08 14:26:54 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

⚪ 2025-01-08 14:30:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for 362025d has started.
⚪ 2025-01-08 14:30:57 UTC Artifacts will be uploaded here
⚪ 2025-01-08 14:34:05 UTC ya make is running...
🟡 2025-01-08 15:48:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27313 24799 0 6 2383 125

⚪ 2025-01-08 15:51:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-08 16:03:18 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
192 (only retried tests) 72 0 0 0 120

🟢 2025-01-08 16:03:24 UTC Build successful.
🟢 2025-01-08 16:03:43 UTC ydbd size 2.1 GiB changed* by -16.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 96abd52 merge: 362025d diff diff %
ydbd size 2 244 213 440 Bytes 2 244 197 096 Bytes -16.0 KiB -0.001%
ydbd stripped size 472 322 416 Bytes 472 319 024 Bytes -3.3 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

⚪ 2025-01-08 14:30:46 UTC Pre-commit check linux-x86_64-release-asan for 362025d has started.
⚪ 2025-01-08 14:30:59 UTC Artifacts will be uploaded here
⚪ 2025-01-08 14:34:11 UTC ya make is running...
🟡 2025-01-08 15:58:27 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13393 13324 0 32 7 30

⚪ 2025-01-08 15:59:33 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 16:11:39 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 77 0 9 0 27

⚪ 2025-01-08 16:11:48 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-08 16:23:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 35 0 3 1 26

🟢 2025-01-08 16:23:22 UTC Build successful.
🟢 2025-01-08 16:23:52 UTC ydbd size 3.6 GiB changed* by -12.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 96abd52 merge: 362025d diff diff %
ydbd size 3 873 655 368 Bytes 3 873 642 928 Bytes -12.1 KiB -0.000%
ydbd stripped size 1 350 627 952 Bytes 1 350 624 432 Bytes -3.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

⚪ 2025-01-08 17:30:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for fc38cb2 has started.
⚪ 2025-01-08 17:30:50 UTC Artifacts will be uploaded here
⚪ 2025-01-08 17:34:12 UTC ya make is running...
🟡 2025-01-08 18:41:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27318 24803 0 3 2384 128

⚪ 2025-01-08 18:44:08 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-08 18:56:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
194 (only retried tests) 73 0 0 0 121

🟢 2025-01-08 18:56:22 UTC Build successful.
🟢 2025-01-08 18:56:42 UTC ydbd size 2.1 GiB changed* by -15.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9f31130 merge: fc38cb2 diff diff %
ydbd size 2 244 317 464 Bytes 2 244 301 184 Bytes -15.9 KiB -0.001%
ydbd stripped size 472 336 560 Bytes 472 333 232 Bytes -3.2 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025 •
edited
Loading

⚪ 2025-01-08 17:30:39 UTC Pre-commit check linux-x86_64-release-asan for fc38cb2 has started.
⚪ 2025-01-08 17:30:52 UTC Artifacts will be uploaded here
⚪ 2025-01-08 17:34:05 UTC ya make is running...
🟡 2025-01-08 18:48:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13385 13308 0 39 9 29

⚪ 2025-01-08 18:49:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-08 19:01:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
114 (only retried tests) 77 0 6 4 27

⚪ 2025-01-08 19:01:34 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-08 19:12:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 31 0 4 4 26

🟢 2025-01-08 19:13:03 UTC Build successful.
🟢 2025-01-08 19:13:32 UTC ydbd size 3.6 GiB changed* by -12.1 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 9f31130 merge: fc38cb2 diff diff %
ydbd size 3 873 834 368 Bytes 3 873 821 976 Bytes -12.1 KiB -0.000%
ydbd stripped size 1 350 684 240 Bytes 1 350 680 784 Bytes -3.4 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kunga kunga merged commit 1f70dff into ydb-platform:main Jan 20, 2025
12 checks passed
the-ancient-1 pushed a commit to the-ancient-1/ydb that referenced this pull request Jan 21, 2025
@kunga @the-ancient-1
Forbid to remove user with access (ydb-platform#13144)
84fc20d
@kunga kunga mentioned this pull request Jan 28, 2025
Merged
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
@kunga @azevaykin
Forbid to remove user with access (ydb-platform#13144)
34225e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azevaykin azevaykin azevaykin left review comments

@ijon ijon ijon approved these changes

@adameat adameat Awaiting requested review from adameat

Assignees

@kunga kunga

Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kunga @ijon @azevaykin