Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect processing event undelivering in scan fetcher #13092

Merged

Conversation

ivanmorozov333
Copy link
Collaborator

  • Bugfix

Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 13:19:49 UTC Pre-commit check linux-x86_64-release-asan for 9369f92 has started.
2024-12-27 13:20:17 UTC Artifacts will be uploaded here
2024-12-27 13:23:21 UTC ya make is running...
🟢 2024-12-27 13:25:46 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-27 13:25:52 UTC Build successful.

Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 13:20:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9369f92 has started.
2024-12-27 13:20:14 UTC Artifacts will be uploaded here
2024-12-27 13:22:45 UTC ya make is running...
🟢 2024-12-27 13:33:41 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
405 384 0 0 0 21

🟢 2024-12-27 13:33:49 UTC Build successful.

@ivanmorozov333 ivanmorozov333 added the rebase-and-check Rebase PR with the current base branch and check label Dec 27, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 27, 2024
Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 13:55:56 UTC Pre-commit check linux-x86_64-release-asan for 947900f has started.
2024-12-27 13:56:23 UTC Artifacts will be uploaded here
2024-12-27 13:58:46 UTC ya make is running...
🟢 2024-12-27 14:01:41 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-27 14:01:46 UTC Build successful.

Copy link

github-actions bot commented Dec 27, 2024

2024-12-27 13:56:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 947900f has started.
2024-12-27 13:56:23 UTC Artifacts will be uploaded here
2024-12-27 13:58:45 UTC ya make is running...
🟢 2024-12-27 14:09:47 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
405 384 0 0 0 21

🟢 2024-12-27 14:09:54 UTC Build successful.

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 06:05:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5a6f149 has started.
2024-12-28 06:05:15 UTC Artifacts will be uploaded here
2024-12-28 06:06:41 UTC Check cancelled

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 06:05:41 UTC Pre-commit check linux-x86_64-release-asan for 5a6f149 has started.
2024-12-28 06:05:53 UTC Artifacts will be uploaded here
2024-12-28 06:06:41 UTC Check cancelled

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 06:08:10 UTC Pre-commit check linux-x86_64-release-asan for fe0e4d6 has started.
2024-12-28 06:08:14 UTC Artifacts will be uploaded here
2024-12-28 06:11:11 UTC ya make is running...
🟡 2024-12-28 07:08:53 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11479 11398 0 38 12 31

2024-12-28 07:09:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-28 07:22:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
134 (only retried tests) 93 0 11 3 27

2024-12-28 07:22:12 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-28 07:33:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
75 (only retried tests) 42 0 5 3 25

🟢 2024-12-28 07:33:49 UTC Build successful.
🟢 2024-12-28 07:34:22 UTC ydbd size 3.6 GiB changed* by +15.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ba06b7b merge: fe0e4d6 diff diff %
ydbd size 3 869 698 312 Bytes 3 869 714 304 Bytes +15.6 KiB +0.000%
ydbd stripped size 1 349 420 720 Bytes 1 349 424 880 Bytes +4.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 06:10:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for fe0e4d6 has started.
2024-12-28 06:10:47 UTC Artifacts will be uploaded here
2024-12-28 06:13:36 UTC ya make is running...
🟡 2024-12-28 07:04:09 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17197 16789 0 3 279 126

2024-12-28 07:05:45 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-28 07:17:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
187 (only retried tests) 66 0 1 0 120

2024-12-28 07:17:53 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-28 07:29:14 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
176 (only retried tests) 56 0 0 0 120

🟢 2024-12-28 07:29:21 UTC Build successful.
🟢 2024-12-28 07:29:43 UTC ydbd size 2.1 GiB changed* by +8.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: ba06b7b merge: fe0e4d6 diff diff %
ydbd size 2 241 897 728 Bytes 2 241 906 720 Bytes +8.8 KiB +0.000%
ydbd stripped size 472 055 696 Bytes 472 057 424 Bytes +1.7 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 08:23:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9230741 has started.
2024-12-28 08:23:47 UTC Artifacts will be uploaded here
2024-12-28 08:26:45 UTC ya make is running...
2024-12-28 08:36:40 UTC Check cancelled

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 08:23:44 UTC Pre-commit check linux-x86_64-release-asan for 9230741 has started.
2024-12-28 08:23:56 UTC Artifacts will be uploaded here
2024-12-28 08:26:55 UTC ya make is running...
2024-12-28 08:36:52 UTC Check cancelled

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 08:38:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0f7c424 has started.
2024-12-28 08:40:07 UTC Artifacts will be uploaded here
2024-12-28 08:43:35 UTC ya make is running...
🟡 2024-12-28 09:28:34 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17197 16788 0 6 282 121

2024-12-28 09:30:07 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-28 09:33:29 UTC ydbd size 2.1 GiB changed* by -6.2 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: ada1a64 merge: 0f7c424 diff diff %
ydbd size 2 241 897 728 Bytes 2 241 891 400 Bytes -6.2 KiB -0.000%
ydbd stripped size 472 055 696 Bytes 472 054 480 Bytes -1.2 KiB -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-12-28 09:33:31 UTC Check cancelled

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 08:41:13 UTC Pre-commit check linux-x86_64-release-asan for 0f7c424 has started.
2024-12-28 08:41:25 UTC Artifacts will be uploaded here
2024-12-28 08:44:23 UTC ya make is running...
2024-12-28 09:33:20 UTC Check cancelled

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 09:37:24 UTC Pre-commit check linux-x86_64-release-asan for da058e9 has started.
2024-12-28 09:37:35 UTC Artifacts will be uploaded here
2024-12-28 09:40:29 UTC ya make is running...
2024-12-28 09:46:13 UTC Check cancelled

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 09:38:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for da058e9 has started.
2024-12-28 09:38:32 UTC Artifacts will be uploaded here
2024-12-28 09:41:25 UTC ya make is running...
2024-12-28 09:46:08 UTC Check cancelled

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 09:50:05 UTC Pre-commit check linux-x86_64-release-asan for 25b326d has started.
2024-12-28 09:50:17 UTC Artifacts will be uploaded here
2024-12-28 09:53:19 UTC ya make is running...
🟡 2024-12-28 10:45:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11482 11411 0 35 9 27

2024-12-28 10:46:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-28 10:58:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
127 (only retried tests) 90 0 7 4 26

2024-12-28 10:58:39 UTC ya make is running... (failed tests rerun, try 3)
🟡 2024-12-28 11:10:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 32 0 5 4 26

🟢 2024-12-28 11:10:27 UTC Build successful.
🟢 2024-12-28 11:10:55 UTC ydbd size 3.6 GiB changed* by +11.8 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: aabfa88 merge: 25b326d diff diff %
ydbd size 3 869 691 592 Bytes 3 869 703 688 Bytes +11.8 KiB +0.000%
ydbd stripped size 1 349 423 408 Bytes 1 349 426 608 Bytes +3.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 28, 2024

2024-12-28 09:50:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 25b326d has started.
2024-12-28 09:50:40 UTC Artifacts will be uploaded here
2024-12-28 09:53:35 UTC ya make is running...
🟢 2024-12-28 10:37:58 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
17200 16798 0 0 277 125

🟢 2024-12-28 10:39:41 UTC Build successful.
🟢 2024-12-28 10:39:58 UTC ydbd size 2.1 GiB changed* by +6.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: aabfa88 merge: 25b326d diff diff %
ydbd size 2 241 894 088 Bytes 2 241 900 232 Bytes +6.0 KiB +0.000%
ydbd stripped size 472 057 552 Bytes 472 058 704 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 changed the title fix race in test in case many parts in reply fix incorrect processing event undelivering in scan fetcher Dec 28, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Dec 28, 2024
@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review December 28, 2024 12:15
@ivanmorozov333 ivanmorozov333 enabled auto-merge (squash) December 28, 2024 16:10
@ivanmorozov333 ivanmorozov333 merged commit 71ad71f into ydb-platform:main Dec 28, 2024
13 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_test_restart_many_shards branch December 29, 2024 05:35
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 21, 2025
…form#13092)

Conflicts:
	ydb/core/kqp/compute_actor/kqp_scan_compute_manager.h
	ydb/core/kqp/compute_actor/kqp_scan_fetcher_actor.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants