Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not switch ddl/dml when using query service #13011

Merged
merged 1 commit into from
Dec 25, 2024
Merged

do not switch ddl/dml when using query service #13011

merged 1 commit into from
Dec 25, 2024

Conversation

zverevgeny
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

@zverevgeny zverevgeny enabled auto-merge (squash) December 25, 2024 20:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 20:16:14 UTC Pre-commit check linux-x86_64-release-asan for 2b67ca0 has started.
⚪ 2024-12-25 20:16:27 UTC Artifacts will be uploaded here
⚪ 2024-12-25 20:18:49 UTC ya make is running...
🟢 2024-12-25 20:18:54 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-25 20:18:59 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 20:16:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2b67ca0 has started.
⚪ 2024-12-25 20:16:28 UTC Artifacts will be uploaded here
⚪ 2024-12-25 20:18:55 UTC ya make is running...
🟢 2024-12-25 20:22:43 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 113 0 0 0 0

🟢 2024-12-25 20:22:50 UTC Build successful.
🔴 2024-12-25 20:22:58 UTC ydbd size 2.1 GiB changed* by +12.2 MiB, which is >= 2.0 MiB vs main: Alert

ydbd size dash main: e3d3da9 merge: 2b67ca0 diff diff %
ydbd size 2 226 280 768 Bytes 2 239 042 048 Bytes +12.2 MiB +0.573%
ydbd stripped size 467 398 352 Bytes 471 345 104 Bytes +3.8 MiB +0.844%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny merged commit ce8b8ec into ydb-platform:main Dec 25, 2024
13 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Dec 27, 2024
Merged
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
@zverevgeny
do not switch ddl/dml when using query service (ydb-platform#13011)
5c32312 
Conflicts:
	ydb/tests/functional/suite_tests/test_base.py
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 4, 2025
@zverevgeny
Revert "do not switch ddl/dml when using query service (ydb-platform#…
4526413 
…13011)"

This reverts commit 5c32312.
@GrigoriyPA GrigoriyPA mentioned this pull request Jan 5, 2025
Merged
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
@zverevgeny
do not switch ddl/dml when using query service (ydb-platform#13011)
df8bf92 
Conflicts:
	ydb/tests/functional/suite_tests/test_base.py
@zverevgeny zverevgeny mentioned this pull request Jan 9, 2025
Closed
@zverevgeny zverevgeny linked an issue Jan 21, 2025 that may be closed by this pull request
Adapt suite_tests for running on column tables #12342
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt suite_tests for running on column tables
2 participants
@zverevgeny @maximyurchuk