Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove table with _ne suffix creation #13002

Merged
merged 1 commit into from
Dec 25, 2024
Merged

remove table with _ne suffix creation #13002

merged 1 commit into from
Dec 25, 2024

Conversation

zverevgeny
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

zverevgeny
zverevgeny commented Dec 25, 2024
View reviewed changes
ydb/tests/functional/suite_tests/test_base.py
@@ -458,14 +456,12 @@ def explain(self, query):
return self.legacy_pool.retry_operation_sync(lambda s: s.explain(yql_text)).query_plan

def execute_scheme(self, statement_text):
yql_text = format_yql_statement(statement_text, self.table_path_prefix)
self.pool.execute_with_retries(yql_text)
yql_text = format_yql_statement(statement_text, self.table_path_prefix_ne)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gridnevvvit я не смог понять, зачем это тут. Может ты помнишь?

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 16:25:12 UTC Pre-commit check linux-x86_64-release-asan for dd78e90 has started.
⚪ 2024-12-25 16:25:37 UTC Artifacts will be uploaded here
⚪ 2024-12-25 16:27:58 UTC ya make is running...
🟢 2024-12-25 16:28:03 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2024-12-25 16:28:09 UTC Build successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

⚪ 2024-12-25 16:25:46 UTC Pre-commit check linux-x86_64-relwithdebinfo for dd78e90 has started.
⚪ 2024-12-25 16:26:10 UTC Artifacts will be uploaded here
⚪ 2024-12-25 16:28:31 UTC ya make is running...
🟢 2024-12-25 16:32:09 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 113 0 0 0 0

🟢 2024-12-25 16:32:16 UTC Build successful.
🟡 2024-12-25 16:32:25 UTC ydbd size 2.1 GiB changed* by +175.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: dfda963 merge: dd78e90 diff diff %
ydbd size 2 226 100 904 Bytes 2 226 280 688 Bytes +175.6 KiB +0.008%
ydbd stripped size 467 364 368 Bytes 467 398 288 Bytes +33.1 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@zverevgeny zverevgeny marked this pull request as ready for review December 25, 2024 16:48
@zverevgeny zverevgeny merged commit 61f38fc into ydb-platform:main Dec 25, 2024
13 checks passed
@GrigoriyPA GrigoriyPA mentioned this pull request Dec 27, 2024
Merged
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
@zverevgeny
remove table with _ne suffix creation (ydb-platform#13002)
9855159 
Conflicts:
	ydb/tests/functional/suite_tests/test_base.py
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 4, 2025
@zverevgeny
Revert "remove table with _ne suffix creation (ydb-platform#13002)"
254fcb3 
This reverts commit 9855159.
@GrigoriyPA GrigoriyPA mentioned this pull request Jan 5, 2025
Merged
zverevgeny added a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
@zverevgeny
remove table with _ne suffix creation (ydb-platform#13002)
28881f7 
Conflicts:
	ydb/tests/functional/suite_tests/test_base.py
@zverevgeny zverevgeny mentioned this pull request Jan 9, 2025
Closed
@zverevgeny zverevgeny linked an issue Jan 21, 2025 that may be closed by this pull request
Adapt suite_tests for running on column tables #12342
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gridnevvvit gridnevvvit gridnevvvit approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt suite_tests for running on column tables
2 participants
@zverevgeny @gridnevvvit