Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: Fix disabled use virtual addressing option for import from S3 (#9162) #12915

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

pixcc
Copy link
Member

@pixcc pixcc commented Dec 24, 2024

Changelog entry

Fix disabled use virtual addressing option for import from S3

Changelog category

  • Bugfix

Additional information

This fix allows import tables from S3 using path style addressing model

@pixcc pixcc requested a review from a team as a code owner December 24, 2024 11:49
Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 11:52:40 UTC Pre-commit check for aa965b1 has started.
2024-12-24 11:55:26 UTC Build linux-x86_64-release-asan is running...
🔴 2024-12-24 11:55:40 UTC Build failed. see the build logs.
🔴 2024-12-24 11:55:42 UTC Tests run skipped.

Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 11:52:51 UTC Pre-commit check for aa965b1 has started.
2024-12-24 11:55:27 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-12-24 11:55:41 UTC Build failed. see the build logs.
🔴 2024-12-24 11:55:42 UTC Tests run skipped.

@pixcc pixcc changed the title Fix disabled use virtual addressing option for import from S3 (#9162) 24-3: Fix disabled use virtual addressing option for import from S3 (#9162) Dec 24, 2024
@pixcc pixcc self-assigned this Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 12:00:35 UTC Pre-commit check for a9221e3 has started.
2024-12-24 12:03:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-24 12:43:46 UTC Build successful.
2024-12-24 12:44:04 UTC Tests are running...
🔴 2024-12-24 14:09:47 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14742 13395 0 9 1300 38

🟢 2024-12-24 14:10:41 UTC ydbd size 8.3 GiB changed* by +320 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 7a00bd0 merge: a9221e3 diff diff %
ydbd size 8 873 880 104 Bytes 8 873 880 424 Bytes +320 Bytes +0.000%
ydbd stripped size 484 378 728 Bytes 484 378 728 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 24, 2024

2024-12-24 12:00:55 UTC Pre-commit check for a9221e3 has started.
2024-12-24 12:03:37 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-24 12:28:05 UTC Build successful.
2024-12-24 12:28:23 UTC Tests are running...
🔴 2024-12-24 14:39:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10420 10328 0 19 29 44

🟢 2024-12-24 14:39:53 UTC ydbd size 5.6 GiB changed* by +368 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 7a00bd0 merge: a9221e3 diff diff %
ydbd size 6 002 886 944 Bytes 6 002 887 312 Bytes +368 Bytes +0.000%
ydbd stripped size 1 504 283 520 Bytes 1 504 283 584 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pixcc pixcc merged commit 337e915 into ydb-platform:stable-24-3 Dec 25, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants