Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parsing of s3 settings on CS #12856

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

swalrus1
Copy link
Collaborator

  • fix s3 settings conversion
  • add unit-test

Changelog entry

Fix parsing S3 settings on CS

Changelog category

  • Bugfix

Additional information

...

Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 18:31:38 UTC Pre-commit check linux-x86_64-release-asan for cfcb17f has started.
2024-12-20 18:31:50 UTC Artifacts will be uploaded here
2024-12-20 18:34:39 UTC ya make is running...
🟡 2024-12-20 19:34:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12178 12104 0 16 8 50

🟢 2024-12-20 19:35:49 UTC Build successful.
🟢 2024-12-20 19:36:15 UTC ydbd size 3.6 GiB changed* by +3.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d2e4bb8 merge: cfcb17f diff diff %
ydbd size 3 866 288 592 Bytes 3 866 291 776 Bytes +3.1 KiB +0.000%
ydbd stripped size 1 350 523 280 Bytes 1 350 524 048 Bytes +768 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 18:32:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for cfcb17f has started.
2024-12-20 18:32:25 UTC Artifacts will be uploaded here
2024-12-20 18:35:20 UTC ya make is running...
🟡 2024-12-20 19:25:57 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19404 17869 0 4 1415 116

2024-12-20 19:27:52 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-20 19:40:01 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
166 (only retried tests) 56 0 0 0 110

🟢 2024-12-20 19:40:10 UTC Build successful.
🟢 2024-12-20 19:40:27 UTC ydbd size 2.1 GiB changed* by +1.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: d2e4bb8 merge: cfcb17f diff diff %
ydbd size 2 235 568 584 Bytes 2 235 569 984 Bytes +1.4 KiB +0.000%
ydbd stripped size 477 930 768 Bytes 477 931 152 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 changed the title fix parsing s3 settings on CS fix parsing of s3 settings on CS Dec 20, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Dec 20, 2024
@swalrus1 swalrus1 marked this pull request as ready for review January 9, 2025 12:34
@swalrus1 swalrus1 merged commit 732a8e5 into ydb-platform:main Jan 10, 2025
12 checks passed
@swalrus1 swalrus1 deleted the fix-parsing-s3 branch January 10, 2025 08:49
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 21, 2025
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants