Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: Fix disconnected proxies unexpectedly registering in kesus #12807

Conversation

snaury
Copy link
Member

@snaury snaury commented Dec 20, 2024

Changelog entry

Fix disconnected proxies unexpectedly registering in coordination service.

Changelog category

  • Bugfix

Additional information

It was possible for coordination service proxies to successfully register in the kesus tablet after they disconnect, which caused a state mismatch and incorrect registration result handling. Sending registration replies over the same interconnect session avoids the problem: proxy does not receive an unexpected reply, and tablet promptly detects a disconnected proxy.

@snaury snaury self-assigned this Dec 20, 2024
Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 07:59:17 UTC Pre-commit check for a097f91 has started.
2024-12-20 08:02:01 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-20 08:43:15 UTC Build successful.
2024-12-20 08:43:32 UTC Tests are running...
🔴 2024-12-20 10:12:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14697 13342 0 11 1303 41

🟢 2024-12-20 10:13:00 UTC ydbd size 8.3 GiB changed* by +12.8 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 11eb58f merge: a097f91 diff diff %
ydbd size 8 873 502 784 Bytes 8 873 515 848 Bytes +12.8 KiB +0.000%
ydbd stripped size 484 350 248 Bytes 484 351 272 Bytes +1.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 20, 2024

2024-12-20 07:59:41 UTC Pre-commit check for a097f91 has started.
2024-12-20 08:02:27 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-20 08:26:37 UTC Build successful.
2024-12-20 08:26:52 UTC Tests are running...
🔴 2024-12-20 10:41:56 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10372 10276 0 23 30 43

🟢 2024-12-20 10:42:45 UTC ydbd size 5.6 GiB changed* by +12.3 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 11eb58f merge: a097f91 diff diff %
ydbd size 6 002 539 248 Bytes 6 002 551 816 Bytes +12.3 KiB +0.000%
ydbd stripped size 1 504 193 600 Bytes 1 504 196 416 Bytes +2.8 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@snaury snaury marked this pull request as ready for review December 20, 2024 09:05
@snaury snaury requested a review from a team as a code owner December 20, 2024 09:05
@snaury snaury merged commit 5b01f74 into ydb-platform:stable-24-3 Dec 23, 2024
6 of 10 checks passed
@snaury snaury deleted the fix-kesus-register-after-disconnect-24-3 branch December 23, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants