Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enabled by default enable_antlr4_parser feature-flag for ydb … #12733

Merged
merged 1 commit into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ydb/tests/fq/s3/test_ydb_over_fq.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def test_execute_data_query_error(self, kikimr, s3, client, unique_prefix, yq_ve
with session.transaction() as tx:
assert_that(
calling(tx.execute).with_args("BAD QUERY"),
raises(ydb.issues.InternalError, "(mismatched input .* expecting)|(Unexpected token .* : cannot match to any predicted input)"),
raises(ydb.issues.InternalError, "Unexpected token .* : cannot match to any predicted input"),
)
with session.transaction() as tx:
query = "select * from {}{}".format("bindings." if yq_version == "v1" else "", "WRONG_BIND")
Expand Down
2 changes: 1 addition & 1 deletion ydb/tests/fq/yds/test_select_1.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def test_compile_error(self, client, yq_version):
assert (
"Query failed with code " + ("ABORTED" if yq_version == "v1" else "GENERIC_ERROR") in describe_string
), describe_string
assert "extraneous input" in describe_string or "Unexpected token" in describe_string, describe_string
assert "Unexpected token" in describe_string, describe_string
# Failed to parse query is added in YQv1 only
if yq_version == "v1":
assert "Failed to parse query" in describe_string, describe_string
Expand Down
1 change: 0 additions & 1 deletion ydb/tests/library/harness/resources/default_yaml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ feature_flags:
enable_persistent_query_stats: true
enable_scheme_transactions_at_scheme_shard: true
enable_mvcc_snapshot_reads: true
enable_antlr4_parser: true
kqpconfig:
settings:
- name: "_ResultRowsLimit"
Expand Down
Loading