Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update followers in 24-3 #12683

Closed
wants to merge 5 commits into from

Conversation

vporyadke
Copy link
Collaborator

Changelog entry

Make per-dc followers explicitly tied to datacenters. This eliminates problems like followers not appearing in a datacenter after an outage.

Changelog category

  • Improvement

Additional information

#8069 + #12024

@vporyadke vporyadke requested a review from a team as a code owner December 17, 2024 13:43
Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 13:44:52 UTC Pre-commit check for be56391 has started.
2024-12-17 13:47:38 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-17 14:14:49 UTC Build successful.
2024-12-17 14:15:05 UTC Tests are running...
🔴 2024-12-17 16:24:04 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11615 11533 0 17 24 41

🟡 2024-12-17 16:24:47 UTC ydbd size 5.6 GiB changed* by +531.8 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 030b601 merge: be56391 diff diff %
ydbd size 6 002 408 536 Bytes 6 002 953 128 Bytes +531.8 KiB +0.009%
ydbd stripped size 1 504 166 976 Bytes 1 504 233 088 Bytes +64.6 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 13:46:09 UTC Pre-commit check for be56391 has started.
2024-12-17 13:49:14 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-17 14:34:40 UTC Build successful.
2024-12-17 14:34:56 UTC Tests are running...
🔴 2024-12-17 16:38:07 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40202 34930 0 15 5217 40

🟡 2024-12-17 16:38:54 UTC ydbd size 8.3 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 030b601 merge: be56391 diff diff %
ydbd size 8 873 321 720 Bytes 8 874 505 696 Bytes +1.1 MiB +0.013%
ydbd stripped size 484 343 080 Bytes 484 358 248 Bytes +14.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@vporyadke vporyadke requested a review from CyberROFL December 19, 2024 12:56
}
dataCenter.UpdateScheduled = false;
if (dataCenter.IsRegistered()) {
for (auto& [tabletId, tablet] : Self->Tablets) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не слишком ли жирно уходить тут в спячку? Как будет вести себя Hive с десятками, сотнями тысяч таблеток?

Copy link

github-actions bot commented Jan 9, 2025

2025-01-09 09:02:19 UTC Pre-commit check for 169870e has started.
2025-01-09 09:05:22 UTC Build linux-x86_64-release-asan is running...
🟢 2025-01-09 09:31:31 UTC Build successful.
2025-01-09 09:31:48 UTC Tests are running...
🔴 2025-01-09 11:46:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11635 11532 0 29 31 43

🟡 2025-01-09 11:47:18 UTC ydbd size 5.6 GiB changed* by +1.0 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 30aae3f merge: 169870e diff diff %
ydbd size 6 003 003 312 Bytes 6 004 056 112 Bytes +1.0 MiB +0.018%
ydbd stripped size 1 504 326 272 Bytes 1 504 435 264 Bytes +106.4 KiB +0.007%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Jan 9, 2025

2025-01-09 09:04:04 UTC Pre-commit check for 169870e has started.
2025-01-09 09:06:48 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2025-01-09 09:55:00 UTC Build successful.
2025-01-09 09:55:15 UTC Tests are running...
🔴 2025-01-09 11:47:47 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
40213 34944 0 13 5217 39

🟡 2025-01-09 11:48:43 UTC ydbd size 8.3 GiB changed* by +2.0 MiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 30aae3f merge: 169870e diff diff %
ydbd size 8 874 007 904 Bytes 8 876 083 632 Bytes +2.0 MiB +0.023%
ydbd stripped size 484 393 640 Bytes 484 421 032 Bytes +26.8 KiB +0.006%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants