Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory hold after writing aborted #12682

Conversation

ivanmorozov333
Copy link
Collaborator

  • Bugfix

@ivanmorozov333 ivanmorozov333 changed the title fix memory hold after abort writing fix memory hold after writing aborted Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 13:28:13 UTC Pre-commit check linux-x86_64-release-asan for f435196 has started.
2024-12-17 13:28:53 UTC Artifacts will be uploaded here
2024-12-17 13:32:23 UTC ya make is running...
2024-12-17 13:53:16 UTC Check cancelled

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 13:29:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for f435196 has started.
2024-12-17 13:30:09 UTC Artifacts will be uploaded here
2024-12-17 13:33:13 UTC ya make is running...
2024-12-17 13:53:16 UTC Check cancelled

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 13:56:26 UTC Pre-commit check linux-x86_64-release-asan for 5cda1aa has started.
2024-12-17 13:57:34 UTC Artifacts will be uploaded here
2024-12-17 14:00:59 UTC ya make is running...
2024-12-17 14:33:48 UTC Check cancelled

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 13:57:02 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5cda1aa has started.
2024-12-17 13:57:15 UTC Artifacts will be uploaded here
2024-12-17 14:00:07 UTC ya make is running...
2024-12-17 14:33:34 UTC Check cancelled

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 14:36:53 UTC Pre-commit check linux-x86_64-release-asan for 86a2025 has started.
2024-12-17 14:37:05 UTC Artifacts will be uploaded here
2024-12-17 14:38:43 UTC Check cancelled

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 14:36:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for 86a2025 has started.
2024-12-17 14:37:08 UTC Artifacts will be uploaded here
2024-12-17 14:38:43 UTC Check cancelled

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 14:42:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for d5388d2 has started.
2024-12-17 14:42:42 UTC Artifacts will be uploaded here
2024-12-17 14:45:35 UTC ya make is running...
🟡 2024-12-17 15:36:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19006 17477 0 1 1414 114

2024-12-17 15:37:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-17 15:49:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
160 (only retried tests) 51 0 0 0 109

🟢 2024-12-17 15:49:23 UTC Build successful.
🟡 2024-12-17 15:49:40 UTC ydbd size 2.1 GiB changed* by +1.1 MiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 121c8b3 merge: d5388d2 diff diff %
ydbd size 2 255 310 624 Bytes 2 256 491 776 Bytes +1.1 MiB +0.052%
ydbd stripped size 483 135 472 Bytes 483 288 368 Bytes +149.3 KiB +0.032%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 17, 2024

2024-12-17 14:43:18 UTC Pre-commit check linux-x86_64-release-asan for d5388d2 has started.
2024-12-17 14:43:30 UTC Artifacts will be uploaded here
2024-12-17 14:46:31 UTC ya make is running...
🟡 2024-12-17 16:01:56 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12053 11971 0 24 14 44

🟢 2024-12-17 16:02:56 UTC Build successful.
🟢 2024-12-17 16:03:20 UTC ydbd size 3.6 GiB changed* by +57.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3ad42c8 merge: d5388d2 diff diff %
ydbd size 3 898 623 600 Bytes 3 898 681 944 Bytes +57.0 KiB +0.001%
ydbd stripped size 1 364 399 248 Bytes 1 364 415 184 Bytes +15.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

swalrus1
swalrus1 previously approved these changes Dec 17, 2024
Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 08:01:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1e887d5 has started.
2024-12-18 08:01:15 UTC Artifacts will be uploaded here
2024-12-18 08:04:40 UTC ya make is running...
🔴 2024-12-18 08:22:23 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 08:02:05 UTC Pre-commit check linux-x86_64-release-asan for 1e887d5 has started.
2024-12-18 08:02:17 UTC Artifacts will be uploaded here
2024-12-18 08:05:46 UTC ya make is running...
🔴 2024-12-18 08:23:31 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 10:35:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4d81f96 has started.
2024-12-18 10:35:36 UTC Artifacts will be uploaded here
2024-12-18 10:37:05 UTC Check cancelled

Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 10:35:29 UTC Pre-commit check linux-x86_64-release-asan for 4d81f96 has started.
2024-12-18 10:36:05 UTC Artifacts will be uploaded here
2024-12-18 10:37:05 UTC Check cancelled

@ivanmorozov333 ivanmorozov333 force-pushed the fix_memory_hold_after_abort_writing branch from 4ff8027 to d6b1587 Compare December 18, 2024 10:36
Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 10:38:33 UTC Pre-commit check linux-x86_64-release-asan for 28b19bc has started.
2024-12-18 10:38:45 UTC Artifacts will be uploaded here
2024-12-18 10:42:06 UTC ya make is running...
2024-12-18 10:48:00 UTC Check cancelled

Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 10:38:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 28b19bc has started.
2024-12-18 10:38:45 UTC Artifacts will be uploaded here
2024-12-18 10:42:10 UTC ya make is running...
2024-12-18 10:47:59 UTC Check cancelled

Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 10:49:44 UTC Pre-commit check linux-x86_64-release-asan for b6b8ebf has started.
2024-12-18 10:50:15 UTC Artifacts will be uploaded here
2024-12-18 10:54:01 UTC ya make is running...
🟡 2024-12-18 12:21:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14326 14214 0 54 8 50

🟢 2024-12-18 12:22:26 UTC Build successful.
🟡 2024-12-18 12:22:52 UTC ydbd size 3.6 GiB changed* by +608.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 3d7fe12 merge: b6b8ebf diff diff %
ydbd size 3 894 518 104 Bytes 3 895 140 992 Bytes +608.3 KiB +0.016%
ydbd stripped size 1 363 834 448 Bytes 1 363 970 032 Bytes +132.4 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 10:50:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for b6b8ebf has started.
2024-12-18 10:50:48 UTC Artifacts will be uploaded here
2024-12-18 10:54:12 UTC ya make is running...
🟡 2024-12-18 12:12:42 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31408 28450 0 8 2833 117

2024-12-18 12:20:21 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-18 12:26:44 UTC ydbd size 2.1 GiB changed* by +338.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 3d7fe12 merge: b6b8ebf diff diff %
ydbd size 2 253 716 912 Bytes 2 254 063 496 Bytes +338.5 KiB +0.015%
ydbd stripped size 483 049 840 Bytes 483 093 936 Bytes +43.1 KiB +0.009%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-12-18 12:26:46 UTC Check cancelled

Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 12:29:38 UTC Pre-commit check linux-x86_64-release-asan for e7abdf0 has started.
2024-12-18 12:30:19 UTC Artifacts will be uploaded here
2024-12-18 12:34:23 UTC ya make is running...
🟡 2024-12-18 14:16:32 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14330 14207 0 64 9 50

🟢 2024-12-18 14:17:49 UTC Build successful.
🟡 2024-12-18 14:18:23 UTC ydbd size 3.6 GiB changed* by +608.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 881ce4a merge: e7abdf0 diff diff %
ydbd size 3 894 631 112 Bytes 3 895 254 064 Bytes +608.4 KiB +0.016%
ydbd stripped size 1 363 862 608 Bytes 1 363 998 192 Bytes +132.4 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 18, 2024

2024-12-18 12:30:42 UTC Pre-commit check linux-x86_64-relwithdebinfo for e7abdf0 has started.
2024-12-18 12:31:01 UTC Artifacts will be uploaded here
2024-12-18 12:34:31 UTC ya make is running...
🟡 2024-12-18 15:56:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
31413 28464 0 2 2831 116

2024-12-18 15:59:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-18 16:11:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 54 0 0 0 108

🟢 2024-12-18 16:11:48 UTC Build successful.
🟡 2024-12-18 16:12:09 UTC ydbd size 2.1 GiB changed* by +342.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 881ce4a merge: e7abdf0 diff diff %
ydbd size 2 253 779 656 Bytes 2 254 130 368 Bytes +342.5 KiB +0.016%
ydbd stripped size 483 053 776 Bytes 483 101 968 Bytes +47.1 KiB +0.010%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review December 18, 2024 14:34
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner December 18, 2024 14:34
@ivanmorozov333 ivanmorozov333 merged commit ae2a5a5 into ydb-platform:main Dec 18, 2024
10 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_memory_hold_after_abort_writing branch December 18, 2024 16:55
asmyasnikov pushed a commit to asmyasnikov/ydb that referenced this pull request Dec 23, 2024
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants