Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect default storage id for count min sketch index #12643

Merged
merged 5 commits into from
Jan 3, 2025
Merged

fix incorrect default storage id for count min sketch index #12643

merged 5 commits into from
Jan 3, 2025

Conversation

ivanmorozov333
Copy link
Collaborator

  • Bugfix

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

⚪ 2024-12-16 12:38:56 UTC Pre-commit check linux-x86_64-relwithdebinfo for dd00ab2 has started.
⚪ 2024-12-16 12:39:07 UTC Artifacts will be uploaded here
⚪ 2024-12-16 12:41:58 UTC ya make is running...
🟡 2024-12-16 13:38:14 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
18968 17407 0 35 1412 114

⚪ 2024-12-16 13:39:57 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-16 13:51:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
227 (only retried tests) 84 0 33 0 110

⚪ 2024-12-16 13:51:32 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-16 14:04:02 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
221 (only retried tests) 78 0 33 0 110

🟢 2024-12-16 14:04:10 UTC Build successful.
🟡 2024-12-16 14:04:32 UTC ydbd size 2.1 GiB changed* by +525.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 93b71f1 merge: dd00ab2 diff diff %
ydbd size 2 252 045 376 Bytes 2 252 583 136 Bytes +525.2 KiB +0.024%
ydbd stripped size 482 602 256 Bytes 482 706 416 Bytes +101.7 KiB +0.022%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

⚪ 2024-12-16 12:41:17 UTC Pre-commit check linux-x86_64-release-asan for dd00ab2 has started.
⚪ 2024-12-16 12:41:28 UTC Artifacts will be uploaded here
⚪ 2024-12-16 12:44:20 UTC ya make is running...
🟡 2024-12-16 14:12:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12018 11912 0 53 7 46

🟢 2024-12-16 14:14:02 UTC Build successful.
🟢 2024-12-16 14:14:25 UTC ydbd size 3.6 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: dba3c01 merge: dd00ab2 diff diff %
ydbd size 3 892 191 944 Bytes 3 892 191 848 Bytes -96 Bytes -0.000%
ydbd stripped size 1 362 611 856 Bytes 1 362 611 792 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

zverevgeny
zverevgeny previously approved these changes Dec 16, 2024
View reviewed changes
@ivanmorozov333 ivanmorozov333 force-pushed the fix_cms_index_default_storage branch from 8a8634b to 0d5a97e Compare January 3, 2025 11:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 11:36:53 UTC Pre-commit check linux-x86_64-release-asan for 54deb11 has started.
⚪ 2025-01-03 11:37:06 UTC Artifacts will be uploaded here
⚪ 2025-01-03 11:40:11 UTC ya make is running...
🔴 2025-01-03 11:43:59 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 11:36:57 UTC Pre-commit check linux-x86_64-relwithdebinfo for 54deb11 has started.
⚪ 2025-01-03 11:37:09 UTC Artifacts will be uploaded here
⚪ 2025-01-03 11:40:21 UTC ya make is running...
🔴 2025-01-03 11:43:57 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 12:45:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for 234c482 has started.
⚪ 2025-01-03 12:45:38 UTC Artifacts will be uploaded here
⚪ 2025-01-03 12:48:34 UTC ya make is running...
⚫ 2025-01-03 12:52:24 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 12:45:51 UTC Pre-commit check linux-x86_64-release-asan for 234c482 has started.
⚪ 2025-01-03 12:46:03 UTC Artifacts will be uploaded here
⚪ 2025-01-03 12:49:15 UTC ya make is running...
⚫ 2025-01-03 12:52:24 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 12:53:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 07a1a26 has started.
⚪ 2025-01-03 12:53:58 UTC Artifacts will be uploaded here
⚪ 2025-01-03 12:56:53 UTC ya make is running...
🟡 2025-01-03 13:48:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22312 20794 0 41 1353 124

⚪ 2025-01-03 13:50:39 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-03 14:03:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
261 (only retried tests) 106 0 35 0 120

⚪ 2025-01-03 14:03:43 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-03 14:11:14 UTC ydbd size 2.1 GiB changed* by +132.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 77b7c35 merge: 07a1a26 diff diff %
ydbd size 2 243 476 656 Bytes 2 243 612 608 Bytes +132.8 KiB +0.006%
ydbd stripped size 472 241 552 Bytes 472 254 480 Bytes +12.6 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-01-03 14:11:15 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 12:56:26 UTC Pre-commit check linux-x86_64-release-asan for 07a1a26 has started.
⚪ 2025-01-03 12:56:38 UTC Artifacts will be uploaded here
⚪ 2025-01-03 12:59:33 UTC ya make is running...
🟡 2025-01-03 14:01:51 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11978 11886 0 61 1 30

⚪ 2025-01-03 14:02:55 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-03 14:11:17 UTC ydbd size 3.6 GiB changed* by +219.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 77b7c35 merge: 07a1a26 diff diff %
ydbd size 3 872 511 544 Bytes 3 872 735 960 Bytes +219.2 KiB +0.006%
ydbd stripped size 1 350 376 080 Bytes 1 350 419 216 Bytes +42.1 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-01-03 14:11:18 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 14:13:32 UTC Pre-commit check linux-x86_64-release-asan for bd12b62 has started.
⚪ 2025-01-03 14:13:57 UTC Artifacts will be uploaded here
⚪ 2025-01-03 14:16:53 UTC ya make is running...
🟡 2025-01-03 15:19:45 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11978 11916 0 29 3 30

⚪ 2025-01-03 15:20:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-01-03 15:32:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 72 0 6 1 25

⚪ 2025-01-03 15:32:11 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-01-03 15:36:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60 (only retried tests) 32 0 3 0 25

🟢 2025-01-03 15:36:37 UTC Build successful.
🟡 2025-01-03 15:37:07 UTC ydbd size 3.6 GiB changed* by +249.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 77b7c35 merge: bd12b62 diff diff %
ydbd size 3 872 511 544 Bytes 3 872 766 856 Bytes +249.3 KiB +0.007%
ydbd stripped size 1 350 376 080 Bytes 1 350 428 560 Bytes +51.2 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

⚪ 2025-01-03 14:15:21 UTC Pre-commit check linux-x86_64-relwithdebinfo for bd12b62 has started.
⚪ 2025-01-03 14:15:33 UTC Artifacts will be uploaded here
⚪ 2025-01-03 14:18:33 UTC ya make is running...
🟡 2025-01-03 15:06:49 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
22304 20815 0 8 1353 128

⚪ 2025-01-03 15:08:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-01-03 15:20:28 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
201 (only retried tests) 78 0 0 0 123

🟢 2025-01-03 15:20:34 UTC Build successful.
🟡 2025-01-03 15:20:53 UTC ydbd size 2.1 GiB changed* by +150.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 77b7c35 merge: bd12b62 diff diff %
ydbd size 2 243 476 656 Bytes 2 243 630 208 Bytes +150.0 KiB +0.007%
ydbd stripped size 472 241 552 Bytes 472 256 784 Bytes +14.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review January 3, 2025 15:31
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner January 3, 2025 15:31
@ivanmorozov333 ivanmorozov333 enabled auto-merge (squash) January 3, 2025 15:33
@ivanmorozov333 ivanmorozov333 merged commit d37db99 into ydb-platform:main Jan 3, 2025
12 checks passed
@ivanmorozov333 ivanmorozov333 deleted the fix_cms_index_default_storage branch January 3, 2025 15:56
@GrigoriyPA GrigoriyPA mentioned this pull request Jan 5, 2025
Merged
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 21, 2025
@ivanmorozov333 @zverevgeny
fix incorrect default storage id for count min sketch index (ydb-plat…
ad0aaab 
…form#12643)
@zverevgeny zverevgeny mentioned this pull request Jan 21, 2025
Closed
azevaykin pushed a commit to azevaykin/ydb that referenced this pull request Feb 3, 2025
@ivanmorozov333 @azevaykin
fix incorrect default storage id for count min sketch index (ydb-plat…
89c9542 
…form#12643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zverevgeny zverevgeny zverevgeny approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanmorozov333 @zverevgeny