Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement secret identification by name #12641

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

swalrus1
Copy link
Collaborator

@swalrus1 swalrus1 commented Dec 16, 2024

Changelog entry

extend secret snapshot: support secret id without owner

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

...

Copy link

github-actions bot commented Dec 16, 2024

2024-12-16 11:19:17 UTC Pre-commit check linux-x86_64-release-asan for cfc30db has started.
2024-12-16 11:19:31 UTC Artifacts will be uploaded here
2024-12-16 11:22:24 UTC ya make is running...
2024-12-16 11:43:45 UTC Check cancelled

Copy link

github-actions bot commented Dec 16, 2024

2024-12-16 11:19:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for cfc30db has started.
2024-12-16 11:20:11 UTC Artifacts will be uploaded here
2024-12-16 11:23:32 UTC ya make is running...
2024-12-16 11:43:47 UTC Check cancelled

@swalrus1 swalrus1 marked this pull request as ready for review December 16, 2024 11:26
Copy link

github-actions bot commented Dec 16, 2024

2024-12-16 11:47:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for e542999 has started.
2024-12-16 11:47:48 UTC Artifacts will be uploaded here
2024-12-16 11:50:41 UTC ya make is running...
🟡 2024-12-16 12:42:12 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19299 17770 0 6 1411 112

2024-12-16 12:44:13 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-16 12:55:43 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 55 0 2 1 107

2024-12-16 12:55:51 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-16 13:07:15 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
151 (only retried tests) 44 0 0 0 107

🟢 2024-12-16 13:07:21 UTC Build successful.
🟡 2024-12-16 13:07:41 UTC ydbd size 2.1 GiB changed* by +491.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8efacf9 merge: e542999 diff diff %
ydbd size 2 251 952 944 Bytes 2 252 456 224 Bytes +491.5 KiB +0.022%
ydbd stripped size 482 590 992 Bytes 482 597 392 Bytes +6.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 16, 2024

2024-12-16 11:47:43 UTC Pre-commit check linux-x86_64-release-asan for e542999 has started.
2024-12-16 11:47:54 UTC Artifacts will be uploaded here
2024-12-16 11:50:48 UTC ya make is running...
🟡 2024-12-16 12:54:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12099 12029 0 17 8 45

🟢 2024-12-16 12:55:39 UTC Build successful.
🟡 2024-12-16 12:56:03 UTC ydbd size 3.6 GiB changed* by +799.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 8efacf9 merge: e542999 diff diff %
ydbd size 3 890 892 600 Bytes 3 891 711 736 Bytes +799.9 KiB +0.021%
ydbd stripped size 1 362 201 936 Bytes 1 362 257 616 Bytes +54.4 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 merged commit 01126ac into ydb-platform:main Dec 16, 2024
11 checks passed
@swalrus1 swalrus1 deleted the secret-name-id branch December 16, 2024 15:46
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025
Conflicts:
	ydb/core/kqp/federated_query/kqp_federated_query_actors.cpp
	ydb/services/metadata/secret/snapshot.cpp
	ydb/services/metadata/secret/snapshot.h
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
Conflicts:
	ydb/core/kqp/federated_query/kqp_federated_query_actors.cpp
	ydb/services/metadata/secret/snapshot.cpp
	ydb/services/metadata/secret/snapshot.h
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025
Conflicts:
	ydb/core/kqp/federated_query/kqp_federated_query_actors.cpp
	ydb/services/metadata/secret/snapshot.cpp
	ydb/services/metadata/secret/snapshot.h
zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025
Conflicts:
	ydb/core/kqp/federated_query/kqp_federated_query_actors.cpp
	ydb/services/metadata/secret/snapshot.cpp
	ydb/services/metadata/secret/snapshot.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants