Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont reallocate memory after merge through incorrect memory consumpti… #12623

Conversation

ivanmorozov333
Copy link
Collaborator

…on method

  • Improvement
  • Performance improvement
  • Bugfix

Copy link

github-actions bot commented Dec 14, 2024

2024-12-14 16:02:00 UTC Pre-commit check linux-x86_64-release-asan for 3241a7d has started.
2024-12-14 16:02:11 UTC Artifacts will be uploaded here
2024-12-14 16:05:09 UTC ya make is running...
🟡 2024-12-14 17:11:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13668 13592 0 22 7 47

🟢 2024-12-14 17:12:29 UTC Build successful.
🟢 2024-12-14 17:12:52 UTC ydbd size 3.6 GiB changed* by +70.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b40adfb merge: 3241a7d diff diff %
ydbd size 3 890 190 856 Bytes 3 890 263 160 Bytes +70.6 KiB +0.002%
ydbd stripped size 1 362 075 536 Bytes 1 362 090 960 Bytes +15.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 14, 2024

2024-12-14 16:02:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3241a7d has started.
2024-12-14 16:02:24 UTC Artifacts will be uploaded here
2024-12-14 16:05:23 UTC ya make is running...
🟡 2024-12-14 16:57:45 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20876 19345 0 5 1411 115

2024-12-14 16:59:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-14 17:10:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
166 (only retried tests) 59 0 0 0 107

🟢 2024-12-14 17:10:54 UTC Build successful.
🟢 2024-12-14 17:11:11 UTC ydbd size 2.1 GiB changed* by +34.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: b40adfb merge: 3241a7d diff diff %
ydbd size 2 251 547 488 Bytes 2 251 582 648 Bytes +34.3 KiB +0.002%
ydbd stripped size 482 543 952 Bytes 482 548 944 Bytes +4.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@ivanmorozov333 ivanmorozov333 marked this pull request as ready for review December 15, 2024 04:57
@ivanmorozov333 ivanmorozov333 requested a review from a team as a code owner December 15, 2024 04:57
@ivanmorozov333 ivanmorozov333 merged commit 0fddef1 into ydb-platform:main Dec 15, 2024
11 checks passed
@ivanmorozov333 ivanmorozov333 deleted the correct_reallocation_memory_after_merger branch December 15, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants