Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for non-scan read columns requests #1240

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Remove support for non-scan read columns requests #1240

merged 1 commit into from
Jan 24, 2024

Conversation

snaury
Copy link
Member

@snaury snaury commented Jan 23, 2024

Changelog entry

Remove support for non-scan read columns requests

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

This legacy request doesn't support volatile transactions and adding support is more complicated than removing it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

⚪ 2024-01-24 08:42:49 UTC Pre-commit check for 68f7986 has started.
⚪ 2024-01-24 08:42:51 UTC Build linux-x86_64-release-asan is running...
🟢 2024-01-24 08:48:18 UTC Build successful.
⚪ 2024-01-24 08:48:30 UTC Tests are running...
🔴 2024-01-24 10:24:09 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15924 15806 0 21 62 35

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

⚪ 2024-01-24 08:41:39 UTC Pre-commit check for 68f7986 has started.
⚪ 2024-01-24 08:41:42 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-01-24 08:46:40 UTC Build successful.
⚪ 2024-01-24 08:46:54 UTC Tests are running...
🔴 2024-01-24 09:58:45 UTC Some tests failed, follow the links below.

Test history

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
60029 50757 0 12 9236 24

@snaury snaury force-pushed the KIKIMR-16343-remove-non-scan-read-columns branch from f80489d to ddf826f Compare January 23, 2024 16:13
@snaury snaury force-pushed the KIKIMR-16343-remove-non-scan-read-columns branch from ddf826f to 68f7986 Compare January 24, 2024 08:38
@snaury snaury requested a review from azevaykin January 24, 2024 10:25
@snaury snaury marked this pull request as ready for review January 24, 2024 10:25
@snaury snaury merged commit 57fe793 into ydb-platform:main Jan 24, 2024
2 of 4 checks passed
@snaury snaury deleted the KIKIMR-16343-remove-non-scan-read-columns branch January 24, 2024 10:35
@pavelvelikhov pavelvelikhov mentioned this pull request Jan 24, 2024
Merged
@FloatingCrowbar FloatingCrowbar mentioned this pull request Jan 24, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 25, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 25, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Jan 25, 2024
Merged
This was referenced Jan 25, 2024
Merged
Merged
Merged
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Jan 29, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 29, 2024
Merged
@shnikd shnikd mentioned this pull request Jan 29, 2024
Merged
This was referenced Jan 29, 2024
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Jan 30, 2024
Merged
@vitstn vitstn mentioned this pull request Jan 30, 2024
Merged
@shnikd shnikd mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 5, 2024
Merged
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 5, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 5, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 5, 2024
Merged
This was referenced Feb 6, 2024
Closed
Merged
This was referenced Feb 6, 2024
Merged
Merged
Merged
Merged
Merged
@ildar-khisambeev ildar-khisambeev mentioned this pull request Feb 8, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 8, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 9, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 9, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 12, 2024
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Closed
This was referenced Feb 12, 2024
Merged
Merged
@starlinskiy starlinskiy mentioned this pull request Feb 12, 2024
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 13, 2024
Merged
This was referenced Feb 13, 2024
Merged
Merged
Merged
@pavelvelikhov pavelvelikhov mentioned this pull request Feb 15, 2024
Merged
@niksaveliev niksaveliev mentioned this pull request Feb 16, 2024
Merged
@vitstn vitstn mentioned this pull request Feb 16, 2024
Merged
@aakulaga-ydb aakulaga-ydb mentioned this pull request Feb 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azevaykin azevaykin azevaykin approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snaury @azevaykin