Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register memory allocated for metadata in tiering actualizer #12348

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

swalrus1
Copy link
Collaborator

@swalrus1 swalrus1 commented Dec 6, 2024

No description provided.

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 09:06:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 53e49f6 has started.
2024-12-06 09:07:09 UTC Artifacts will be uploaded here
2024-12-06 09:10:10 UTC ya make is running...
🟡 2024-12-06 10:21:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32494 29658 0 2 2721 113

2024-12-06 10:23:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-06 10:35:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
662 (only retried tests) 555 0 0 0 107

🟢 2024-12-06 10:36:01 UTC Build successful.
🟡 2024-12-06 10:36:20 UTC ydbd size 2.5 GiB changed* by +111.0 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 50445e3 merge: 53e49f6 diff diff %
ydbd size 2 700 950 576 Bytes 2 701 064 272 Bytes +111.0 KiB +0.004%
ydbd stripped size 483 730 608 Bytes 483 735 344 Bytes +4.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 09:08:38 UTC Pre-commit check linux-x86_64-release-asan for 53e49f6 has started.
2024-12-06 09:08:50 UTC Artifacts will be uploaded here
2024-12-06 09:11:49 UTC ya make is running...
🟡 2024-12-06 10:24:37 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15071 14999 0 18 8 46

🟢 2024-12-06 10:25:52 UTC Build successful.
🟡 2024-12-06 10:26:20 UTC ydbd size 4.9 GiB changed* by +317.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 2c54115 merge: 53e49f6 diff diff %
ydbd size 5 306 453 320 Bytes 5 306 778 584 Bytes +317.6 KiB +0.006%
ydbd stripped size 1 365 872 112 Bytes 1 365 906 832 Bytes +33.9 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 10:41:39 UTC Pre-commit check linux-x86_64-release-asan for 50fb435 has started.
2024-12-06 10:41:50 UTC Artifacts will be uploaded here
2024-12-06 10:44:54 UTC ya make is running...
🔴 2024-12-06 11:02:23 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 10:41:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 50fb435 has started.
2024-12-06 10:42:06 UTC Artifacts will be uploaded here
2024-12-06 10:45:06 UTC ya make is running...
🔴 2024-12-06 11:03:01 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 12:55:49 UTC Pre-commit check linux-x86_64-relwithdebinfo for 711ce68 has started.
2024-12-06 12:56:00 UTC Artifacts will be uploaded here
2024-12-06 12:58:59 UTC ya make is running...
🟡 2024-12-06 13:56:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32500 29668 0 2 2720 110

2024-12-06 13:59:15 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-06 14:11:32 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
688 (only retried tests) 579 0 0 1 108

🟢 2024-12-06 14:11:41 UTC Build successful.
🟡 2024-12-06 14:11:59 UTC ydbd size 2.5 GiB changed* by +116.9 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 17066f1 merge: 711ce68 diff diff %
ydbd size 2 699 201 576 Bytes 2 699 321 272 Bytes +116.9 KiB +0.004%
ydbd stripped size 483 500 720 Bytes 483 505 456 Bytes +4.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 12:55:59 UTC Pre-commit check linux-x86_64-release-asan for 711ce68 has started.
2024-12-06 12:56:10 UTC Artifacts will be uploaded here
2024-12-06 12:59:10 UTC ya make is running...
🟡 2024-12-06 14:07:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15072 15004 0 18 6 44

🟢 2024-12-06 14:08:43 UTC Build successful.
🟡 2024-12-06 14:09:12 UTC ydbd size 4.9 GiB changed* by +222.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 17066f1 merge: 711ce68 diff diff %
ydbd size 5 305 570 352 Bytes 5 305 798 000 Bytes +222.3 KiB +0.004%
ydbd stripped size 1 365 574 736 Bytes 1 365 592 304 Bytes +17.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 marked this pull request as ready for review December 9, 2024 07:36
@swalrus1 swalrus1 requested a review from a team as a code owner December 9, 2024 07:36
Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 07:43:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8a88bab has started.
2024-12-09 07:44:05 UTC Artifacts will be uploaded here
2024-12-09 07:47:04 UTC ya make is running...
🟡 2024-12-09 08:52:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32512 29677 0 1 2722 112

2024-12-09 08:54:39 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-09 09:05:59 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
691 (only retried tests) 583 0 0 0 108

🟢 2024-12-09 09:06:08 UTC Build successful.
🟡 2024-12-09 09:06:27 UTC ydbd size 2.5 GiB changed* by +120.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1382681 merge: 8a88bab diff diff %
ydbd size 2 699 417 000 Bytes 2 699 540 728 Bytes +120.8 KiB +0.005%
ydbd stripped size 483 519 568 Bytes 483 528 336 Bytes +8.6 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 07:44:06 UTC Pre-commit check linux-x86_64-release-asan for 8a88bab has started.
2024-12-09 07:44:17 UTC Artifacts will be uploaded here
2024-12-09 07:47:28 UTC ya make is running...
🟡 2024-12-09 09:07:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15085 15000 0 29 8 48

🟢 2024-12-09 09:08:23 UTC Build successful.
🟡 2024-12-09 09:08:55 UTC ydbd size 4.9 GiB changed* by +222.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 1382681 merge: 8a88bab diff diff %
ydbd size 5 305 993 888 Bytes 5 306 221 552 Bytes +222.3 KiB +0.004%
ydbd stripped size 1 365 623 632 Bytes 1 365 641 200 Bytes +17.2 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 12:46:06 UTC Pre-commit check linux-x86_64-release-asan for c2f62d2 has started.
2024-12-09 12:46:40 UTC Artifacts will be uploaded here
2024-12-09 12:50:13 UTC ya make is running...
🔴 2024-12-09 13:07:33 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 12:47:26 UTC Pre-commit check linux-x86_64-relwithdebinfo for c2f62d2 has started.
2024-12-09 12:47:37 UTC Artifacts will be uploaded here
2024-12-09 12:50:38 UTC ya make is running...
🔴 2024-12-09 13:02:51 UTC Build failed, see the logs. Also see fail summary

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 13:19:37 UTC Pre-commit check linux-x86_64-release-asan for 6ec7052 has started.
2024-12-09 13:20:07 UTC Artifacts will be uploaded here
2024-12-09 13:23:06 UTC ya make is running...
🟡 2024-12-09 14:32:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15085 15013 0 21 5 46

🟢 2024-12-09 14:33:30 UTC Build successful.
🟢 2024-12-09 14:33:58 UTC ydbd size 4.9 GiB changed* by -231.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0a7a679 merge: 6ec7052 diff diff %
ydbd size 5 305 817 416 Bytes 5 305 580 840 Bytes -231.0 KiB -0.004%
ydbd stripped size 1 365 569 648 Bytes 1 365 573 712 Bytes +4.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 13:21:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6ec7052 has started.
2024-12-09 13:21:20 UTC Artifacts will be uploaded here
2024-12-09 13:24:19 UTC ya make is running...
🟡 2024-12-09 14:25:08 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32512 29680 0 2 2720 110

2024-12-09 14:27:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-09 14:39:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
647 (only retried tests) 541 0 0 0 106

🟢 2024-12-09 14:40:00 UTC Build successful.
🟢 2024-12-09 14:40:19 UTC ydbd size 2.5 GiB changed* by -119.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 0a7a679 merge: 6ec7052 diff diff %
ydbd size 2 699 396 888 Bytes 2 699 274 472 Bytes -119.5 KiB -0.005%
ydbd stripped size 483 497 424 Bytes 483 500 624 Bytes +3.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 15:48:03 UTC Pre-commit check linux-x86_64-release-asan for b3b88bc has started.
2024-12-09 15:48:15 UTC Artifacts will be uploaded here
2024-12-09 15:51:15 UTC ya make is running...
2024-12-09 16:19:10 UTC Check cancelled

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 15:48:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for b3b88bc has started.
2024-12-09 15:48:30 UTC Artifacts will be uploaded here
2024-12-09 15:51:30 UTC ya make is running...
2024-12-09 16:18:58 UTC Check cancelled

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 16:21:10 UTC Pre-commit check linux-x86_64-relwithdebinfo for 99fa914 has started.
2024-12-09 16:21:43 UTC Artifacts will be uploaded here
2024-12-09 16:25:22 UTC ya make is running...
2024-12-09 16:32:04 UTC Check cancelled

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 16:22:10 UTC Pre-commit check linux-x86_64-release-asan for 99fa914 has started.
2024-12-09 16:22:22 UTC Artifacts will be uploaded here
2024-12-09 16:25:22 UTC ya make is running...
2024-12-09 16:32:04 UTC Check cancelled

TEvMetadataAccessorsInfo(
const std::shared_ptr<NOlap::IMetadataAccessorResultProcessor>& processor, const ui64 gen, NOlap::TDataAccessorsResult&& result)
TEvMetadataAccessorsInfo(const std::shared_ptr<NOlap::IMetadataAccessorResultProcessor>& processor, const ui64 gen,
NOlap::NResourceBroker::NSubscribe::TResourceContainer<NOlap::TDataAccessorsResult> result)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&&


namespace NKikimr::NOlap {

class TDataAccessorsRequest;

class TDataAccessorsResult {
class TDataAccessorsResult : private NNonCopyable::TMoveOnly {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space

@@ -23,7 +23,7 @@ void TCleanupPortionsColumnEngineChanges::DoWriteIndexOnExecute(NColumnShard::TC
return;
}
THashMap<TString, THashSet<TUnifiedBlobId>> blobIdsByStorage;
for (auto&& p : FetchedDataAccessors->GetPortions()) {
for (auto&& [id, p] : FetchedDataAccessors->GetPortions()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_

return {};
}
return { *req };
auto reqs = TieringActualizer->BuildMetadataRequests(PathId, portions, TieringActualizer);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

}
std::shared_ptr<TDataAccessorsRequest> result = std::make_shared<TDataAccessorsRequest>();

const ui64 batchMemorySoftLimit = !NYDBTest::TControllers::GetColumnShardController()->GetMetadataRequestSoftMemoryLimit();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@swalrus1 swalrus1 force-pushed the tiering-resources-2 branch from 9e2d250 to 1d50a0a Compare December 9, 2024 16:33
Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 16:34:57 UTC Pre-commit check linux-x86_64-release-asan for 676fbe0 has started.
2024-12-09 16:35:08 UTC Artifacts will be uploaded here
2024-12-09 16:38:12 UTC ya make is running...
🟡 2024-12-09 17:53:35 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15086 15027 0 9 4 46

🟢 2024-12-09 17:54:47 UTC Build successful.
🟢 2024-12-09 17:55:15 UTC ydbd size 4.9 GiB changed* by -227.7 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c146758 merge: 676fbe0 diff diff %
ydbd size 5 305 433 960 Bytes 5 305 200 816 Bytes -227.7 KiB -0.004%
ydbd stripped size 1 365 506 928 Bytes 1 365 515 024 Bytes +7.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 9, 2024

2024-12-09 16:34:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 676fbe0 has started.
2024-12-09 16:35:12 UTC Artifacts will be uploaded here
2024-12-09 16:38:14 UTC ya make is running...
🟡 2024-12-09 17:41:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32513 29678 0 4 2720 111

2024-12-09 17:44:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-09 17:56:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
647 (only retried tests) 539 0 1 0 107

2024-12-09 17:56:22 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-12-09 18:08:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
629 (only retried tests) 522 0 0 0 107

🟢 2024-12-09 18:08:21 UTC Build successful.
🟢 2024-12-09 18:08:42 UTC ydbd size 2.5 GiB changed* by -124.3 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: c146758 merge: 676fbe0 diff diff %
ydbd size 2 699 240 416 Bytes 2 699 113 120 Bytes -124.3 KiB -0.005%
ydbd stripped size 483 482 768 Bytes 483 481 808 Bytes -960 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 merged commit 34cd26c into ydb-platform:main Dec 10, 2024
10 checks passed
@swalrus1 swalrus1 deleted the tiering-resources-2 branch December 10, 2024 09:01
@swalrus1 swalrus1 linked an issue Dec 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record memory used by portion metadata in CS tiering actualizer
2 participants