Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The value of PQ/BytesWriteOK for writing to a transaction #12337

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

Alek5andr-Kotov
Copy link
Collaborator

@Alek5andr-Kotov Alek5andr-Kotov commented Dec 5, 2024

Changelog entry

The partition periodically transmits a set of PQ/* indicators to the PQ tablet. This is also done by the service partition for writing to the transaction. If the duration of the transaction is less than the period of transfer of indicators, then part of the data was lost. Now, the service partition transmits the accumulated indicators to the PQ tablet before deletion.

Changelog category

  • Bugfix
  • Not for changelog (changelog entry is not required)

Additional information

...

@Alek5andr-Kotov Alek5andr-Kotov requested a review from a team as a code owner December 5, 2024 18:31
@Alek5andr-Kotov Alek5andr-Kotov requested a review from qyryq December 5, 2024 18:31
@github-actions github-actions bot added the bugfix label Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 18:33:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8089adf has started.
2024-12-05 18:34:09 UTC Artifacts will be uploaded here
2024-12-05 18:37:03 UTC ya make is running...
🟡 2024-12-05 19:26:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20998 19444 0 2 1440 112

2024-12-05 19:28:06 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-05 19:40:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
725 (only retried tests) 618 0 0 0 107

🟢 2024-12-05 19:40:21 UTC Build successful.
🟢 2024-12-05 19:40:40 UTC ydbd size 2.5 GiB changed* by +80 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: cabd293 merge: 8089adf diff diff %
ydbd size 2 700 783 160 Bytes 2 700 783 240 Bytes +80 Bytes +0.000%
ydbd stripped size 483 690 864 Bytes 483 690 928 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 18:34:33 UTC Pre-commit check linux-x86_64-release-asan for 8089adf has started.
2024-12-05 18:34:45 UTC Artifacts will be uploaded here
2024-12-05 18:37:39 UTC ya make is running...
🟡 2024-12-05 19:40:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13281 13201 0 27 5 48

🟢 2024-12-05 19:41:45 UTC Build successful.
🟢 2024-12-05 19:42:14 UTC ydbd size 4.9 GiB changed* by +48 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 1ab6e3b merge: 8089adf diff diff %
ydbd size 5 306 189 480 Bytes 5 306 189 528 Bytes +48 Bytes +0.000%
ydbd stripped size 1 365 793 840 Bytes 1 365 793 904 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 08:35:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for 72796cb has started.
2024-12-06 08:35:55 UTC Artifacts will be uploaded here
2024-12-06 08:38:47 UTC ya make is running...
🟡 2024-12-06 09:26:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20998 19490 0 2 1396 110

2024-12-06 09:28:25 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-06 09:40:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
720 (only retried tests) 613 0 0 0 107

🟢 2024-12-06 09:40:39 UTC Build successful.
🟢 2024-12-06 09:40:58 UTC ydbd size 2.5 GiB changed* by +80 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 44331c2 merge: 72796cb diff diff %
ydbd size 2 700 783 320 Bytes 2 700 783 400 Bytes +80 Bytes +0.000%
ydbd stripped size 483 690 864 Bytes 483 690 928 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 6, 2024

2024-12-06 08:35:50 UTC Pre-commit check linux-x86_64-release-asan for 72796cb has started.
2024-12-06 08:36:02 UTC Artifacts will be uploaded here
2024-12-06 08:38:55 UTC ya make is running...
🟡 2024-12-06 09:44:24 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13282 13204 0 19 12 47

🟢 2024-12-06 09:45:28 UTC Build successful.
🟢 2024-12-06 09:46:05 UTC ydbd size 4.9 GiB changed* by +112 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 44331c2 merge: 72796cb diff diff %
ydbd size 5 306 189 528 Bytes 5 306 189 640 Bytes +112 Bytes +0.000%
ydbd stripped size 1 365 793 776 Bytes 1 365 793 904 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added bugfix and removed bugfix labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants