Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CBO Level 1 and Level 2 #12321

Merged

Conversation

pavelvelikhov
Copy link
Collaborator

Changelog entry

CBO at Level 2 was activated when some tables in the queries were not Data Shard tables, and this included AS_Table constructs and parameters.
CBO at Level 1 was broken due to a missing commit

Changelog category

  • Bugfix

Additional information

...

@pavelvelikhov pavelvelikhov requested a review from a team as a code owner December 5, 2024 12:55
Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 12:59:05 UTC Pre-commit check for 326295b has started.
2024-12-05 13:01:57 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-12-05 13:09:40 UTC Build successful.

Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 12:59:05 UTC Pre-commit check for 326295b has started.
2024-12-05 13:01:44 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-05 13:26:03 UTC Build successful.
2024-12-05 13:26:23 UTC Tests are running...
🔴 2024-12-05 15:33:54 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11037 10914 0 30 52 41

🟢 2024-12-05 15:34:35 UTC ydbd size 5.6 GiB changed* by +1.4 KiB, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: d91df89 merge: 326295b diff diff %
ydbd size 5 998 629 824 Bytes 5 998 631 216 Bytes +1.4 KiB +0.000%
ydbd stripped size 1 503 251 808 Bytes 1 503 252 128 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 12:59:06 UTC Pre-commit check for 326295b has started.
2024-12-05 13:01:58 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-05 13:44:23 UTC Build successful.
2024-12-05 13:44:38 UTC Tests are running...
🔴 2024-12-05 16:01:09 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72132 58647 0 9 13434 42

🟢 2024-12-05 16:02:08 UTC ydbd size 8.3 GiB changed* by +432 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: d91df89 merge: 326295b diff diff %
ydbd size 8 868 192 768 Bytes 8 868 193 200 Bytes +432 Bytes +0.000%
ydbd stripped size 484 082 664 Bytes 484 082 792 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@pavelvelikhov pavelvelikhov merged commit b2203a9 into ydb-platform:stable-24-3 Dec 5, 2024
8 of 12 checks passed
zinal added a commit to zinal/ydb that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants