Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support intersecting hosts in MergeBoxes (merge from main #12282) #12316

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Dec 5, 2024

Changelog entry

Support intersecting hosts in MergeBoxes

Changelog category

  • Not for changelog (changelog entry is not required)

Additional information

BSC now supports intersecting hosts in MergeBoxes command, automatically merging HostConfigs.

@alexvru alexvru requested a review from a team as a code owner December 5, 2024 11:46
Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 11:48:49 UTC Pre-commit check for 82049d1 has started.
2024-12-05 11:51:53 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-05 12:14:25 UTC Build successful.
2024-12-05 12:14:44 UTC Tests are running...
🔴 2024-12-05 12:26:41 UTC Test run completed, no test results found for commit 06d6e2f. Please check test log.
🟢 2024-12-05 12:28:39 UTC ydbd size 5.6 GiB changed* by +76.8 KiB, which is < 100.0 KiB vs stable-24-3-11-hotfix: OK

ydbd size dash stable-24-3-11-hotfix: 2f9a0e3 merge: 82049d1 diff diff %
ydbd size 5 961 837 208 Bytes 5 961 915 864 Bytes +76.8 KiB +0.001%
ydbd stripped size 1 496 157 504 Bytes 1 496 167 744 Bytes +10.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-12-05 12:28:41 UTC Check cancelled

Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 11:50:05 UTC Pre-commit check for 82049d1 has started.
2024-12-05 11:52:46 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-12-05 11:56:24 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 11:51:45 UTC Pre-commit check for 82049d1 has started.
2024-12-05 11:54:54 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-12-05 12:15:09 UTC Build failed. see the build logs.
🔴 2024-12-05 12:15:11 UTC Tests run skipped.

kruall
kruall previously approved these changes Dec 5, 2024
@alexvru alexvru added the rebase-and-check Rebase PR with the current base branch and check label Dec 5, 2024
fomichev3000
fomichev3000 previously approved these changes Dec 5, 2024
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 12:32:29 UTC Pre-commit check for 82049d1 has started.
2024-12-05 12:35:03 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-05 13:14:35 UTC Build successful.
2024-12-05 13:14:54 UTC Tests are running...
🔴 2024-12-05 14:39:20 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14606 13259 0 6 1299 42

🟡 2024-12-05 14:40:07 UTC ydbd size 8.2 GiB changed* by +154.9 KiB, which is >= 100.0 KiB vs stable-24-3-11-hotfix: Warning

ydbd size dash stable-24-3-11-hotfix: 2f9a0e3 merge: 82049d1 diff diff %
ydbd size 8 817 164 968 Bytes 8 817 323 576 Bytes +154.9 KiB +0.002%
ydbd stripped size 482 086 824 Bytes 482 090 664 Bytes +3.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 12:32:45 UTC Pre-commit check for 82049d1 has started.
2024-12-05 12:35:18 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-05 12:57:44 UTC Build successful.
2024-12-05 12:58:02 UTC Tests are running...
🔴 2024-12-05 14:55:30 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10304 10221 0 13 24 46

🟢 2024-12-05 14:56:21 UTC ydbd size 5.6 GiB changed* by +76.8 KiB, which is < 100.0 KiB vs stable-24-3-11-hotfix: OK

ydbd size dash stable-24-3-11-hotfix: 2f9a0e3 merge: 82049d1 diff diff %
ydbd size 5 961 837 208 Bytes 5 961 915 864 Bytes +76.8 KiB +0.001%
ydbd stripped size 1 496 157 504 Bytes 1 496 167 744 Bytes +10.0 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 12:32:47 UTC Pre-commit check for 82049d1 has started.
2024-12-05 12:35:21 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-12-05 12:38:41 UTC Build failed. see the build logs.

@alexvru alexvru dismissed stale reviews from fomichev3000 and kruall via c52f3be December 5, 2024 16:04
@alexvru alexvru force-pushed the merge/24-3-11-hotfix/12282 branch from 06d6e2f to c52f3be Compare December 5, 2024 16:04
Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 16:09:11 UTC Pre-commit check for 054036f has started.
2024-12-05 16:11:48 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-12-05 16:18:51 UTC Build successful.

Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 16:09:39 UTC Pre-commit check for 054036f has started.
2024-12-05 16:12:14 UTC Build linux-x86_64-release-asan is running...
🟢 2024-12-05 16:34:57 UTC Build successful.
2024-12-05 16:35:22 UTC Tests are running...
🔴 2024-12-05 18:32:04 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
10304 10222 0 12 25 45

🟢 2024-12-05 18:32:49 UTC ydbd size 5.6 GiB changed* by +76.2 KiB, which is < 100.0 KiB vs stable-24-3-11-hotfix: OK

ydbd size dash stable-24-3-11-hotfix: 2f9a0e3 merge: 054036f diff diff %
ydbd size 5 961 837 208 Bytes 5 961 915 240 Bytes +76.2 KiB +0.001%
ydbd stripped size 1 496 157 504 Bytes 1 496 167 552 Bytes +9.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 5, 2024

2024-12-05 16:12:01 UTC Pre-commit check for 054036f has started.
2024-12-05 16:14:37 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-12-05 16:53:14 UTC Build successful.
2024-12-05 16:53:33 UTC Tests are running...
🔴 2024-12-05 18:17:46 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14605 13254 0 6 1301 44

🟡 2024-12-05 18:18:34 UTC ydbd size 8.2 GiB changed* by +154.5 KiB, which is >= 100.0 KiB vs stable-24-3-11-hotfix: Warning

ydbd size dash stable-24-3-11-hotfix: 2f9a0e3 merge: 054036f diff diff %
ydbd size 8 817 164 968 Bytes 8 817 323 176 Bytes +154.5 KiB +0.002%
ydbd stripped size 482 086 824 Bytes 482 090 600 Bytes +3.7 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@sourcecd sourcecd merged commit aa89322 into ydb-platform:stable-24-3-11-hotfix Dec 5, 2024
8 of 12 checks passed
@alexvru alexvru deleted the merge/24-3-11-hotfix/12282 branch January 15, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants