Optionally allow nullable pk in column tables #12286

aavdonkin · 2024-12-04T14:10:27Z

Changelog entry

...

Additional information

...

github-actions · 2024-12-04T14:43:04Z

⚪ 2024-12-04 14:43:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for a9c27a7 has started.
⚪ 2024-12-04 14:43:15 UTC Artifacts will be uploaded here
⚪ 2024-12-04 14:46:30 UTC ya make is running...
🟡 2024-12-04 16:11:02 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
32685	29854	0	2	2719	110

⚪ 2024-12-04 16:13:42 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-04 16:25:07 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
690 (only retried tests)	584	0	1	0	105

⚪ 2024-12-04 16:25:20 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-04 16:36:36 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
612 (only retried tests)	506	0	1	0	105

🟢 2024-12-04 16:36:45 UTC Build successful.
🟢 2024-12-04 16:37:05 UTC ydbd size 2.5 GiB changed* by +2.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4f34c1a`	merge: `a9c27a7`	diff	diff %
ydbd size	2 702 464 680 Bytes	2 702 467 144 Bytes	+2.4 KiB	+0.000%
ydbd stripped size	483 670 512 Bytes	483 670 896 Bytes	+384 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-04T14:43:17Z

⚪ 2024-12-04 14:43:17 UTC Pre-commit check linux-x86_64-release-asan for a9c27a7 has started.
⚪ 2024-12-04 14:43:29 UTC Artifacts will be uploaded here
⚪ 2024-12-04 14:46:48 UTC ya make is running...
🟡 2024-12-04 16:25:02 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15230	15168	0	11	4	47

🟢 2024-12-04 16:26:17 UTC Build successful.
🟢 2024-12-04 16:26:45 UTC ydbd size 4.9 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4f34c1a`	merge: `a9c27a7`	diff	diff %
ydbd size	5 309 573 408 Bytes	5 309 577 872 Bytes	+4.4 KiB	+0.000%
ydbd stripped size	1 365 834 672 Bytes	1 365 835 184 Bytes	+512 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-04T17:05:46Z

⚪ 2024-12-04 17:05:46 UTC Pre-commit check linux-x86_64-release-asan for 1e3ccf8 has started.
⚪ 2024-12-04 17:06:28 UTC Artifacts will be uploaded here
⚪ 2024-12-04 17:10:05 UTC ya make is running...
🟡 2024-12-04 18:44:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15231	15158	0	17	9	47

🟢 2024-12-04 18:45:21 UTC Build successful.
🟢 2024-12-04 18:45:47 UTC ydbd size 4.9 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4f81e50`	merge: `1e3ccf8`	diff	diff %
ydbd size	5 303 846 064 Bytes	5 303 850 544 Bytes	+4.4 KiB	+0.000%
ydbd stripped size	1 365 280 304 Bytes	1 365 280 816 Bytes	+512 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-04T17:07:33Z

⚪ 2024-12-04 17:07:32 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1e3ccf8 has started.
⚪ 2024-12-04 17:07:44 UTC Artifacts will be uploaded here
⚪ 2024-12-04 17:11:10 UTC ya make is running...
🟡 2024-12-04 18:44:19 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
32686	29843	0	3	2725	115

⚪ 2024-12-04 18:46:59 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-04 18:58:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
809 (only retried tests)	703	0	0	0	106

🟢 2024-12-04 18:58:55 UTC Build successful.
🟢 2024-12-04 18:59:17 UTC ydbd size 2.5 GiB changed* by +2.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `4f81e50`	merge: `1e3ccf8`	diff	diff %
ydbd size	2 699 616 168 Bytes	2 699 618 648 Bytes	+2.4 KiB	+0.000%
ydbd stripped size	483 505 072 Bytes	483 505 456 Bytes	+384 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/core/tx/schemeshard/olap/operations/create_table.cpp

zverevgeny · 2024-12-04T19:12:03Z

ydb/core/tx/schemeshard/ut_olap/ut_olap.cpp

+        )");
+        env.TestWaitNotification(runtime, txId);
+
+        TestLsPathId(runtime, 4, NLs::PathStringEqual("/MyRoot/MyDir/MyTable"));


Что такое 4?

Это pathId таблицы, они назначаются последовательно

github-actions · 2024-12-05T09:15:09Z

⚪ 2024-12-05 09:15:08 UTC Pre-commit check linux-x86_64-release-asan for 70cc091 has started.
⚪ 2024-12-05 09:15:20 UTC Artifacts will be uploaded here
⚪ 2024-12-05 09:18:33 UTC ya make is running...
🟡 2024-12-05 10:57:07 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
15231	15151	0	25	9	46

🟢 2024-12-05 10:58:30 UTC Build successful.
🟢 2024-12-05 10:58:59 UTC ydbd size 4.9 GiB changed* by +4.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `ffa5093`	merge: `70cc091`	diff	diff %
ydbd size	5 304 181 048 Bytes	5 304 185 528 Bytes	+4.4 KiB	+0.000%
ydbd stripped size	1 365 337 968 Bytes	1 365 338 480 Bytes	+512 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-12-05T09:15:33Z

⚪ 2024-12-05 09:15:33 UTC Pre-commit check linux-x86_64-relwithdebinfo for 70cc091 has started.
⚪ 2024-12-05 09:16:20 UTC Artifacts will be uploaded here
⚪ 2024-12-05 09:20:31 UTC ya make is running...
🟡 2024-12-05 10:55:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
32686	29843	0	3	2726	114

⚪ 2024-12-05 10:58:58 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-12-05 11:11:03 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
745 (only retried tests)	640	0	0	0	105

🟢 2024-12-05 11:11:16 UTC Build successful.
🟢 2024-12-05 11:11:38 UTC ydbd size 2.5 GiB changed* by +2.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `ffa5093`	merge: `70cc091`	diff	diff %
ydbd size	2 699 922 216 Bytes	2 699 924 696 Bytes	+2.4 KiB	+0.000%
ydbd stripped size	483 579 248 Bytes	483 579 632 Bytes	+384 Bytes	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

Conflicts: ydb/core/tx/schemeshard/ut_olap/ut_olap.cpp

Optionally allow nullable pk in column tables

26fd95f

github-actions bot added the new-feature label Dec 4, 2024

aavdonkin linked an issue Dec 4, 2024 that may be closed by this pull request

ColumnTables do not support nullable columns in PK #11300

Closed

Merge branch 'main' into columnshard_nullable_pk

3e5e4ae

Fixed test

edf8540

zverevgeny reviewed Dec 4, 2024

View reviewed changes

ydb/core/tx/schemeshard/olap/operations/create_table.cpp Show resolved Hide resolved

zverevgeny reviewed Dec 4, 2024

View reviewed changes

Removed default parameter value

2e7bcd3

zverevgeny approved these changes Dec 5, 2024

View reviewed changes

aavdonkin merged commit e1bc51a into ydb-platform:main Dec 5, 2024
10 checks passed

This was referenced Dec 10, 2024

YQ-3955-RD fixed field ids error #12454

Closed

YQ-3955 RD fixed uncaught exception error #12465

Merged

YQ-3926 RD added parallel purecalc compilation #12505

Merged

niksaveliev mentioned this pull request Dec 25, 2024

Kafka connect distributed #12960

Open

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 2, 2025

Optionally allow nullable pk in column tables (ydb-platform#12286)

7bc8daa

Conflicts: ydb/core/tx/schemeshard/ut_olap/ut_olap.cpp

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025

Optionally allow nullable pk in column tables (ydb-platform#12286)

82ce16b

Conflicts: ydb/core/tx/schemeshard/ut_olap/ut_olap.cpp

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 5, 2025

Optionally allow nullable pk in column tables (ydb-platform#12286)

9096227

Conflicts: ydb/core/tx/schemeshard/ut_olap/ut_olap.cpp

zverevgeny pushed a commit to zverevgeny/ydb that referenced this pull request Jan 8, 2025

Optionally allow nullable pk in column tables (ydb-platform#12286)

36d45cd

Conflicts: ydb/core/tx/schemeshard/ut_olap/ut_olap.cpp

zverevgeny mentioned this pull request Jan 9, 2025

Integrate changes from main #13202

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optionally allow nullable pk in column tables #12286

Optionally allow nullable pk in column tables #12286

aavdonkin commented Dec 4, 2024

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

zverevgeny Dec 4, 2024

aavdonkin Dec 5, 2024

github-actions bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading

Optionally allow nullable pk in column tables #12286

Optionally allow nullable pk in column tables #12286

Conversation

aavdonkin commented Dec 4, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Dec 4, 2024 • edited Loading

github-actions bot commented Dec 4, 2024 • edited Loading

github-actions bot commented Dec 4, 2024 • edited Loading

github-actions bot commented Dec 4, 2024 • edited Loading

zverevgeny Dec 4, 2024

Choose a reason for hiding this comment

aavdonkin Dec 5, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 5, 2024 • edited Loading

github-actions bot commented Dec 5, 2024 • edited Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 4, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading

github-actions bot commented Dec 5, 2024 •

edited

Loading